[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] aio-wait: avoid AioContext lock in aio_wait_bh_oneshot()
From: |
Kevin Wolf |
Subject: |
Re: [PATCH] aio-wait: avoid AioContext lock in aio_wait_bh_oneshot() |
Date: |
Thu, 27 Apr 2023 14:39:14 +0200 |
Am 04.04.2023 um 17:33 hat Stefan Hajnoczi geschrieben:
> There is no need for the AioContext lock in aio_wait_bh_oneshot().
> It's easy to remove the lock from existing callers and then switch from
> AIO_WAIT_WHILE() to AIO_WAIT_WHILE_UNLOCKED() in aio_wait_bh_oneshot().
>
> Document that the AioContext lock should not be held across
> aio_wait_bh_oneshot(). Holding a lock across aio_poll() can cause
> deadlock so we don't want callers to do that.
>
> This is a step towards getting rid of the AioContext lock.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, applied to the block branch.
Kevin