qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 591f73: hw/arm/nseries: don't print to stdout

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 591f73: hw/arm/nseries: don't print to stdout or stderr
Date: Sat, 06 Apr 2013 07:30:09 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 591f73f642a5f3c822c3efaae8d83a174371a4f5
      
https://github.com/qemu/qemu/commit/591f73f642a5f3c822c3efaae8d83a174371a4f5
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/arm/nseries.c

  Log Message:
  -----------
  hw/arm/nseries: don't print to stdout or stderr

Remove various bits of printing to stdout or stderr from the
nseries code, replacing it with a qemu log message where there's
an appropriate log category, and just dropping the output for
some of the more debug-like printing.

In particular, this will get rid of the 'mipid_reset' message
you currently get from 'make check'.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: e8945b4f2a65fc2872cc31a5141e136fd27d0af8
      
https://github.com/qemu/qemu/commit/e8945b4f2a65fc2872cc31a5141e136fd27d0af8
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/pl050.c

  Log Message:
  -----------
  pl050: Don't send always-constant is_mouse field

The is_mouse field of the pl050 state structure is constant (it tracks
whether this is a 'pl050_keyboard' or 'pl050_mouse'), so there's
no need to include it in the VMState structure.

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden


  Commit: 28092a23e6e2cb8298c1381f4f046842ffd376eb
      
https://github.com/qemu/qemu/commit/28092a23e6e2cb8298c1381f4f046842ffd376eb
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/arm_mptimer.c

  Log Message:
  -----------
  hw/arm_mptimer: Save the timer state

Add a missing VMSTATE_TIMER() entry to the arm_mptimer vmstate
description; this omission meant that we would probably hang on reload
when the timer failed to fire.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Message-id: address@hidden


  Commit: 8070568b9aa8d93b3729ab7e9ca0ef8a6351d2bd
      
https://github.com/qemu/qemu/commit/8070568b9aa8d93b3729ab7e9ca0ef8a6351d2bd
  Author: Igor Mitsyanko <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M include/migration/vmstate.h

  Log Message:
  -----------
  vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro

Macro could be used to migrate a dynamically allocated buffer of known size.

Signed-off-by: Igor Mitsyanko <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 5f00679ee98b1643ff652bbf982dffe1b432596e
      
https://github.com/qemu/qemu/commit/5f00679ee98b1643ff652bbf982dffe1b432596e
  Author: Igor Mitsyanko <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/sd.c

  Log Message:
  -----------
  hw/sd.c: fix migration of dynamically allocated buffer "buf"

VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not
for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE 
macro,
which will do migration right.

Signed-off-by: Igor Mitsyanko <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Tested-by: Michael Walle <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: b79269b78d0182fa7f4e23b779010145d0b4eaea
      
https://github.com/qemu/qemu/commit/b79269b78d0182fa7f4e23b779010145d0b4eaea
  Author: Igor Mitsyanko <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/onenand.c

  Log Message:
  -----------
  hw/onenand.c: fix migration of dynamically allocated buffer "otp"

VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, not
for buffers allocated dynamically. Change to VMSTATE_BUFFER_POINTER_UNSAFE 
macro,
which will do migration right.

Signed-off-by: Igor Mitsyanko <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: bd7f92e59e7f40ddaeda40e55f7818c8121ecf1a
      
https://github.com/qemu/qemu/commit/bd7f92e59e7f40ddaeda40e55f7818c8121ecf1a
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M include/migration/vmstate.h

  Log Message:
  -----------
  vmstate: Add support for two dimensional arrays

Add support for migrating two dimensional arrays, by defining
a set of new macros VMSTATE_*_2DARRAY paralleling the existing
VMSTATE_*_ARRAY macros. 2D arrays are handled the same for actual
state serialization; the only difference is that the type check
has to change for a 2D array.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Igor Mitsyanko <address@hidden>
Message-id: address@hidden


  Commit: c3037774be5329e584d4d709b9df7e1799bba215
      
https://github.com/qemu/qemu/commit/c3037774be5329e584d4d709b9df7e1799bba215
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/arm_gic_common.c
    M hw/arm_gic_internal.h
    M hw/armv7m_nvic.c

  Log Message:
  -----------
  arm_gic: Fix sizes of state fields in preparation for vmstate support

In preparation for switching to vmstate for migration support, fix
the sizes of various GIC state fields. In particular, we replace all
the bitfields (which VMState can't deal with) with straightforward
uint8_t values which we do bit operations on. (The bitfields made
more sense when NCPU was set differently in different situations,
but we now always model at the architectural limit of 8.)

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Igor Mitsyanko <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: 2e19a7035a8e721f32610c8d22223ab748c4232f
      
https://github.com/qemu/qemu/commit/2e19a7035a8e721f32610c8d22223ab748c4232f
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/arm_gic_common.c

  Log Message:
  -----------
  hw/arm_gic_common: Use vmstate struct rather than save/load functions

Update the GIC save/restore to use vmstate rather than hand-rolled
save/load functions.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Igor Mitsyanko <address@hidden>
Message-id: address@hidden


  Commit: 5d79b80b335c5f65f148d1bb1672d9d534ace73b
      
https://github.com/qemu/qemu/commit/5d79b80b335c5f65f148d1bb1672d9d534ace73b
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/pflash_cfi01.c

  Log Message:
  -----------
  pflash_cfi01: Drop unused 'bypass' field

For pflash_cfi01 the 'bypass' field is set to zero and never changes,
so remove it (it is a leftover from pflash_cfi02, where bypass is
implemented).

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden


  Commit: d8d24fb78cf21205bf672d85231712dc1f0bbb39
      
https://github.com/qemu/qemu/commit/d8d24fb78cf21205bf672d85231712dc1f0bbb39
  Author: Peter Maydell <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/pflash_cfi01.c

  Log Message:
  -----------
  pflash_cfi01: Implement migration support

Add a vmstate to pflash_cfi01, so that it can be live migrated.

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden


  Commit: fd7f8a99f3b08640a7fe2b2f3c3e6b68068b4983
      
https://github.com/qemu/qemu/commit/fd7f8a99f3b08640a7fe2b2f3c3e6b68068b4983
  Author: Peter Crosthwaite <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/pl330.c

  Log Message:
  -----------
  pl330: Don't inhibit ES bits on INTEN

This if-else logic inhibits setting of the event status (ES) bits
when interrupts are enabled. This is incorrect. ES should be set
regardless on INTEN state. INTEN only inhibits the signalling of
events to PL330 threads, not setting of the ES register.

Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 1db8b5efe0c2b5000e50691eea61264a615f43de
      
https://github.com/qemu/qemu/commit/1db8b5efe0c2b5000e50691eea61264a615f43de
  Author: Peter Crosthwaite <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/cadence_uart.c

  Log Message:
  -----------
  cadence_uart: Flush queued characters on reset

Reset can be used to empty the rx-fifo. As the fifo full condition is
used to return false from can_receive, queued rx data should be flushed
on reset accordingly.

Cc: Wendy Liang <address@hidden>
Cc: Jason Wu <address@hidden>

Signed-off-by: Peter Crosthwaite <address@hidden>
Reported-by: Jason Wu <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 32aea752f47f30c00878dcc323ac4debf0c9e645
      
https://github.com/qemu/qemu/commit/32aea752f47f30c00878dcc323ac4debf0c9e645
  Author: Wendy Liang <address@hidden>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M hw/nand.c

  Log Message:
  -----------
  hw/nand.c: Fix nand erase operation

Usually, nand erase operation has only 2 or 3 address cycles.
We need to mask s->addr to zero unset stale high-order bytes in the nand address
before using it as the erase address.

This fixes the NAND erase operation in Linux.

[PC: Generalised to work for any number of address cycles rather than just 3]

Signed-off-by: Wendy Liang <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 9196dd411d580c27f85daa209ff9a501d719ebc0
      
https://github.com/qemu/qemu/commit/9196dd411d580c27f85daa209ff9a501d719ebc0
  Author: Blue Swirl <address@hidden>
  Date:   2013-04-06 (Sat, 06 Apr 2013)

  Changed paths:
    M hw/arm/nseries.c
    M hw/arm_gic_common.c
    M hw/arm_gic_internal.h
    M hw/arm_mptimer.c
    M hw/armv7m_nvic.c
    M hw/cadence_uart.c
    M hw/nand.c
    M hw/onenand.c
    M hw/pflash_cfi01.c
    M hw/pl050.c
    M hw/pl330.c
    M hw/sd.c
    M include/migration/vmstate.h

  Log Message:
  -----------
  Merge branch 'arm-devs.next' of git://git.linaro.org/people/pmaydell/qemu-arm

* 'arm-devs.next' of git://git.linaro.org/people/pmaydell/qemu-arm:
  hw/nand.c: Fix nand erase operation
  cadence_uart: Flush queued characters on reset
  pl330: Don't inhibit ES bits on INTEN
  pflash_cfi01: Implement migration support
  pflash_cfi01: Drop unused 'bypass' field
  hw/arm_gic_common: Use vmstate struct rather than save/load functions
  arm_gic: Fix sizes of state fields in preparation for vmstate support
  vmstate: Add support for two dimensional arrays
  hw/onenand.c: fix migration of dynamically allocated buffer "otp"
  hw/sd.c: fix migration of dynamically allocated buffer "buf"
  vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro
  hw/arm_mptimer: Save the timer state
  pl050: Don't send always-constant is_mouse field
  hw/arm/nseries: don't print to stdout or stderr


Compare: https://github.com/qemu/qemu/compare/893986fe94eb...9196dd411d58
reply via email to
[Prev in Thread] Current Thread [Next in Thread]