[Qemu-commits] [qemu/qemu] 54028d: error: add error_setg_file

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 54028d: error: add error_setg_file_open() hel

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 54028d: error: add error_setg_file_open() helper
Date:	Mon, 17 Jun 2013 12:30:13 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 54028d7542cffe97c4685994baac66988c4b7db9
      
https://github.com/qemu/qemu/commit/54028d7542cffe97c4685994baac66988c4b7db9
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M include/qapi/error.h
    M util/error.c

  Log Message:
  -----------
  error: add error_setg_file_open() helper

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: bc5741add11113ee8febdcf33931ec3afe10c729
      
https://github.com/qemu/qemu/commit/bc5741add11113ee8febdcf33931ec3afe10c729
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M backends/rng-random.c

  Log Message:
  -----------
  rng-random: use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: dacc26aae5d291317a3277970a4f39a562939a78
      
https://github.com/qemu/qemu/commit/dacc26aae5d291317a3277970a4f39a562939a78
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/mirror.c

  Log Message:
  -----------
  block: mirror_complete(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: 0eef407c7b4130d13138c1f75d9975165433f654
      
https://github.com/qemu/qemu/commit/0eef407c7b4130d13138c1f75d9975165433f654
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M blockdev.c

  Log Message:
  -----------
  blockdev: use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: 618da851ec8059460be8e0670bc835d3c2003708
      
https://github.com/qemu/qemu/commit/618da851ec8059460be8e0670bc835d3c2003708
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  cpus: use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: 7581766b719afd63dcf922ddbf982291f596ed12
      
https://github.com/qemu/qemu/commit/7581766b719afd63dcf922ddbf982291f596ed12
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: qmp_dump_guest_memory(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: 1befce9652a1b7cfca0191b3031fae3cbce26ef0
      
https://github.com/qemu/qemu/commit/1befce9652a1b7cfca0191b3031fae3cbce26ef0
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: d8b6895f7a8e5bcc5be1557e8048db43882f3b33
      
https://github.com/qemu/qemu/commit/d8b6895f7a8e5bcc5be1557e8048db43882f3b33
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block.c

  Log Message:
  -----------
  block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

The call to drv->bdrv_reopen_prepare() can fail due to reasons
other than an open failure. Unfortunately, we can't use errno
nor -ret, cause they are not always set.

Stick to a generic error message then.

Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: dbfbc6373441e436ac6e2bcf7a8acb284225aa21
      
https://github.com/qemu/qemu/commit/dbfbc6373441e436ac6e2bcf7a8acb284225aa21
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M include/qapi/qmp/qerror.h

  Log Message:
  -----------
  qerror: drop QERR_OPEN_FILE_FAILED macro

Not used since the last commit.

Signed-off-by: Luiz Capitulino <address@hidden>
Acked-by: Kevin Wolf <address@hidden>


  Commit: b579ffb3fd64243b64ac5aaf659ac88518f17835
      
https://github.com/qemu/qemu/commit/b579ffb3fd64243b64ac5aaf659ac88518f17835
  Author: Liu Yuan <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  sheepdog: fix snapshot tag initialization

This is an old and obvious bug. We should pass snapshot_id to the
tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail

Cc: address@hidden
Cc: MORITA Kazutaka <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Liu Yuan <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: cede621ffc13ba1e209d9a21e85b21e150b74045
      
https://github.com/qemu/qemu/commit/cede621ffc13ba1e209d9a21e85b21e150b74045
  Author: Liu Yuan <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  -----------
  sheepdog: support 'qemu-img snapshot -a'

Just call sd_create_branch() in the snapshot_goto to rollback the image is good
enough. With this patch, 'loadvm' process for sheepdog is modified:

Suppose we have a snapshot chain A --> B --> C, we do 'loadvm A' so as to get
a new chain,

A --> B
|
V
C1

in the old code:

1 reload inode of A (in snapshot_goto)
2 read vmstate via A's vdi_id (loadvm_state)
3 delete C and create C1, reload inode of C1 (sd_create_branch on write)

with this patch applied:

1 reload inode of A, delete C and create C1  (in snapshot_goto)
2 read vmstate via C1's parent, that is A's vdi_id (loadvm_state)

This will fix the possible bug that QEMU exit between 2 and 3 in the old code

Cc: address@hidden
Cc: MORITA Kazutaka <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Signed-off-by: Liu Yuan <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: a7cea2ba47ea6d361584072f96d7858f5cc99009
      
https://github.com/qemu/qemu/commit/a7cea2ba47ea6d361584072f96d7858f5cc99009
  Author: Richard W.M. Jones <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/curl.c

  Log Message:
  -----------
  block/curl.c: Refuse to open the handle for writes.

Signed-off-by: Richard W.M. Jones <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 5a394b9e96eb3c39676353bdf8a230180ae8d6f4
      
https://github.com/qemu/qemu/commit/5a394b9e96eb3c39676353bdf8a230180ae8d6f4
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/vmdk.c

  Log Message:
  -----------
  vmdk: byteswap VMDK4Header.desc_offset field

Remember to byteswap VMDK4Header.desc_offset on big-endian machines.

Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 8da1aa15db2f55c42bdcea95e27b1a190d2be754
      
https://github.com/qemu/qemu/commit/8da1aa15db2f55c42bdcea95e27b1a190d2be754
  Author: Richard W.M. Jones <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/curl.c

  Log Message:
  -----------
  curl: Don't set curl options on the handle just before it's going to be 
deleted.

(Found by Kamil Dudka)

Signed-off-by: Richard W.M. Jones <address@hidden>
Cc: Michael Tokarev <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: f3c507adcd7b00a08f2075afb6012f791ba9aec5
      
https://github.com/qemu/qemu/commit/f3c507adcd7b00a08f2075afb6012f791ba9aec5
  Author: Keith Busch <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M MAINTAINERS
    M default-configs/pci.mak
    M hw/block/Makefile.objs
    A hw/block/nvme.c
    A hw/block/nvme.h
    M include/hw/pci/pci_ids.h

  Log Message:
  -----------
  NVMe: Initial commit for new storage interface

Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci
storage device.

NVMe is an open, industry driven storage specification defining
an optimized register and command set designed to deliver the full
capabilities of non-volatile memory on PCIe SSDs. Further information
may be found on the organizations website at:

http://www.nvmexpress.org/

This commit implements the minimum from the specification to work with
existing drivers.

Cc: Keith Busch <address@hidden>
Signed-off-by: Keith Busch <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 0bed087df24c7b3fae366f239b9d150de3309416
      
https://github.com/qemu/qemu/commit/0bed087df24c7b3fae366f239b9d150de3309416
  Author: Evgeny Budilovsky <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M block/vmdk.c

  Log Message:
  -----------
  vmdk: Allow reading variable size descriptor files

the hard-coded 2k buffer on the stack won't allow reading big descriptor
files which can be generated when storing big images. For example 500G
vmdk splitted to 2G chunks.

Signed-off-by: Evgeny Budilovsky <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>


  Commit: 8a94cfb05ea9a8991c832236b4174d354025a7b7
      
https://github.com/qemu/qemu/commit/8a94cfb05ea9a8991c832236b4174d354025a7b7
  Author: Anton Blanchard <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M tcg/ppc64/tcg-target.c

  Log Message:
  -----------
  tcg-ppc64: Fix RLDCL opcode

The rldcl instruction doesn't have an sh field, so the minor opcode
is shifted 1 bit. We were using the XO30 macro which shifted the
minor opcode 2 bits.

Remove XO30 and add MD30 and MDS30 macros which match the
Power ISA categories.

Cc: address@hidden
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 82e0f9170ac9307de4fc15bfb4d12d5534550322
      
https://github.com/qemu/qemu/commit/82e0f9170ac9307de4fc15bfb4d12d5534550322
  Author: Anton Blanchard <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M tcg/ppc64/tcg-target.c

  Log Message:
  -----------
  tcg-ppc64: bswap64 rotates output 32 bits

If our input and output is in the same register, bswap64 tries to
undo a rotate of the input. This just ends up rotating the output.

Cc: address@hidden
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 84247357104044b8c4ec4a634e84769f432cbe52
      
https://github.com/qemu/qemu/commit/84247357104044b8c4ec4a634e84769f432cbe52
  Author: Anton Blanchard <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M tcg/ppc64/tcg-target.c

  Log Message:
  -----------
  tcg-ppc64: Fix add2_i64

add2_i64 was adding the lower double word to the upper double word
of each input. Fix this so we add the lower double words, then the
upper double words with carry propagation.

Cc: address@hidden
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: d1bdd3af49f227dd4a4b03b90cb020c55cbed440
      
https://github.com/qemu/qemu/commit/d1bdd3af49f227dd4a4b03b90cb020c55cbed440
  Author: Anton Blanchard <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M tcg/ppc64/tcg-target.c

  Log Message:
  -----------
  tcg-ppc64: rotr_i32 rotates wrong amount

rotr_i32 calculates the amount to left shift and puts it into a
temporary, but then doesn't use it when doing the shift.

Cc: address@hidden
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 5d71bbc5fb076e6d8a37bb3e320d61432b3c2ce0
      
https://github.com/qemu/qemu/commit/5d71bbc5fb076e6d8a37bb3e320d61432b3c2ce0
  Author: Anthony Liguori <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M tcg/ppc64/tcg-target.c

  Log Message:
  -----------
  Merge remote-tracking branch 'rth/fix-ppc64' into staging

# By Anton Blanchard
# Via Richard Henderson
* rth/fix-ppc64:
  tcg-ppc64: rotr_i32 rotates wrong amount
  tcg-ppc64: Fix add2_i64
  tcg-ppc64: bswap64 rotates output 32 bits
  tcg-ppc64: Fix RLDCL opcode

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 128dc2d1e4cb98ddbe9c0df2e0c914dc00925dac
      
https://github.com/qemu/qemu/commit/128dc2d1e4cb98ddbe9c0df2e0c914dc00925dac
  Author: Anthony Liguori <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M MAINTAINERS
    M block/curl.c
    M block/sheepdog.c
    M block/vmdk.c
    M default-configs/pci.mak
    M hw/block/Makefile.objs
    A hw/block/nvme.c
    A hw/block/nvme.h
    M include/hw/pci/pci_ids.h

  Log Message:
  -----------
  Merge remote-tracking branch 'kwolf/for-anthony' into staging

# By Liu Yuan (2) and others
# Via Kevin Wolf
* kwolf/for-anthony:
  vmdk: Allow reading variable size descriptor files
  NVMe: Initial commit for new storage interface
  curl: Don't set curl options on the handle just before it's going to be 
deleted.
  vmdk: byteswap VMDK4Header.desc_offset field
  block/curl.c: Refuse to open the handle for writes.
  sheepdog: support 'qemu-img snapshot -a'
  sheepdog: fix snapshot tag initialization

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 21a885a7e2a0f532f7653a2607efddbd83504430
      
https://github.com/qemu/qemu/commit/21a885a7e2a0f532f7653a2607efddbd83504430
  Author: Anthony Liguori <address@hidden>
  Date:   2013-06-17 (Mon, 17 Jun 2013)

  Changed paths:
    M backends/rng-random.c
    M block.c
    M block/mirror.c
    M blockdev.c
    M cpus.c
    M dump.c
    M include/qapi/error.h
    M include/qapi/qmp/qerror.h
    M savevm.c
    M util/error.c

  Log Message:
  -----------
  Merge remote-tracking branch 'luiz/queue/qmp' into staging

# By Luiz Capitulino
# Via Luiz Capitulino
* luiz/queue/qmp:
  qerror: drop QERR_OPEN_FILE_FAILED macro
  block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED
  savevm: qmp_xen_save_devices_state(): use error_setg_file_open()
  dump: qmp_dump_guest_memory(): use error_setg_file_open()
  cpus: use error_setg_file_open()
  blockdev: use error_setg_file_open()
  block: mirror_complete(): use error_setg_file_open()
  rng-random: use error_setg_file_open()
  error: add error_setg_file_open() helper

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/38aea177d935...21a885a7e2a0
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 54028d: error: add error_setg_file_open() helper, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] c14518: Add a stp file for usage from build directory
Next by Date: [Qemu-commits] [qemu/qemu] 37a011: microblaze/petalogix_s3adsp1800_mmu: Fix UART IRQ
Previous by thread: [Qemu-commits] [qemu/qemu] c14518: Add a stp file for usage from build directory
Next by thread: [Qemu-commits] [qemu/qemu] 37a011: microblaze/petalogix_s3adsp1800_mmu: Fix UART IRQ
Index(es):
- Date
- Thread