[Qemu-commits] [qemu/qemu] 6f2b81: avoid a bogus COMPLETED->CANCELLED tr

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 6f2b81: avoid a bogus COMPLETED->CANCELLED tr

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 6f2b81: avoid a bogus COMPLETED->CANCELLED transition
Date:	Mon, 13 Jan 2014 13:30:10 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6f2b811a61810a7fd9f9a5085de223f66b823342
      
https://github.com/qemu/qemu/commit/6f2b811a61810a7fd9f9a5085de223f66b823342
  Author: Zhanghaoyu (A) <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M migration.c

  Log Message:
  -----------
  avoid a bogus COMPLETED->CANCELLED transition

Avoid a bogus COMPLETED->CANCELLED transition.
There is a period of time from the timing of setting COMPLETED state to that of 
migration thread exits, so during which it's problematic in 
COMPLETED->CANCELLED transition.

Signed-off-by: Zeng Junliang <address@hidden>
Signed-off-by: Zhang Haoyu <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 51cf4c1a99a172679c2949a2d58a2a4ee307b557
      
https://github.com/qemu/qemu/commit/51cf4c1a99a172679c2949a2d58a2a4ee307b557
  Author: Zhanghaoyu (A) <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M migration.c

  Log Message:
  -----------
  introduce MIG_STATE_CANCELLING state

Introduce MIG_STATE_CANCELLING state to avoid starting a new migration task 
while the previous one still exist.

Signed-off-by: Zeng Junliang <address@hidden>
Signed-off-by: Zhang Haoyu <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 40596834c0d57a223124a956ccbe39dfeadc9f0e
      
https://github.com/qemu/qemu/commit/40596834c0d57a223124a956ccbe39dfeadc9f0e
  Author: Matthew Garrett <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M migration.c

  Log Message:
  -----------
  migration: Fix rate limit

The migration thread appears to want to allow writeout to occur at full
speed rather than being rate limited during completion of state saving,
but sets the limit to INT_MAX when xfer_limit is INT64_MAX. This causes
problems if there's more than 2GB of state left to save at this point. It
probably ought to just be INT64_MAX instead.

Signed-off-by: Matthew Garrett <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: c961514fd9e707b6a39c60f687a711ffe0a33539
      
https://github.com/qemu/qemu/commit/c961514fd9e707b6a39c60f687a711ffe0a33539
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/migration/qemu-file.h
    M savevm.c

  Log Message:
  -----------
  qemu-file: Make a few functions non-static

The QEMUFile code will be moved to qemu-file.c. This will require making
the following functions non-static because they are used by the savevm.c
code:

 * qemu_peek_byte()
 * qemu_peek_buffer()
 * qemu_file_skip()
 * qemu_file_set_error()

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: b5503338ed1c66310f090cd9164abd244fc82631
      
https://github.com/qemu/qemu/commit/b5503338ed1c66310f090cd9164abd244fc82631
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/migration/migration.h
    M savevm.c

  Log Message:
  -----------
  migration: Move QEMU_VM_* defines to migration/migration.h

The VMState code will be moved to vmstate.c and it uses some of the
QEMU_VM_* constants, so move it to a header.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 5cecf414945e5ba40da893cbdaed554371d4eca9
      
https://github.com/qemu/qemu/commit/5cecf414945e5ba40da893cbdaed554371d4eca9
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm: Convert all tabs to spaces

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 38ff78d363da0d2e0ad27853036b08eaa52ef18d
      
https://github.com/qemu/qemu/commit/38ff78d363da0d2e0ad27853036b08eaa52ef18d
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm.c: Coding style fixes

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 51b7fa5b3cf7678263382039a884aa2e74742bb6
      
https://github.com/qemu/qemu/commit/51b7fa5b3cf7678263382039a884aa2e74742bb6
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm.c: Coding style fix

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: b6fcfa59fa6ad6d61603e701e006d4ec8f4c9d11
      
https://github.com/qemu/qemu/commit/b6fcfa59fa6ad6d61603e701e006d4ec8f4c9d11
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M Makefile.objs
    M savevm.c
    A vmstate.c

  Log Message:
  -----------
  vmstate: Move VMState code to vmstate.c

This will allow unit tests to be written for VMState code without
pulling dependencies from the savevm code.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 093c455a8c6d8f715eabd8c8d346f08f17d686ec
      
https://github.com/qemu/qemu/commit/093c455a8c6d8f715eabd8c8d346f08f17d686ec
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M Makefile.objs
    A qemu-file.c
    M savevm.c

  Log Message:
  -----------
  qemu-file: Move QEMUFile code to qemu-file.c

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: bb1a6d8c57217188f33d8e59d71fc62dbee9e4f8
      
https://github.com/qemu/qemu/commit/bb1a6d8c57217188f33d8e59d71fc62dbee9e4f8
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm: Small comment about why timer QEMUFile/VMState code is in savevm.c

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 2668b4bff484a8428947c10a0efb9758658f4b1a
      
https://github.com/qemu/qemu/commit/2668b4bff484a8428947c10a0efb9758658f4b1a
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M tests/.gitignore
    M tests/Makefile
    A tests/test-vmstate.c

  Log Message:
  -----------
  tests: Some unit tests for vmstate.c

 * Basic load/save tests
 * Tests for loading older versions
 * Tests for .field_exists() handling

Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 9c22687ea8c1a2644a41a683ff0a291adc9a657c
      
https://github.com/qemu/qemu/commit/9c22687ea8c1a2644a41a683ff0a291adc9a657c
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/qemu/bitmap.h
    M include/qemu/bitops.h
    M util/bitmap.c

  Log Message:
  -----------
  bitmap: use long as index

Move index and size fields from int to long.  We need that for
migration.  long is 64 bits on sane architectures, and 32bits should
be enough on all the 32bits architectures.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: e2da99d582300bb8deecb25d26a179ef5b92e066
      
https://github.com/qemu/qemu/commit/e2da99d582300bb8deecb25d26a179ef5b92e066
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: cpu_physical_memory_set_dirty_flags() result is never used

So return void.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 78d0042642a415b56b3c53a6044f30eff47bf69c
      
https://github.com/qemu/qemu/commit/78d0042642a415b56b3c53a6044f30eff47bf69c
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M memory.c

  Log Message:
  -----------
  memory: cpu_physical_memory_set_dirty_range() return void

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 06567942e5e92cc649b608205d5d31ff3ac21c58
      
https://github.com/qemu/qemu/commit/06567942e5e92cc649b608205d5d31ff3ac21c58
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  exec: use accessor function to know if memory is dirty

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: a1390db4df32ad95bf7854944180d2343f7f6368
      
https://github.com/qemu/qemu/commit/a1390db4df32ad95bf7854944180d2343f7f6368
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M cputlb.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: create function to set a single dirty bit

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 7e5609a85e3f35965af5e4c7b1480254642cf2dd
      
https://github.com/qemu/qemu/commit/7e5609a85e3f35965af5e4c7b1480254642cf2dd
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  exec: create function to get a single dirty bit

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 4f08cabe9e6efe8a50abc30cfa59e8470ad434d7
      
https://github.com/qemu/qemu/commit/4f08cabe9e6efe8a50abc30cfa59e8470ad434d7
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: make cpu_physical_memory_is_dirty return bool

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 36187e2ca0295364dcb9a3f256a6fcd77e983c02
      
https://github.com/qemu/qemu/commit/36187e2ca0295364dcb9a3f256a6fcd77e983c02
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: all users of cpu_physical_memory_get_dirty used only one flag

So cpu_physical_memory_get_dirty_flags is not needed anymore

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 63995cebfaa283586682ea6236c9686b2a49ece7
      
https://github.com/qemu/qemu/commit/63995cebfaa283586682ea6236c9686b2a49ece7
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: set single dirty flags when possible

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 75218e7f2b7f052c6f44489afaf45b3ea4369f45
      
https://github.com/qemu/qemu/commit/75218e7f2b7f052c6f44489afaf45b3ea4369f45
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/memory-internal.h
    M memory.c

  Log Message:
  -----------
  memory: cpu_physical_memory_set_dirty_range() always dirty all flags

So remove the flag argument and do it directly.  After this change,
there is nothing else using cpu_physical_memory_set_dirty_flags() so
remove it.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 52159192919469b424b54c167312e53d5a62d233
      
https://github.com/qemu/qemu/commit/52159192919469b424b54c167312e53d5a62d233
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M cputlb.c
    M exec.c
    M include/exec/memory-internal.h
    M include/exec/memory.h
    M memory.c

  Log Message:
  -----------
  memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

Document it

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 5adca7ace9b80bf594e4c52c0d5b23573cba3639
      
https://github.com/qemu/qemu/commit/5adca7ace9b80bf594e4c52c0d5b23573cba3639
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory.h

  Log Message:
  -----------
  memory: use bit 2 for migration

For historical reasons it was bit 3.  Once there, create a constant to
know the number of clients.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 7a5b558c9d061814f34d9b95d70d17ef75037937
      
https://github.com/qemu/qemu/commit/7a5b558c9d061814f34d9b95d70d17ef75037937
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: make sure that client is always inside range

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 2152f5ca782e51a4d05a1f7d9bfa83286323cbc9
      
https://github.com/qemu/qemu/commit/2152f5ca782e51a4d05a1f7d9bfa83286323cbc9
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  memory: only resize dirty bitmap when memory size increases

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: e8a97cafc4108fa964807eb9cbce7eda698f99bb
      
https://github.com/qemu/qemu/commit/e8a97cafc4108fa964807eb9cbce7eda698f99bb
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: cpu_physical_memory_clear_dirty_flag() result is never used

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 164590a60fd685399da259ac41b338d9a0b9d6c0
      
https://github.com/qemu/qemu/commit/164590a60fd685399da259ac41b338d9a0b9d6c0
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/qemu/bitmap.h

  Log Message:
  -----------
  bitmap: Add bitmap_zero_extend operation

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 1ab4c8ceaa5ec55af9bb25e88e46d461a8550280
      
https://github.com/qemu/qemu/commit/1ab4c8ceaa5ec55af9bb25e88e46d461a8550280
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/cpu-all.h
    M include/exec/memory-internal.h
    M include/exec/memory.h

  Log Message:
  -----------
  memory: split dirty bitmap into three

After all the previous patches, spliting the bitmap gets direct.

Note: For some reason, I have to move DIRTY_MEMORY_* definitions to
the beginning of memory.h to make compilation work.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 86a49582dbe66d59a9366d2f002f0d6af965ecb8
      
https://github.com/qemu/qemu/commit/86a49582dbe66d59a9366d2f002f0d6af965ecb8
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 4f13bb80a2dc1bb851b43da6dd9117473772b197
      
https://github.com/qemu/qemu/commit/4f13bb80a2dc1bb851b43da6dd9117473772b197
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: unfold cpu_physical_memory_set_dirty() in its only user

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: c1427a3f84c42d5159d10927700eafc9b653d68f
      
https://github.com/qemu/qemu/commit/c1427a3f84c42d5159d10927700eafc9b653d68f
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: unfold cpu_physical_memory_set_dirty_flag()

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 9f2c43e41a13605d3ab1e37ba433aa669652fb6b
      
https://github.com/qemu/qemu/commit/9f2c43e41a13605d3ab1e37ba433aa669652fb6b
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: make cpu_physical_memory_get_dirty() the main function

And make cpu_physical_memory_get_dirty_flag() to use it.  It used to
be the other way around.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 94833c896d2d339571a66542f2715b1897d70fa7
      
https://github.com/qemu/qemu/commit/94833c896d2d339571a66542f2715b1897d70fa7
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: cpu_physical_memory_get_dirty() is used as returning a bool

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: ace694cccccf343852d9f0b34171ad475e248bbf
      
https://github.com/qemu/qemu/commit/ace694cccccf343852d9f0b34171ad475e248bbf
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

Now all functions use the same wording that bitops/bitmap operations

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 1bafff0c7cb99972fd243464632eca0780c6a8f1
      
https://github.com/qemu/qemu/commit/1bafff0c7cb99972fd243464632eca0780c6a8f1
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: use find_next_bit() to find dirty bits

This operation is way faster than doing it bit by bit.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 5b9a3a5f77e3458af6c1bb0654ee0f32936a5594
      
https://github.com/qemu/qemu/commit/5b9a3a5f77e3458af6c1bb0654ee0f32936a5594
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

We were setting a range of bits, so use bitmap_set().

Note: xen has always been wrong, and should have used start instead
of addr from the beginning.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: a461e389f489e72cdc770ff887512c2c9109bc43
      
https://github.com/qemu/qemu/commit/a461e389f489e72cdc770ff887512c2c9109bc43
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

We were clearing a range of bits, so use bitmap_clear().

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: a2cd8c852d2d8c2a084b68b2470f214d6726f6d2
      
https://github.com/qemu/qemu/commit/a2cd8c852d2d8c2a084b68b2470f214d6726f6d2
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M cputlb.c
    M exec.c
    M include/exec/memory-internal.h

  Log Message:
  -----------
  memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

All uses except one really want the other meaning.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: a2f4d5bef2cfde557d76fc45a40d2c89b6bed4e4
      
https://github.com/qemu/qemu/commit/a2f4d5bef2cfde557d76fc45a40d2c89b6bed4e4
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M cputlb.c
    M exec.c
    M include/exec/memory-internal.h
    M memory.c

  Log Message:
  -----------
  memory: make cpu_physical_memory_reset_dirty() take a length parameter

We have an end parameter in all the callers, and this make it coherent
with the rest of cpu_physical_memory_* functions, that also take a
length parameter.

Once here, move the start/end calculation to
tlb_reset_dirty_range_all() as we don't need it here anymore.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 981fdf2353d5e708adbe5227260d5e46eececc05
      
https://github.com/qemu/qemu/commit/981fdf2353d5e708adbe5227260d5e46eececc05
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  memory: cpu_physical_memory_set_dirty_tracking() should return void

Result was always 0, and not used anywhere.  Once there, use bool type
for the parameter.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 220c3ebddbd1ac289ae7fc64733c9501b3921d94
      
https://github.com/qemu/qemu/commit/220c3ebddbd1ac289ae7fc64733c9501b3921d94
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M cputlb.c
    M exec.c
    M include/exec/memory-internal.h
    A include/exec/ram_addr.h
    M memory.c

  Log Message:
  -----------
  memory: split cpu_physical_memory_* functions to its own include

All the functions that use ram_addr_t should be here.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 12291ec18fdce3c1973c172f5a942a1bd26b9a5f
      
https://github.com/qemu/qemu/commit/12291ec18fdce3c1973c172f5a942a1bd26b9a5f
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M arch_init.c

  Log Message:
  -----------
  memory: unfold memory_region_test_and_clear()

We are going to update the bitmap directly

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 747afd5bcdc90f608c75d95f8a629a9cfc838c57
      
https://github.com/qemu/qemu/commit/747afd5bcdc90f608c75d95f8a629a9cfc838c57
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M kvm-all.c

  Log Message:
  -----------
  kvm: use directly cpu_physical_memory_* api for tracking dirty pages

Performance is important in this function, and we want to optimize even further.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: c9dd46fc0d64d9f314aa3c220d4aff9d01ab778e
      
https://github.com/qemu/qemu/commit/c9dd46fc0d64d9f314aa3c220d4aff9d01ab778e
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M kvm-all.c

  Log Message:
  -----------
  kvm: refactor start address calculation

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 5ff7fb77b3cee8e26648e4fdccb23a77c2a6d3c6
      
https://github.com/qemu/qemu/commit/5ff7fb77b3cee8e26648e4fdccb23a77c2a6d3c6
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/ram_addr.h
    M kvm-all.c

  Log Message:
  -----------
  memory: move bitmap synchronization to its own function

We want to have all the functions that handle directly the dirty
bitmap near.  We will change it later.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: ae2810c4bb3b383176e8e1b33931b16c01483aab
      
https://github.com/qemu/qemu/commit/ae2810c4bb3b383176e8e1b33931b16c01483aab
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M include/exec/ram_addr.h

  Log Message:
  -----------
  memory: syncronize kvm bitmap using bitmaps operations

If bitmaps are aligned properly, use bitmap operations.  If they are
not, just use old bit at a time code.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: 791fa2a2451799232d6bc0c29c0fbb13b5293eeb
      
https://github.com/qemu/qemu/commit/791fa2a2451799232d6bc0c29c0fbb13b5293eeb
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M arch_init.c

  Log Message:
  -----------
  ram: split function that synchronizes a range

This function is the only bit where we care about speed.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: aa8dc044772ba156cbcf2174b5673cfa11f566a7
      
https://github.com/qemu/qemu/commit/aa8dc044772ba156cbcf2174b5673cfa11f566a7
  Author: Juan Quintela <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M arch_init.c

  Log Message:
  -----------
  migration: synchronize memory bitmap 64bits at a time

We use the old code if the bitmaps are not aligned

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>


  Commit: b54f18ba3415c731f0b069f6df56f529997fb74e
      
https://github.com/qemu/qemu/commit/b54f18ba3415c731f0b069f6df56f529997fb74e
  Author: Anthony Liguori <address@hidden>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M Makefile.objs
    M arch_init.c
    M cputlb.c
    M exec.c
    M include/exec/cpu-all.h
    M include/exec/memory-internal.h
    M include/exec/memory.h
    A include/exec/ram_addr.h
    M include/migration/migration.h
    M include/migration/qemu-file.h
    M include/qemu/bitmap.h
    M include/qemu/bitops.h
    M kvm-all.c
    M memory.c
    M migration.c
    A qemu-file.c
    M savevm.c
    M tests/.gitignore
    M tests/Makefile
    A tests/test-vmstate.c
    M util/bitmap.c
    A vmstate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'quintela/tags/migration/20140113' into staging

migration.next for 20140113

# gpg: Signature made Mon 13 Jan 2014 09:38:27 AM PST using RSA key ID 5872D723
# gpg: Can't check signature: public key not found

* quintela/tags/migration/20140113: (49 commits)
  migration: synchronize memory bitmap 64bits at a time
  ram: split function that synchronizes a range
  memory: syncronize kvm bitmap using bitmaps operations
  memory: move bitmap synchronization to its own function
  kvm: refactor start address calculation
  kvm: use directly cpu_physical_memory_* api for tracking dirty pages
  memory: unfold memory_region_test_and_clear()
  memory: split cpu_physical_memory_* functions to its own include
  memory: cpu_physical_memory_set_dirty_tracking() should return void
  memory: make cpu_physical_memory_reset_dirty() take a length parameter
  memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()
  memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations
  memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations
  memory: use find_next_bit() to find dirty bits
  memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range
  memory: cpu_physical_memory_get_dirty() is used as returning a bool
  memory: make cpu_physical_memory_get_dirty() the main function
  memory: unfold cpu_physical_memory_set_dirty_flag()
  memory: unfold cpu_physical_memory_set_dirty() in its only user
  memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user
  ...

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/dd089c0a1e92...b54f18ba3415
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 6f2b81: avoid a bogus COMPLETED->CANCELLED transition, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 5cd8a1: arm: fix compile on bigendian host
Next by Date: [Qemu-commits] [qemu/qemu] 83e681: target-arm: Switch ARMCPUInfo arrays to use termin...
Previous by thread: [Qemu-commits] [qemu/qemu] 5cd8a1: arm: fix compile on bigendian host
Next by thread: [Qemu-commits] [qemu/qemu] 83e681: target-arm: Switch ARMCPUInfo arrays to use termin...
Index(es):
- Date
- Thread