[Qemu-commits] [qemu/qemu] d32934: error: Don't use error_report() for assertion msgs...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d32934c84c72f57e78d430c22974677b7bcabe5d
      
https://github.com/qemu/qemu/commit/d32934c84c72f57e78d430c22974677b7bcabe5d
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-01-14 (Tue, 14 Jan 2014)

  Changed paths:
    M util/error.c

  Log Message:
  -----------
  error: Don't use error_report() for assertion msgs.

Use fprintf(stderr instead. This removes dependency of libqemuutil.a
on the monitor.

We can further justify this change, in that this code path should only
trigger under a fatal error condition. fprintf-stderr is probably the
appropriate medium as under a fatal error conidition the monitor itself
may be down and out for the count. So assertion failure messages should
go lowest common denominator - straight to stderr.

Fixes the build as reported by Kevin Wolf. Issue debugged and change
suggested by Luiz Capitulino. Issue introduced by
5d24ee70bcbcf578614193526bcd5ed30a8eb16c.

Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>


  Commit: 1cf892ca2689c84960b4ce4d2723b6bee453711c
      
https://github.com/qemu/qemu/commit/1cf892ca2689c84960b4ce4d2723b6bee453711c
  Author: Sebastian Huber <address@hidden>
  Date:   2014-01-14 (Tue, 14 Jan 2014)

  Changed paths:
    M target-sparc/translate.c

  Log Message:
  -----------
  SPARC: Fix LEON3 power down instruction

Synchronize the program counter before the power down helper call
otherwise interrupts will return to the wrong context.

Signed-off-by: Sebastian Huber <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Signed-off-by: Edgar E. Iglesias <address@hidden>


Compare: https://github.com/qemu/qemu/compare/133fe77437d3...1cf892ca2689