qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 58b590: pci: Fix clearing IRQs on reset


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 58b590: pci: Fix clearing IRQs on reset
Date: Mon, 31 Mar 2014 12:30:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 58b590148ca1b19f64f533d40e32b5acce5c21e7
      
https://github.com/qemu/qemu/commit/58b590148ca1b19f64f533d40e32b5acce5c21e7
  Author: Cole Robinson <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M hw/pci/pci.c

  Log Message:
  -----------
  pci: Fix clearing IRQs on reset

irq_state is cleared before calling pci_device_deassert_intx, but the
latter misbehaves if the former isn't accurate. In this case, any raised
IRQs are not cleared, which hits an assertion in pcibus_reset:

qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion
`bus->irq_count[i] == 0' failed.

pci_device_deassert_intx should clear irq_state anyways, so add
an assert.

This fixes migration with usb2 + usb-tablet.

Signed-off-by: Cole Robinson <address@hidden>
Message-id: address@hidden
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]