[Qemu-commits] [qemu/qemu] 713e8a: virtio-rng: Add human-readable error message for n...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 713e8a102222b6b8ca65050d13b287f5705831b0
      
https://github.com/qemu/qemu/commit/713e8a102222b6b8ca65050d13b287f5705831b0
  Author: John Snow <address@hidden>
  Date:   2014-07-22 (Tue, 22 Jul 2014)

  Changed paths:
    M hw/virtio/virtio-rng.c

  Log Message:
  -----------
  virtio-rng: Add human-readable error message for negative max-bytes parameter

If a negative integer is used for the max_bytes parameter, QEMU currently
calls abort() and leaves behind a core dump. This patch replaces the
abort with a simple error message to make the reason for the termination
clearer. This also ensures device-hotplug with invalid input doesn't
cause qemu to quit.

There is an underlying insufficiency in the parameter parsing code of QEMU
that renders it unable to reject negative values for unsigned properties,
thus the error message "a non-negative integer below 2^63" is the most
user-friendly and correct message we can give until the underlying
insufficiency is corrected.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: b64c670f1ddcd02d003e701f69cf573d7c559ecb
      
https://github.com/qemu/qemu/commit/b64c670f1ddcd02d003e701f69cf573d7c559ecb
  Author: Peter Maydell <address@hidden>
  Date:   2014-07-22 (Tue, 22 Jul 2014)

  Changed paths:
    M hw/virtio/virtio-rng.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/amit-virtio-rng/for-2.1' into staging

* remotes/amit-virtio-rng/for-2.1:
  virtio-rng: Add human-readable error message for negative max-bytes parameter

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/25af8e6b6106...b64c670f1ddc