qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 675800: Revert "vfio: Make BARs native endian


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 675800: Revert "vfio: Make BARs native endian"
Date: Wed, 24 Sep 2014 05:00:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6758008e2c4e79fb6bd04fe8e7a41665fa583965
      
https://github.com/qemu/qemu/commit/6758008e2c4e79fb6bd04fe8e7a41665fa583965
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2014-09-22 (Mon, 22 Sep 2014)

  Changed paths:
    M hw/misc/vfio.c

  Log Message:
  -----------
  Revert "vfio: Make BARs native endian"

This reverts commit c40708176a6b52b73bec14796b7c71b882ceb102.

The resulting code wrongly assumed target and host endianness are
the same which is not always the case for PPC64.

[aw: or potentially any host supporting VFIO and TCG]

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 75bd0c7253f384e868b638db5c6350796cf584f7
      
https://github.com/qemu/qemu/commit/75bd0c7253f384e868b638db5c6350796cf584f7
  Author: Nikunj A Dadhania <address@hidden>
  Date:   2014-09-22 (Mon, 22 Sep 2014)

  Changed paths:
    M hw/misc/vfio.c

  Log Message:
  -----------
  vfio: make rom read endian sensitive

All memory regions used by VFIO are LITTLE_ENDIAN and they
already take care of endiannes when accessing real device BARs
except ROM - it was broken on BE hosts.

This fixes endiannes for ROM BARs the same way as it is done
for other BARs.

This has been tested on PPC64 BE/LE host/guest in all possible
combinations including TCG.

Signed-off-by: Nikunj A Dadhania <address@hidden>
[aik: added commit log]
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: ca976d1803a16e8f9d4a657634823a8c5b9d661a
      
https://github.com/qemu/qemu/commit/ca976d1803a16e8f9d4a657634823a8c5b9d661a
  Author: Peter Maydell <address@hidden>
  Date:   2014-09-24 (Wed, 24 Sep 2014)

  Changed paths:
    M hw/misc/vfio.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/awilliam/tags/vfio-pci-for-qemu-20140923.0' into staging

Endian updates to re-fix cross endian host and guest and
enable the same for ROM loading (Alexey)

# gpg: Signature made Tue 23 Sep 2014 18:03:03 BST using RSA key ID 3BB08B22
# gpg: Can't check signature: public key not found

* remotes/awilliam/tags/vfio-pci-for-qemu-20140923.0:
  vfio: make rom read endian sensitive
  Revert "vfio: Make BARs native endian"

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/01f7cecf0037...ca976d1803a1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]