[Qemu-commits] [qemu/qemu] 1b3e71: target-xtensa: add missing window check for entry

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1b3e71f8ee17ced609213d9b41758110f3c026e9
      
https://github.com/qemu/qemu/commit/1b3e71f8ee17ced609213d9b41758110f3c026e9
  Author: Max Filippov <address@hidden>
  Date:   2014-11-10 (Mon, 10 Nov 2014)

  Changed paths:
    M target-xtensa/cpu.h
    M target-xtensa/op_helper.c

  Log Message:
  -----------
  target-xtensa: add missing window check for entry

Entry opcode needs to check if moving to new register frame would cause
register window overflow. Entry used in function prologue never
overflows because preceding windowed call* opcode writes return address
to the target register window frame, causing overflow exceptions at the
point of call. But when a sequence of entry opcodes is used for register
window spilling there may not be a call or other opcode that would cause
window check between entries and they would not raise overflow exception
themselves resulting in data corruption.

Cc: address@hidden
Signed-off-by: Max Filippov <address@hidden>


  Commit: 09c7fbef766b43f6edb46b30546bd1b32ee12921
      
https://github.com/qemu/qemu/commit/09c7fbef766b43f6edb46b30546bd1b32ee12921
  Author: Max Filippov <address@hidden>
  Date:   2014-11-10 (Mon, 10 Nov 2014)

  Changed paths:
    M tests/tcg/xtensa/test_windowed.S

  Log Message:
  -----------
  target-xtensa: add entry overflow test

Check that entry instruction raises window overflow exception when
PS.CALLINC points to live registers.

Signed-off-by: Max Filippov <address@hidden>


  Commit: 9df98352b700bdf31ee18cd956393a07f427d829
      
https://github.com/qemu/qemu/commit/9df98352b700bdf31ee18cd956393a07f427d829
  Author: Peter Maydell <address@hidden>
  Date:   2014-11-10 (Mon, 10 Nov 2014)

  Changed paths:
    M target-xtensa/cpu.h
    M target-xtensa/op_helper.c
    M tests/tcg/xtensa/test_windowed.S

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/xtensa/tags/20141110-xtensa' into 
staging

Xtensa fixes for 2.2:
- fix entry opcode register window checking and add unit test.

# gpg: Signature made Mon 10 Nov 2014 15:01:47 GMT using RSA key ID F83FA044
# gpg: Good signature from "Max Filippov <address@hidden>"
# gpg:                 aka "Max Filippov <address@hidden>"

* remotes/xtensa/tags/20141110-xtensa:
  target-xtensa: add entry overflow test
  target-xtensa: add missing window check for entry

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/558c2c8ddfb1...9df98352b700