qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 49f817: fsdev-proxy-helper: avoid TOC/TOU rac


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 49f817: fsdev-proxy-helper: avoid TOC/TOU race
Date: Tue, 01 Dec 2015 08:30:05 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 49f817caaf4460f4a8dfca190f31a57569fc9efe
      
https://github.com/qemu/qemu/commit/49f817caaf4460f4a8dfca190f31a57569fc9efe
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-30 (Mon, 30 Nov 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c

  Log Message:
  -----------
  fsdev-proxy-helper: avoid TOC/TOU race

There is a minor time of check/time of use race between statfs and chroot.
It can be fixed easily by stat-ing the root after it has been changed.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>


  Commit: ebac1202c95a4f1b76b6ef3f0f63926fa76e753e
      
https://github.com/qemu/qemu/commit/ebac1202c95a4f1b76b6ef3f0f63926fa76e753e
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-11-30 (Mon, 30 Nov 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-coth.c
    M hw/9pfs/virtio-9p-coth.h
    M hw/9pfs/virtio-9p-device.c

  Log Message:
  -----------
  virtio-9p: use QEMU thread pool

The QEMU thread pool already has a mechanism to invoke callbacks in the main
thread.  It does not need an EventNotifier and it is more efficient too.
Use it instead of GAsyncQueue + GThreadPool + glue.

As a side effect, it silences Coverity's complaint about an unchecked
return value for event_notifier_init.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
(removed no more needed #include <glib.h> from virtio-9p-coth.h)
Signed-off-by: Greg Kurz <address@hidden>


  Commit: d90eb45902413540005d2196500270eb903f488a
      
https://github.com/qemu/qemu/commit/d90eb45902413540005d2196500270eb903f488a
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-30 (Mon, 30 Nov 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c
    M hw/9pfs/virtio-9p-coth.c
    M hw/9pfs/virtio-9p-coth.h
    M hw/9pfs/virtio-9p-device.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging

Two fixes for virtfs/9p from Paolo.

# gpg: Signature made Mon 30 Nov 2015 14:10:47 GMT using DSA key ID 0101DBC2
# gpg: Good signature from "Greg Kurz <address@hidden>"
# gpg:                 aka "Greg Kurz <address@hidden>"
# gpg:                 aka "Greg Kurz <address@hidden>"
# gpg:                 aka "Gregory Kurz (Groug) <address@hidden>"
# gpg:                 aka "Gregory Kurz (Cimai Technology) <address@hidden>"
# gpg:                 aka "Gregory Kurz (Meiosys Technology) <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 2BD4 3B44 535E C0A7 9894  DBA2 02FC 3AEB 0101 DBC2

* remotes/gkurz/tags/for-upstream:
  virtio-9p: use QEMU thread pool
  fsdev-proxy-helper: avoid TOC/TOU race

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a2485925f76d...d90eb4590241

reply via email to

[Prev in Thread] Current Thread [Next in Thread]