[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 18f498: configure: Fix shell syntax to placat
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 18f498: configure: Fix shell syntax to placate OpenBSD's p... |
Date: |
Fri, 18 Dec 2015 06:00:06 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 18f49881cf8359e89396aac12f5d3cf3f8a632ba
https://github.com/qemu/qemu/commit/18f49881cf8359e89396aac12f5d3cf3f8a632ba
Author: Peter Maydell <address@hidden>
Date: 2015-12-18 (Fri, 18 Dec 2015)
Changed paths:
M configure
Log Message:
-----------
configure: Fix shell syntax to placate OpenBSD's pdksh
Unfortunately the OpenBSD pdksh does not like brackets inside
the right part of a ${variable+word} parameter expansion:
$ echo "${a+($b)}"
ksh: ${a+($b)}": bad substitution
though both bash and dash accept them. In any case this line
was causing odd output in the case where nettle is not present:
nettle no ()
(because if nettle is not present then $nettle will be "no",
not a null string or unset).
Rewrite it to just use an if.
This bug was originally introduced in becaeb726 and was present
in the 2.4.0 release.
Fixes: https://bugs.launchpad.net/qemu/+bug/1525682
Reported-by: Dmitrij D. Czarkoff
Cc: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 18f498: configure: Fix shell syntax to placate OpenBSD's p...,
GitHub <=