[Qemu-commits] [qemu/qemu] 750cf8: MAINTAINERS: Add an entry for the include/sysemu/r...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 750cf86932cd16bd881bba372738c1c6f17fc189
      
https://github.com/qemu/qemu/commit/750cf86932cd16bd881bba372738c1c6f17fc189
  Author: Thomas Huth <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add an entry for the include/sysemu/rng*.h files

These headers are used by the virtio-rng and rng backends code,
so they should be listed in the same section in MAINTAINERS, too.

Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 3c52ddcdc548e7fbe65112d8a7bdc9cd105b4750
      
https://github.com/qemu/qemu/commit/3c52ddcdc548e7fbe65112d8a7bdc9cd105b4750
  Author: Ladi Prosek <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M backends/rng-egd.c
    M backends/rng.c
    M include/sysemu/rng.h

  Log Message:
  -----------
  rng: remove the unused request cancellation code

rng_backend_cancel_requests had no callers and none of the code
deleted in this commit ever ran.

Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 74074e8a7c60592cf1cc6469dbc2550d24aeded3
      
https://github.com/qemu/qemu/commit/74074e8a7c60592cf1cc6469dbc2550d24aeded3
  Author: Ladi Prosek <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M backends/rng-egd.c
    M include/sysemu/rng.h

  Log Message:
  -----------
  rng: move request queue from RngEgd to RngBackend

The 'requests' field now lives in the RngBackend parent class.
There are no functional changes in this commit.

Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 9f14b0add1dcdbfa2ee61051d068211fb0a1fcc9
      
https://github.com/qemu/qemu/commit/9f14b0add1dcdbfa2ee61051d068211fb0a1fcc9
  Author: Ladi Prosek <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M backends/rng-egd.c
    M backends/rng.c
    M include/sysemu/rng.h

  Log Message:
  -----------
  rng: move request queue cleanup from RngEgd to RngBackend

RngBackend is now in charge of cleaning up the linked list on
instance finalization. It also exposes a function to finalize
individual RngRequest instances, called by its child classes.

Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 60253ed1e6ec6d8e5ef2efe7bf755f475dce9956
      
https://github.com/qemu/qemu/commit/60253ed1e6ec6d8e5ef2efe7bf755f475dce9956
  Author: Ladi Prosek <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M backends/rng-egd.c
    M backends/rng-random.c
    M backends/rng.c
    M include/sysemu/rng.h

  Log Message:
  -----------
  rng: add request queue support to rng-random

Requests are now created in the RngBackend parent class and the
code path is shared by both rng-egd and rng-random.

This commit fixes the rng-random implementation which processed
only one request at a time and simply discarded all but the most
recent one. In the guest this manifested as delayed completion
of reads from virtio-rng, i.e. a read was completed only after
another read was issued.

By switching rng-random to use the same request queue as rng-egd,
the unsafe stack-based allocation of the entropy buffer is
eliminated and replaced with g_malloc.

Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: f8693c2cd06d0401007b2c168126ab907f6da345
      
https://github.com/qemu/qemu/commit/f8693c2cd06d0401007b2c168126ab907f6da345
  Author: Ladi Prosek <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M hw/virtio/virtio-rng.c

  Log Message:
  -----------
  virtio-rng: ask for more data if queue is not fully drained

This commit effectively reverts:

  commit 4621c1768ef5d12171cca2aa1473595ecb9f1c9e
  Author: Amit Shah <address@hidden>
  Date:   Wed Nov 21 11:21:19 2012 +0530

  virtio-rng: remove extra request for entropy

but instead of calling virtio_rng_process unconditionally, it
first checks to see if the queue is empty as a little bit of
optimization.

Signed-off-by: Ladi Prosek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 2d3b7c0164e1b9287304bc70dd6ed071ba3e8dfc
      
https://github.com/qemu/qemu/commit/2d3b7c0164e1b9287304bc70dd6ed071ba3e8dfc
  Author: Peter Maydell <address@hidden>
  Date:   2016-03-03 (Thu, 03 Mar 2016)

  Changed paths:
    M MAINTAINERS
    M backends/rng-egd.c
    M backends/rng-random.c
    M backends/rng.c
    M hw/virtio/virtio-rng.c
    M include/sysemu/rng.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/amit-virtio-rng/tags/rng-for-2.6-1' 
into staging

rng:
- implement a request queue for rng-random so multiple guest requests
  don't result in vq buffers getting forgotten
- remove unused request cancellation code
- a VM with multiple vq buffers, when migrated, could get in a situation
  where not all buffers are handed back to the guest.  This is now
  fixed.

# gpg: Signature made Thu 03 Mar 2016 12:18:54 GMT using RSA key ID 854083B6
# gpg: Good signature from "Amit Shah <address@hidden>"
# gpg:                 aka "Amit Shah <address@hidden>"
# gpg:                 aka "Amit Shah <address@hidden>"

* remotes/amit-virtio-rng/tags/rng-for-2.6-1:
  virtio-rng: ask for more data if queue is not fully drained
  rng: add request queue support to rng-random
  rng: move request queue cleanup from RngEgd to RngBackend
  rng: move request queue from RngEgd to RngBackend
  rng: remove the unused request cancellation code
  MAINTAINERS: Add an entry for the include/sysemu/rng*.h files

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ed6128ebbdd7...2d3b7c0164e1