qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c586ea: log: do not log if QEMU is daemonized


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c586ea: log: do not log if QEMU is daemonized but without ...
Date: Mon, 07 Mar 2016 22:00:08 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c586eac33670c198c6c9ceb1419aa99dafcce907
      
https://github.com/qemu/qemu/commit/c586eac33670c198c6c9ceb1419aa99dafcce907
  Author: Paolo Bonzini <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M util/log.c

  Log Message:
  -----------
  log: do not log if QEMU is daemonized but without -D

Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized",
2016-02-22) wanted to move stderr of a daemonized QEMU to the file
specified with -D.

However, if -D was not passed, the patch had the side effect of not
redirecting stderr to /dev/null.  This happened because qemu_logfile
was set to stderr rather than the expected value of NULL.  The fix
is simply in the "if" condition of do_qemu_set_log; the "if" for
closing the file is also changed to match.

Reported-by: Jan Tomko <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: bb8f32c0318cb6c6e13e09ec0f35e21eff246413
      
https://github.com/qemu/qemu/commit/bb8f32c0318cb6c6e13e09ec0f35e21eff246413
  Author: Hervé Poussineau <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M hw/dma/i8257.c

  Log Message:
  -----------
  i8257: fix Terminal Count status

When a DMA transfer is done (ie all bytes have been transfered), the 
corresponding
Terminal Count bit must be set in the status register.
This bit is already cleared in i8257_read_cont and i8257_write_cont when 
required.

This fixes (at least) floppy transfer in IBM 40p firmware, which checks in DMA
controller if everything went fine.

Signed-off-by: Hervé Poussineau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 528f46af6ecd1e300db18684969104d4067b867b
      
https://github.com/qemu/qemu/commit/528f46af6ecd1e300db18684969104d4067b867b
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M exec.c
    M include/exec/ram_addr.h
    M memory.c

  Log Message:
  -----------
  exec: Return RAMBlock pointer from allocating functions

Previously we return RAMBlock.offset; now return the pointer to the
whole structure.

ram_block_add returns void now, error is completely passed with errp.

Reviewed-by: Gonglei <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 0a75601853c00f3729fa62c49ec0d4bb1e3d9bc1
      
https://github.com/qemu/qemu/commit/0a75601853c00f3729fa62c49ec0d4bb1e3d9bc1
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M exec.c
    M memory.c

  Log Message:
  -----------
  memory: Move assignment to ram_block to memory_region_init_*

We don't force "const" qualifiers with pointers in QEMU, but it's still
good to keep a clean function interface. Assigning to mr->ram_block is
in this sense ugly - one initializer mutating its owning object's state.

Move it to memory_region_init_*, where mr->ram_addr is assigned.

Reviewed-by: Gonglei <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 7ebb2745acbb8d910eab07dc5f0aa01a4457703c
      
https://github.com/qemu/qemu/commit/7ebb2745acbb8d910eab07dc5f0aa01a4457703c
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M include/exec/memory.h
    M memory.c

  Log Message:
  -----------
  memory: Implement memory_region_get_ram_addr with mr->ram_block

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8e41fb63c5bf29ecabe0cee1239bf6230f19978a
      
https://github.com/qemu/qemu/commit/8e41fb63c5bf29ecabe0cee1239bf6230f19978a
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M cputlb.c
    M exec.c
    M hw/misc/ivshmem.c
    M include/exec/memory.h
    M kvm-all.c
    M memory.c
    M scripts/dump-guest-memory.py

  Log Message:
  -----------
  memory: Drop MemoryRegion.ram_addr

All references to mr->ram_addr are replaced by
memory_region_get_ram_addr(mr) (except for a few assertions that are
replaced with mr->ram_block).

Reviewed-by: Gonglei <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Acked-by: Laszlo Ersek <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f1060c55bf1377b499affc8d022378d936f0bd99
      
https://github.com/qemu/qemu/commit/f1060c55bf1377b499affc8d022378d936f0bd99
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M exec.c
    M include/exec/ram_addr.h
    M memory.c

  Log Message:
  -----------
  exec: Pass RAMBlock pointer to qemu_ram_free

The only caller now knows exactly which RAMBlock to free, so it's not
necessary to do the lookup.

Reviewed-by: Gonglei <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 29cb533d8cbff1330717619780c2f1dfe764e003
      
https://github.com/qemu/qemu/commit/29cb533d8cbff1330717619780c2f1dfe764e003
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  exec: Factor out section_covers_addr

This will be shared by the next patch.

Also add a comment explaining the unobvious condition on "size.hi".

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
[Small change to the comment. - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 729633c2bc30496073431584eb6e304776b4ebd4
      
https://github.com/qemu/qemu/commit/729633c2bc30496073431584eb6e304776b4ebd4
  Author: Fam Zheng <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  exec: Introduce AddressSpaceDispatch.mru_section

Under heavy workloads the lookup will likely end up with the same
MemoryRegionSection from last time. Using a pointer to cache the result,
like ram_list.mru_block, significantly reduces cost of
address_space_translate.

During address space topology update, as->dispatch will be reallocated
so the pointer is invalidated automatically.

Perf reports a visible drop on the cpu usage, because phys_page_find is
not called.  Before:

   2.35%  qemu-system-x86_64       [.] phys_page_find
   0.97%  qemu-system-x86_64       [.] address_space_translate_internal
   0.95%  qemu-system-x86_64       [.] address_space_translate
   0.55%  qemu-system-x86_64       [.] address_space_lookup_region

After:

   0.97%  qemu-system-x86_64       [.] address_space_translate_internal
   0.97%  qemu-system-x86_64       [.] address_space_lookup_region
   0.84%  qemu-system-x86_64       [.] address_space_translate

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 778d9f9b25dc563252fa6187e23fe6e7d16b5a99
      
https://github.com/qemu/qemu/commit/778d9f9b25dc563252fa6187e23fe6e7d16b5a99
  Author: Pranith Kumar <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M cpus.c
    M qemu-options.hx

  Log Message:
  -----------
  icount: possible options for sleep are on or off

icount sleep takes on or off as options. A few places mention sleep=no
which is not accepted. This patch corrects them.

Signed-off-by: Pranith Kumar <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8210f5f6f52159b0d3a27ffe4af97056ac44cba8
      
https://github.com/qemu/qemu/commit/8210f5f6f52159b0d3a27ffe4af97056ac44cba8
  Author: xiaoqiang zhao <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M docs/memory.txt

  Log Message:
  -----------
  doc/memory.txt: correct a logic error

In the regions overlap example, region B has a higher priority thus
should has a larger priority number than C.

Signed-off-by: xiaoqiang zhao <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: ef00bdaf8c843be61737178707d8eaee6541733b
      
https://github.com/qemu/qemu/commit/ef00bdaf8c843be61737178707d8eaee6541733b
  Author: Peter Maydell <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M docs/memory.txt

  Log Message:
  -----------
  doc/memory.txt: correct description of MemoryRegionOps fields

Probably what happened was that when the API was being designed it
started off with an 'aligned' field, and then later the field name
and semantics were changed but the docs weren't updated to match.

Similarly, cpu_register_io_memory() does not exist anymore, so
clarify the documentation for .old_mmio.

Reported-by: Cao jin <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: a95e9a485b0230255aec1c9b53f2bd4612febdce
      
https://github.com/qemu/qemu/commit/a95e9a485b0230255aec1c9b53f2bd4612febdce
  Author: Thomas Huth <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add entry for include/sysemu/kvm*.h

The include/sysemu/kvm*.h header files should be part of
the overall KVM section.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8269fb7082f49b5facddbbe1072bc382b2741add
      
https://github.com/qemu/qemu/commit/8269fb7082f49b5facddbbe1072bc382b2741add
  Author: Wei Yang <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M kvm-all.c

  Log Message:
  -----------
  kvm/irqchip: use bitmap utility for gsi tracking

By using utilities in bitops and bitmap, this patch tries to make it more
friendly to audience. No functional change.

Signed-off-by: Wei Yang <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 4792b7e9d5254daa383cb38d60d79c2b000ca9fc
      
https://github.com/qemu/qemu/commit/4792b7e9d5254daa383cb38d60d79c2b000ca9fc
  Author: Alex Pyrgiotis <address@hidden>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M hw/scsi/scsi-bus.c

  Log Message:
  -----------
  scsi-bus: Remove tape command from scsi_req_xfer

Remove the RECOVER_BUFFERED_DATA command from the list of commands that
are handled by scsi_req_xfer(). Given that this command is
tape-specific, it should be handled only by scsi_stream_req_xfer().

Signed-off-by: Alex Pyrgiotis <address@hidden>

Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 97556fe80e4f7252300b3498b3477fb4295153a3
      
https://github.com/qemu/qemu/commit/97556fe80e4f7252300b3498b3477fb4295153a3
  Author: Peter Maydell <address@hidden>
  Date:   2016-03-08 (Tue, 08 Mar 2016)

  Changed paths:
    M MAINTAINERS
    M cpus.c
    M cputlb.c
    M docs/memory.txt
    M exec.c
    M hw/dma/i8257.c
    M hw/misc/ivshmem.c
    M hw/scsi/scsi-bus.c
    M include/exec/memory.h
    M include/exec/ram_addr.h
    M kvm-all.c
    M memory.c
    M qemu-options.hx
    M scripts/dump-guest-memory.py
    M util/log.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

* RAMBlock vs. MemoryRegion cleanups from Fam
* mru_section optimization from Fam
* memory.txt improvements from Peter and Xiaoqiang
* i8257 fix from Hervé
* -daemonize fix
* Cleanups and small fixes from Alex, Praneith, Wei

# gpg: Signature made Mon 07 Mar 2016 17:08:59 GMT using RSA key ID 78C7AE83
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"

* remotes/bonzini/tags/for-upstream:
  scsi-bus: Remove tape command from scsi_req_xfer
  kvm/irqchip: use bitmap utility for gsi tracking
  MAINTAINERS: Add entry for include/sysemu/kvm*.h
  doc/memory.txt: correct description of MemoryRegionOps fields
  doc/memory.txt: correct a logic error
  icount: possible options for sleep are on or off
  exec: Introduce AddressSpaceDispatch.mru_section
  exec: Factor out section_covers_addr
  exec: Pass RAMBlock pointer to qemu_ram_free
  memory: Drop MemoryRegion.ram_addr
  memory: Implement memory_region_get_ram_addr with mr->ram_block
  memory: Move assignment to ram_block to memory_region_init_*
  exec: Return RAMBlock pointer from allocating functions
  i8257: fix Terminal Count status
  log: do not log if QEMU is daemonized but without -D

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1464ad45cd6c...97556fe80e4f

reply via email to

[Prev in Thread] Current Thread [Next in Thread]