[Qemu-commits] [qemu/qemu] 5d443f: tests: add /vhost-user/connect-fail t

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 5d443f: tests: add /vhost-user/connect-fail t

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 5d443f: tests: add /vhost-user/connect-fail test
Date:	Mon, 26 Sep 2016 13:00:05 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5d443f5adad6ddd8238602990b7e86404a288d48
      
https://github.com/qemu/qemu/commit/5d443f5adad6ddd8238602990b7e86404a288d48
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M tests/vhost-user-test.c

  Log Message:
  -----------
  tests: add /vhost-user/connect-fail test

Check early connection failure and resume.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ed0a8d92527195bd6009096533e7d0cd8be6fca1
      
https://github.com/qemu/qemu/commit/ed0a8d92527195bd6009096533e7d0cd8be6fca1
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M tests/Makefile.include
    M tests/vhost-user-test.c

  Log Message:
  -----------
  tests: add a simple /vhost-user/multiqueue test

This test just checks that 2 virtio-net queues can be setup over
vhost-user and waits for them to be started.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 9294d76c15e5d0cabc626bc4d95f95f896abc8d0
      
https://github.com/qemu/qemu/commit/9294d76c15e5d0cabc626bc4d95f95f896abc8d0
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M tests/vhost-user-test.c

  Log Message:
  -----------
  tests: add /vhost-user/flags-mismatch test

Check that qemu disconnects the backend that doesn't have the previously
acked features.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 973e7170dddefb491a48df5cba33b2ae151013a0
      
https://github.com/qemu/qemu/commit/973e7170dddefb491a48df5cba33b2ae151013a0
  Author: Prasad J Pandit <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: add check for descriptor's mapped address

virtio back end uses set of buffers to facilitate I/O operations.
If its size is too large, 'cpu_physical_memory_map' could return
a null address. This would result in a null dereference while
un-mapping descriptors. Add check to avoid it.

Reported-by: Qinghao Tang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>


  Commit: 2e0910329bb602559d91e0db5c3f65486f14d955
      
https://github.com/qemu/qemu/commit/2e0910329bb602559d91e0db5c3f65486f14d955
  Author: Igor Mammedov <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M include/hw/i386/pc.h

  Log Message:
  -----------
  pc: clean up COMPAT macro chaining

Since commit
 bacc344c ("machine: add properties to compat_props incrementaly")
there is no need to chain per machine type compat macro.

Clean up places where it was done anyway so it will be
consistent and won't confuse contributors during addtion
of new machine types.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>


  Commit: 152fcbecad3775ba8950060616b59f6c23bc97e8
      
https://github.com/qemu/qemu/commit/152fcbecad3775ba8950060616b59f6c23bc97e8
  Author: Igor Mammedov <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M include/hw/i386/pc.h

  Log Message:
  -----------
  target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

commit (14c985cff target-i386: present virtual L3 cache info for vcpus)
misplaced compat property putting it in new 2.8 machine type
which would effectively to disable feature until 2.9 is released.
Intent of commit probably should be to disable feature for 2.7
and older while allowing not yet released 2.8 to have feature
enabled by default.

Cc: address@hidden
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>


  Commit: 8275e2f6be8b10c2b3da0fe6927d0ce7ad438c80
      
https://github.com/qemu/qemu/commit/8275e2f6be8b10c2b3da0fe6927d0ce7ad438c80
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: fix stray tab character

Fix a single occurrence of a tab character in a file that otherwise uses
spaces for indentation.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Acked-by: Cornelia Huck <address@hidden>


  Commit: f5ed36635d8fa73feb66fe12b3b9c2ed90a1adbe
      
https://github.com/qemu/qemu/commit/f5ed36635d8fa73feb66fe12b3b9c2ed90a1adbe
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c
    M include/hw/virtio/virtio.h

  Log Message:
  -----------
  virtio: stop virtqueue processing if device is broken

QEMU prints an error message and exits when the device enters an invalid
state.  Terminating the process is heavy-handed.  The guest may still be
able to function even if there is a bug in a virtio guest driver.

Moreover, exiting is a bug in nested virtualization where a nested guest
could DoS other nested guests by killing a pass-through virtio device.
I don't think this configuration is possible today but it is likely in
the future.

If the broken flag is set, do not process virtqueues or write back used
descriptors.  The broken flag can be cleared again by resetting the
device.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: 791b1daf724ea835a32e90b2b15df1e20dae6f57
      
https://github.com/qemu/qemu/commit/791b1daf724ea835a32e90b2b15df1e20dae6f57
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: migrate vdev->broken flag

Send a subsection if the vdev->broken flag is set.  This allows live
migration of broken virtio devices.

The subsection is only sent if vdev->broken has been set.  In most cases
the flag will be clear and no subsection will be sent.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: ec55da192403e4a1e05f767c8762273d43ea7da4
      
https://github.com/qemu/qemu/commit/ec55da192403e4a1e05f767c8762273d43ea7da4
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: handle virtqueue_map_desc() errors

Errors can occur during virtqueue_pop(), especially in
virtqueue_map_desc().  In order to handle this we must unmap iov[]
before returning NULL.  The caller will consider the virtqueue empty and
the virtio_error() call will have marked the device broken.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d65abf85e7e5fce31905eaea322ef2ea26e5f2db
      
https://github.com/qemu/qemu/commit/d65abf85e7e5fce31905eaea322ef2ea26e5f2db
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: handle virtqueue_get_avail_bytes() errors

If the vring is invalid, tell the caller no bytes are available and mark
the device broken.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: b1c7c07f2db2096451791882e9d1cdc301b66cdb
      
https://github.com/qemu/qemu/commit/b1c7c07f2db2096451791882e9d1cdc301b66cdb
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: use unsigned int for virtqueue_get_avail_bytes() index

The virtio code uses int, unsigned int, and uint16_t for virtqueue
indices.  The uint16_t is used for the low-level descriptor layout in
virtio_ring.h while code that isn't concerned with descriptor layout can
use unsigned int.

Use of int is problematic because it can result in signed/unsigned
comparison and incompatible int*/unsigned int* pointer types.

Make the virtqueue_get_avail_bytes() 'i' variable unsigned int.  This
eliminates the need to introduce casts and modify code further in the
patches that follow.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: 412e0e81b17488e228b4f8451df6a4af26064bb4
      
https://github.com/qemu/qemu/commit/412e0e81b17488e228b4f8451df6a4af26064bb4
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: handle virtqueue_read_next_desc() errors

Stop processing the vring if an avail ring index is invalid.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: 4355c1abcaedd64a18d627284a3b7e54acb00714
      
https://github.com/qemu/qemu/commit/4355c1abcaedd64a18d627284a3b7e54acb00714
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: handle virtqueue_num_heads() errors

If the avail ring index is bogus virtqueue_num_heads() must return
-EINVAL.

The only caller is virtqueue_get_avail_bytes().  Return saying no bytes
are available when virtqueue_num_heads() fails.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: fb1131b674e492a5f91abd77b9fcc9a9e2b88eb7
      
https://github.com/qemu/qemu/commit/fb1131b674e492a5f91abd77b9fcc9a9e2b88eb7
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: handle virtqueue_get_head() errors

Stop processing the vring if virtqueue_get_head() fetches an
out-of-bounds head index.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>


  Commit: ab71cc0d589b054dccac2756c78042608b8e5b6e
      
https://github.com/qemu/qemu/commit/ab71cc0d589b054dccac2756c78042608b8e5b6e
  Author: David Kiarie <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M include/hw/pci/pci.h

  Log Message:
  -----------
  hw/pci: Prepare for AMD IOMMU

Introduce PCI macros from for use by AMD IOMMU

Signed-off-by: David Kiarie <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d61e45ecc78caf0141dd309c104c5e1fd2716a57
      
https://github.com/qemu/qemu/commit/d61e45ecc78caf0141dd309c104c5e1fd2716a57
  Author: David Kiarie <address@hidden>
  Date:   2016-09-23 (Fri, 23 Sep 2016)

  Changed paths:
    M hw/i386/trace-events

  Log Message:
  -----------
  hw/i386/trace-events: Add AMD IOMMU trace events

Signed-off-by: David Kiarie <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: d29a09ca68428b5708024ea2e9143de0a031081d
      
https://github.com/qemu/qemu/commit/d29a09ca68428b5708024ea2e9143de0a031081d
  Author: David Kiarie <address@hidden>
  Date:   2016-09-24 (Sat, 24 Sep 2016)

  Changed paths:
    M hw/i386/Makefile.objs
    A hw/i386/amd_iommu.c
    A hw/i386/amd_iommu.h

  Log Message:
  -----------
  hw/i386: Introduce AMD IOMMU

Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU.
The IOMMU does basic translation, error checking and has a
minimal IOTLB implementation. This IOMMU bypassed the need
for target aborts by responding with IOMMU_NONE access rights
and exempts the region 0xfee00000-0xfeefffff from translation
as it is the q35 interrupt region.

We advertise features that are not yet implemented to please
the Linux IOMMU driver.

IOTLB aims at implementing commands on real IOMMUs which is
essential for debugging and may not offer any performance
benefits

Signed-off-by: David Kiarie <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: fb9f592623b0f9bb82a88d68d7921fb581918ef5
      
https://github.com/qemu/qemu/commit/fb9f592623b0f9bb82a88d68d7921fb581918ef5
  Author: David Kiarie <address@hidden>
  Date:   2016-09-24 (Sat, 24 Sep 2016)

  Changed paths:
    M hw/acpi/aml-build.c
    M hw/i386/acpi-build.c
    M hw/i386/amd_iommu.c
    M hw/i386/intel_iommu.c
    M hw/i386/x86-iommu.c
    M include/hw/acpi/aml-build.h
    M include/hw/i386/x86-iommu.h

  Log Message:
  -----------
  hw/i386: AMD IOMMU IVRS table

Add IVRS table for AMD IOMMU. Generate IVRS or DMAR
depending on emulated IOMMU.

Signed-off-by: David Kiarie <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f
      
https://github.com/qemu/qemu/commit/7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f
  Author: Peter Maydell <address@hidden>
  Date:   2016-09-26 (Mon, 26 Sep 2016)

  Changed paths:
    M hw/acpi/aml-build.c
    M hw/i386/Makefile.objs
    M hw/i386/acpi-build.c
    A hw/i386/amd_iommu.c
    A hw/i386/amd_iommu.h
    M hw/i386/intel_iommu.c
    M hw/i386/trace-events
    M hw/i386/x86-iommu.c
    M hw/virtio/virtio.c
    M include/hw/acpi/aml-build.h
    M include/hw/i386/pc.h
    M include/hw/i386/x86-iommu.h
    M include/hw/pci/pci.h
    M include/hw/virtio/virtio.h
    M tests/Makefile.include
    M tests/vhost-user-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

virtio, pc: fixes and features

beginning of guest error handling for virtio devices
amd iommu
pc compat fixes

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Fri 23 Sep 2016 23:02:09 BST
# gpg:                using RSA key 0x281F0DB8D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  hw/i386: AMD IOMMU IVRS table
  hw/i386: Introduce AMD IOMMU
  hw/i386/trace-events: Add AMD IOMMU trace events
  hw/pci: Prepare for AMD IOMMU
  virtio: handle virtqueue_get_head() errors
  virtio: handle virtqueue_num_heads() errors
  virtio: handle virtqueue_read_next_desc() errors
  virtio: use unsigned int for virtqueue_get_avail_bytes() index
  virtio: handle virtqueue_get_avail_bytes() errors
  virtio: handle virtqueue_map_desc() errors
  virtio: migrate vdev->broken flag
  virtio: stop virtqueue processing if device is broken
  virtio: fix stray tab character
  target-i386: turn off CPU.l3-cache only for 2.7 and older machine types
  pc: clean up COMPAT macro chaining
  virtio: add check for descriptor's mapped address
  tests: add /vhost-user/flags-mismatch test
  tests: add a simple /vhost-user/multiqueue test
  tests: add /vhost-user/connect-fail test

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3b71ec8516bb...7cfdc02dae0d
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 5d443f: tests: add /vhost-user/connect-fail test, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] bb9f8d: qcow2: fix encryption during cow of sectors
Next by Date: [Qemu-commits] [qemu/qemu] 1c0fbf: virtio-net: allow increasing rx queue size
Previous by thread: [Qemu-commits] [qemu/qemu] bb9f8d: qcow2: fix encryption during cow of sectors
Next by thread: [Qemu-commits] [qemu/qemu] 1c0fbf: virtio-net: allow increasing rx queue size
Index(es):
- Date
- Thread