[Qemu-commits] [qemu/qemu] 3d89e3: xen-platform: re-structure unplug_disks

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3d89e3f7e816b6edbe3a516c754d20288a4e7937
      
https://github.com/qemu/qemu/commit/3d89e3f7e816b6edbe3a516c754d20288a4e7937
  Author: Paul Durrant <address@hidden>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M hw/i386/xen/xen_platform.c

  Log Message:
  -----------
  xen-platform: re-structure unplug_disks

The current code is poorly structured and potentially leads to multiple
config space reads when one is sufficient. Also the UNPLUG_ALL_IDE_DISKS
flag is mis-named since it also results in SCSI disks being unplugged.

This patch renames the flag and re-structures the code to be more
efficient, and readable.

Signed-off-by: Paul Durrant <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>


  Commit: 090fa1c8c837ebabf8c199031e0f9a9bcdf26814
      
https://github.com/qemu/qemu/commit/090fa1c8c837ebabf8c199031e0f9a9bcdf26814
  Author: Paul Durrant <address@hidden>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M hw/i386/xen/xen_platform.c

  Log Message:
  -----------
  xen-platform: add support for unplugging NVMe disks...

...not just IDE and SCSI.

This patch allows the Xen tool-stack to fully support of NVMe as an
emulated disk type. See [1] for the relevant tool-stack patch discussion.

[1] https://lists.xen.org/archives/html/xen-devel/2017-01/msg01225.html

Signed-off-by: Paul Durrant <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>


  Commit: ae4d2eb273b167dad748ea4249720319240b1ac2
      
https://github.com/qemu/qemu/commit/ae4d2eb273b167dad748ea4249720319240b1ac2
  Author: Paul Durrant <address@hidden>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M hw/i386/xen/xen_platform.c
    M hw/ide/piix.c
    M include/hw/ide.h

  Log Message:
  -----------
  xen-platform: add missing disk unplug option

The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to
request unplug of 'aux' disks (which is stated to mean all IDE disks,
except the primary master). This patch adds support for that unplug request.

NOTE: The semantics of what happens if unplug of all disks and 'aux' disks
      is simultaneously requests is not clear. The patch makes that
      assumption that an 'all' request overrides an 'aux' request.

[1] 
http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=docs/misc/hvm-emulated-unplug.markdown

Signed-off-by: Paul Durrant <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
----
Cc: Stefano Stabellini <address@hidden>
Cc: Anthony Perard <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: John Snow <address@hidden>


  Commit: 6d06220ad91985f59454c619dc238ebd8a968cd8
      
https://github.com/qemu/qemu/commit/6d06220ad91985f59454c619dc238ebd8a968cd8
  Author: Anthony PERARD <address@hidden>
  Date:   2017-01-27 (Fri, 27 Jan 2017)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Update xen-devel mailing list address

Signed-off-by: Anthony PERARD <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>


  Commit: e9dcbc86d614018923e26e31319b0a54c9e5abac
      
https://github.com/qemu/qemu/commit/e9dcbc86d614018923e26e31319b0a54c9e5abac
  Author: Juergen Gross <address@hidden>
  Date:   2017-02-02 (Thu, 02 Feb 2017)

  Changed paths:
    M hw/xen/xen_backend.c

  Log Message:
  -----------
  xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

The error exits of xen_pv_find_xendev() free the new xen-device via
g_free() which is wrong.

As the xen-device has been initialized as qdev it must be removed
via qdev_unplug().

This bug has been introduced with commit 3a6c9172ac5951e6dac2b3f6
("xen: create qdev for each backend device").

Reported-by: Roger Pau Monné <address@hidden>
Tested-by: Roger Pau Monné <address@hidden>
Signed-off-by: Juergen Gross <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>


  Commit: 4100a344eb3d50d88f9da85cae334afc47aee134
      
https://github.com/qemu/qemu/commit/4100a344eb3d50d88f9da85cae334afc47aee134
  Author: Peter Maydell <address@hidden>
  Date:   2017-02-03 (Fri, 03 Feb 2017)

  Changed paths:
    M MAINTAINERS
    M hw/i386/xen/xen_platform.c
    M hw/ide/piix.c
    M hw/xen/xen_backend.c
    M include/hw/ide.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170202' into 
staging

Xen 2017/02/02

# gpg: Signature made Thu 02 Feb 2017 18:26:58 GMT
# gpg:                using RSA key 0x894F8F4870E1AE90
# gpg: Good signature from "Stefano Stabellini <address@hidden>"
# gpg:                 aka "Stefano Stabellini <address@hidden>"
# Primary key fingerprint: D04E 33AB A51F 67BA 07D3  0AEA 894F 8F48 70E1 AE90

* remotes/sstabellini/tags/xen-20170202:
  xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()
  MAINTAINERS: Update xen-devel mailing list address
  xen-platform: add missing disk unplug option
  xen-platform: add support for unplugging NVMe disks...
  xen-platform: re-structure unplug_disks

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/77e217d1bf63...4100a344eb3d