qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b91bf5: migration: fix small leaks


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] b91bf5: migration: fix small leaks
Date: Wed, 02 Aug 2017 07:50:14 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b91bf5e488b440e088e425cd115f75a10ed26d06
      
https://github.com/qemu/qemu/commit/b91bf5e488b440e088e425cd115f75a10ed26d06
  Author: Marc-André Lureau <address@hidden>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: fix small leaks

Spotted thanks to valgrind and tests/device-introspect-test:

==11711== 1 bytes in 1 blocks are definitely lost in loss record 6 of 14,537
==11711==    at 0x4C2EB6B: malloc (vg_replace_malloc.c:299)
==11711==    by 0x1E0CDBD8: g_malloc (gmem.c:94)
==11711==    by 0x1E0E696E: g_strdup (gstrfuncs.c:363)
==11711==    by 0x695693: migration_instance_init (migration.c:2226)
==11711==    by 0x717C4B: object_init_with_type (object.c:344)
==11711==    by 0x717E80: object_initialize_with_type (object.c:375)
==11711==    by 0x7182EB: object_new_with_type (object.c:483)
==11711==    by 0x718328: object_new (object.c:493)
==11711==    by 0x4B8A29: qmp_device_list_properties (qmp.c:542)
==11711==    by 0x4A9561: qmp_marshal_device_list_properties 
(qmp-marshal.c:1425)
==11711==    by 0x819D4A: do_qmp_dispatch (qmp-dispatch.c:104)
==11711==    by 0x819E82: qmp_dispatch (qmp-dispatch.c:131)

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 2dfaf12ebbdbb85ac0a583caba02f329a7c1ac09
      
https://github.com/qemu/qemu/commit/2dfaf12ebbdbb85ac0a583caba02f329a7c1ac09
  Author: Peter Xu <address@hidden>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: fix comment disorder in RAMState

Comments for "migration_dirty_pages" and "bitmap_mutex" are switched.
Fix it.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 8bd9c4e6c565c566a6cba3470cb2d4ea63994143
      
https://github.com/qemu/qemu/commit/8bd9c4e6c565c566a6cba3470cb2d4ea63994143
  Author: Peter Xu <address@hidden>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M io/channel-socket.c

  Log Message:
  -----------
  io: fix qio_channel_socket_accept err handling

When accept failed, we should setup errp with the reason. More
importantly, the caller may assume errp be non-NULL when error happens,
and not setting the errp may crash QEMU.

At the same time, move the trace_qio_channel_socket_accept_fail() after
the if check on EINTR. Two reasons:

1. when EINTR happened, it's not really a fault (we should just try
   again), so we should not log with an "accept failure".

2. trace_*() functions may overwrite errno, then the old errno will be
   missing. We need to either check errno before trace_*() calls, or
   reserve the errno.

Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: b21c2751b6448414613002cf544eb6a475c4cfe2
      
https://github.com/qemu/qemu/commit/b21c2751b6448414613002cf544eb6a475c4cfe2
  Author: Peter Maydell <address@hidden>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M io/channel-socket.c
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170802a' 
into staging

Migration pull 2017-08-02

Just minor fixes for 2.10

# gpg: Signature made Wed 02 Aug 2017 14:55:21 BST
# gpg:                using RSA key 0x0516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7

* remotes/dgilbert/tags/pull-migration-20170802a:
  io: fix qio_channel_socket_accept err handling
  migration: fix comment disorder in RAMState
  migration: fix small leaks

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d3d183a638d6...b21c2751b644

reply via email to

[Prev in Thread] Current Thread [Next in Thread]