[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 624532: softfloat: fix {min, max}nummag for s

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 624532: softfloat: fix {min, max}nummag for same-abs-value...
Date: Mon, 16 Apr 2018 02:10:54 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6245327a367292b354489c54e965646823023919
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-04-13 (Fri, 13 Apr 2018)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  softfloat: fix {min, max}nummag for same-abs-value inputs

Before 8936006 ("fpu/softfloat: re-factor minmax", 2018-02-21),
we used to return +Zero for maxnummag(-Zero,+Zero); after that
commit, we return -Zero.

Fix it by making {min,max}nummag consistent with {min,max}num,
deferring to the latter when the absolute value of the operands
is the same.

With this fix we now pass fp-test.

Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

  Commit: 801bc56336a127d9b351b3a2cc0336e4d0cb2686
  Author: Alex Bennée <address@hidden>
  Date:   2018-04-16 (Mon, 16 Apr 2018)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  fpu/softfloat: raise float_invalid for NaN/Inf in round_to_int_and_pack

The re-factor broke the raising of INVALID when NaN/Inf is passed to
the float_to_int conversion functions. round_to_uint_and_pack got this
right for NaN but also missed out the Inf handling.

Fixes https://bugs.launchpad.net/qemu/+bug/1759264

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Bastian Koppelmann <address@hidden>
Tested-by: Bastian Koppelmann <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/38e83a71d02e...801bc56336a1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]