qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c1d992: tests/tpm: fix tpm_util_swtpm_has_tpm


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c1d992: tests/tpm: fix tpm_util_swtpm_has_tpm2()
Date: Thu, 01 Nov 2018 06:23:43 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c1d99200dd3d7f73ebe13b32f12944d3e48a2cb9
      
https://github.com/qemu/qemu/commit/c1d99200dd3d7f73ebe13b32f12944d3e48a2cb9
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-25 (Thu, 25 Oct 2018)

  Changed paths:
    M tests/tpm-util.c

  Log Message:
  -----------
  tests/tpm: fix tpm_util_swtpm_has_tpm2()

Using g_spawn_async_with_pipes() is more complicated than running the
sync version. The async version returns a file descriptor for stdout, which may
not be fully read. Sometime "--tpm2" will failed to be read, and will
cause the related test to be silently skipped.

Use g_spawn_sync() instead, simplifying the code and fixing the race.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: e2f246a50b6d15a3b87a5371a868d21cffe48ba0
      
https://github.com/qemu/qemu/commit/e2f246a50b6d15a3b87a5371a868d21cffe48ba0
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-10-30 (Tue, 30 Oct 2018)

  Changed paths:
    M tests/tpm-tests.c
    M tests/tpm-util.c
    M tests/tpm-util.h

  Log Message:
  -----------
  tests/tpm: Display if swtpm is not found or --tpm2 not supported

If swtpm is not found in $PATH or --tpm2 isn't supported, we display
this in the test log. We cannot mark the test as skipped due to a bug in
certain versions of the gtester environment that interprets a skipped test
as failure.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>


  Commit: 7931cf31265e1f1a1011fde897c8609fe133c734
      
https://github.com/qemu/qemu/commit/7931cf31265e1f1a1011fde897c8609fe133c734
  Author: Stefan Berger <address@hidden>
  Date:   2018-10-30 (Tue, 30 Oct 2018)

  Changed paths:
    M docs/specs/tpm.txt

  Log Message:
  -----------
  docs: tpm: Mention implemented TPM CRB interface emulation and specs

Add a few sentences about the implemented emulation of the TPM CRB
interface and its specification.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 1f63669ec925b9158095c289ef590384d3a4a591
      
https://github.com/qemu/qemu/commit/1f63669ec925b9158095c289ef590384d3a4a591
  Author: Stefan Berger <address@hidden>
  Date:   2018-10-30 (Tue, 30 Oct 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Change my email address to the new domain

My old email address will soon not work anymore, so change it to the
new domain.

Signed-off-by: Stefan Berger <address@hidden>


  Commit: eff1fe9fd0cebe2293eea9597616f792b6b5ad18
      
https://github.com/qemu/qemu/commit/eff1fe9fd0cebe2293eea9597616f792b6b5ad18
  Author: Stefan Berger <address@hidden>
  Date:   2018-10-30 (Tue, 30 Oct 2018)

  Changed paths:
    M hw/tpm/tpm_emulator.c

  Log Message:
  -----------
  tpm: Zero-init structure to avoid uninitialized variables in valgrind log

Zero-init the ptm_loc structure so that we don't have fields that
are not initialised.

Signed-off-by: Stefan Berger <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 8002fa2bf6d3eddc0b73f8a0b64ac6b3ad1defab
      
https://github.com/qemu/qemu/commit/8002fa2bf6d3eddc0b73f8a0b64ac6b3ad1defab
  Author: Peter Maydell <address@hidden>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M MAINTAINERS
    M docs/specs/tpm.txt
    M hw/tpm/tpm_emulator.c
    M tests/tpm-tests.c
    M tests/tpm-util.c
    M tests/tpm-util.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stefanberger/tags/pull-tpm-2018-10-29-2' into staging

Merge tpm 2018/10/29 v2

# gpg: Signature made Tue 30 Oct 2018 21:40:24 GMT
# gpg:                using RSA key 75AD65802A0B4211
# gpg: Good signature from "Stefan Berger <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: B818 B9CA DF90 89C2 D5CE  C66B 75AD 6580 2A0B 4211

* remotes/stefanberger/tags/pull-tpm-2018-10-29-2:
  tpm: Zero-init structure to avoid uninitialized variables in valgrind log
  MAINTAINERS: Change my email address to the new domain
  docs: tpm: Mention implemented TPM CRB interface emulation and specs
  tests/tpm: Display if swtpm is not found or --tpm2 not supported
  tests/tpm: fix tpm_util_swtpm_has_tpm2()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7d51a855cd56...8002fa2bf6d3
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]