qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b6016d: tests/Makefile: Use some more CONFIG


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] b6016d: tests/Makefile: Use some more CONFIG switches for ...
Date: Tue, 22 Jan 2019 03:11:55 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b6016dffa86c296571cb1690e1dd1177664049a3
      
https://github.com/qemu/qemu/commit/b6016dffa86c296571cb1690e1dd1177664049a3
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: Use some more CONFIG switches for x86 tests

To be able to build and test QEMU binaries where certain devices are
disabled, we have to use the right CONFIG_* switches to run certain
tests only if the corresponding device really has been compiled into
the binary.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: e15357801cef4d1d33d35ebddb6ddffe2b129539
      
https://github.com/qemu/qemu/commit/e15357801cef4d1d33d35ebddb6ddffe2b129539
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/Makefile: Use some more CONFIG switches for ppc tests

To be able to build and test QEMU binaries where certain devices or machines
are disabled, we have to use the right CONFIG_* switches to run certain tests
only if the corresponding device or machine really has been compiled into
the binary.

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: fdba0d0919721748fc029ad1ef7ee355037572e0
      
https://github.com/qemu/qemu/commit/fdba0d0919721748fc029ad1ef7ee355037572e0
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/endianness-test.c

  Log Message:
  -----------
  tests/endianesss: Make test independent of global_qtest

Pass around the test state explicitly, to be able to use the qtest_in*()
and qtest_out*() function in this test.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: 8173668c48a35d9c347cfde683b698fc70d772d9
      
https://github.com/qemu/qemu/commit/8173668c48a35d9c347cfde683b698fc70d772d9
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/boot-order-test.c

  Log Message:
  -----------
  tests/boot-order: Make test independent of global_qtest

Pass around the QTestState from function to function, so that we can finally
get rid of the out-of-favor global_qtest variable in this file, too.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: 8a547c8dc84d82efb27b49165ca6f6fed24a9a67
      
https://github.com/qemu/qemu/commit/8a547c8dc84d82efb27b49165ca6f6fed24a9a67
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/pnv-xscom-test.c

  Log Message:
  -----------
  tests/pnv-xscom: Make test independent of global_qtest

Pass around the QTestState, so that we can finally get rid of the
out-of-favor global_qtest variable in this file, too.

Signed-off-by: Thomas Huth <address@hidden>


  Commit: fa9414e9694ebec033dd775bbb3b6ddf468f66c3
      
https://github.com/qemu/qemu/commit/fa9414e9694ebec033dd775bbb3b6ddf468f66c3
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/input/ps2.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/input/ps2: Remove PS2State from "qemu/typedefs.h"

PS2State is only used in "hw/input/ps2.h", there is no
need to expose it via "qemu/typedefs.h".

To clean "qemu/typedefs.h", move the forward declaration
to "hw/input/ps2.h".

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2274e7ddd16219439bf8eef5a606b1be0c6a47a3
      
https://github.com/qemu/qemu/commit/2274e7ddd16219439bf8eef5a606b1be0c6a47a3
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/arm/pxa.h
    M include/hw/pcmcia.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h"

There is only one header file requiring this typedef (hw/arm/pxa.h),
let it include "hw/pcmcia.h" directly to simplify "qemu/typedefs.h".

To clean "qemu/typedefs.h", move the declaration to "hw/pcmcia.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
[thuth: slightly tweaked commit message]
Signed-off-by: Thomas Huth <address@hidden>


  Commit: a8b56ec836860eb7144a3b9de356524316ec9f63
      
https://github.com/qemu/qemu/commit/a8b56ec836860eb7144a3b9de356524316ec9f63
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/ide/ahci.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h"

Files requiring AllwinnerAHCIState already include "hw/ide/ahci.h".

To clean "qemu/typedefs.h", move the declaration to "hw/ide/ahci.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: d183b00e8e18f4fe31db6fc6f0ed5dbe45ef764c
      
https://github.com/qemu/qemu/commit/d183b00e8e18f4fe31db6fc6f0ed5dbe45ef764c
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/i2c/smbus.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h"

Files requiring SMBusDevice already include "hw/i2c/smbus.h".

To clean "qemu/typedefs.h", move the forward declaration
to "hw/i2c/smbus.h".

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: bc8c49d34d280407d7cd5ee1445d4b5772ef3b4c
      
https://github.com/qemu/qemu/commit/bc8c49d34d280407d7cd5ee1445d4b5772ef3b4c
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/qemu/typedefs.h
    M include/sysemu/bt.h

  Log Message:
  -----------
  hw/bt: Remove HCIInfo from "qemu/typedefs.h"

Files requiring HCIInfo already include "sysemu/bt.h".

To clean "qemu/typedefs.h", move the declaration to "sysemu/bt.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 1451b4044328230d3a10fb05907624b10ad6679e
      
https://github.com/qemu/qemu/commit/1451b4044328230d3a10fb05907624b10ad6679e
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/char/serial.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/char/serial: Remove SerialState from "qemu/typedefs.h"

Files requiring SerialState already include "hw/char/serial.h".

To clean "qemu/typedefs.h", move the declaration to "hw/char/serial.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 639f642c60d8690e84b0f9113a9614469b1d7900
      
https://github.com/qemu/qemu/commit/639f642c60d8690e84b0f9113a9614469b1d7900
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/i386/pc.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  hw/i386: Remove PCMachineClass from "qemu/typedefs.h"

Files requiring PCMachineClass already include "hw/i386/pc.h".

To clean "qemu/typedefs.h", move the declaration to "hw/i386/pc.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: fd5283fb4b929742cbaf3cd1d79977b238f11de6
      
https://github.com/qemu/qemu/commit/fd5283fb4b929742cbaf3cd1d79977b238f11de6
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M audio/audio_int.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  audio: Remove AudioState from "qemu/typedefs.h"

Files requiring AudioState already include "audio_int.h".

To clean "qemu/typedefs.h", move the declaration to "audio_int.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: dfbb251e9f36b2e2cf2337ba5240cbd59ea35847
      
https://github.com/qemu/qemu/commit/dfbb251e9f36b2e2cf2337ba5240cbd59ea35847
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/qemu/typedefs.h
    M include/ui/console.h

  Log Message:
  -----------
  ui/console: Remove QemuDmaBuf from "qemu/typedefs.h"

Files requiring QemuDmaBuf already include "ui/console.h".

To clean "qemu/typedefs.h", move the declaration to "ui/console.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 7536587c07da34c7183142df5ef0dada350872b4
      
https://github.com/qemu/qemu/commit/7536587c07da34c7183142df5ef0dada350872b4
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/qemu/typedefs.h
    M include/ui/console.h

  Log Message:
  -----------
  ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h"

Files requiring DisplayState/DisplaySurface already include "ui/console.h".

To clean "qemu/typedefs.h", move the declarations to "ui/console.h"
(removing DisplaySurface forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 5a4c2e5905c05391a3374f75de582148394fd195
      
https://github.com/qemu/qemu/commit/5a4c2e5905c05391a3374f75de582148394fd195
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/devices.h
    M include/qemu/typedefs.h
    M include/ui/console.h

  Log Message:
  -----------
  ui/console: Remove MouseTransformInfo from qemu/typedefs.h

Header files requiring MouseTransformInfo already include "ui/console.h".

To clean "qemu/typedefs.h", move the declaration to "ui/console.h"
(removing the forward declaration).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 0a323e66b509bf2a018ea6c17e9d5fd0da804c44
      
https://github.com/qemu/qemu/commit/0a323e66b509bf2a018ea6c17e9d5fd0da804c44
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/qemu/typedefs.h
    M include/ui/console.h
    M include/ui/qemu-pixman.h

  Log Message:
  -----------
  ui/console: Remove PixelFormat from qemu/typedefs.h

Header files requiring PixelFormat already include "ui/qemu-pixman.h".

To clean "qemu/typedefs.h", move the declaration to "ui/qemu-pixman.h"
(removing the forward declaration).

Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: a51d5afc6929e1d2b3473d331a52be8f350073f1
      
https://github.com/qemu/qemu/commit/a51d5afc6929e1d2b3473d331a52be8f350073f1
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M hw/intc/xics_kvm.c
    M hw/intc/xics_spapr.c
    M hw/ppc/spapr_irq.c
    M include/hw/ppc/xics.h
    A include/hw/ppc/xics_spapr.h

  Log Message:
  -----------
  ppc: Move spapr-related prototypes from xics.h into a seperate header file

When compiling with Clang in -std=gnu99 mode, there is a warning/error:

  CC      ppc64-softmmu/hw/intc/xics_spapr.o
In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34:
/home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: redefinition of 
typedef 'sPAPRMachineState' is a C11 feature
      [-Werror,-Wtypedef-redefinition]
typedef struct sPAPRMachineState sPAPRMachineState;
                           ^
/home/thuth/devel/qemu/include/hw/ppc/spapr_irq.h:25:34: note: previous 
definition is here
typedef struct sPAPRMachineState sPAPRMachineState;
                           ^

We have to remove the duplicated typedef here and include "spapr.h" instead.
But "spapr.h" should not be included for the pnv machine files. So move
the spapr-related prototypes into a new file called "xics_spapr.h" instead.

Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 0d8d6a24fc32c54359606d957d8acbe98b7be9c9
      
https://github.com/qemu/qemu/commit/0d8d6a24fc32c54359606d957d8acbe98b7be9c9
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/ppc/spapr.h
    M include/hw/ppc/spapr_xive.h
    M target/ppc/cpu.h

  Log Message:
  -----------
  ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

When compiling the ppc code with clang and -std=gnu99, there are a
couple of warnings/errors like this one:

  CC      ppc64-softmmu/hw/intc/xics.o
In file included from hw/intc/xics.c:35:
include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a C11 
feature
      [-Werror,-Wtypedef-redefinition]
typedef struct ICPState ICPState;
                  ^
target/ppc/cpu.h:1181:25: note: previous definition is here
typedef struct ICPState ICPState;
                  ^
Work around the problems by including the proper headers in spapr.h
and by using struct forward declarations in cpu.h.

Reviewed-by: Greg Kurz <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: b0b36c021b95eb69451a3e540c9b029a8fb5e21b
      
https://github.com/qemu/qemu/commit/b0b36c021b95eb69451a3e540c9b029a8fb5e21b
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/hw/virtio/virtio-net.h

  Log Message:
  -----------
  virtio-net: Fix VirtIONet typedef redefinition

Commit 2974e916df8 introduced the VirtioNetRscChain structure which
refer to a VirtIONet, declared later, thus required VirtIONet typedef
to use a forward declaration.
However, when compiling with Clang in -std=gnu99 mode, this triggers
the following warning/error:

    CC      hw/net/virtio-net.o
  In file included from qemu/hw/net/virtio-net.c:22:
  include/hw/virtio/virtio-net.h:189:3: error: redefinition of typedef 
'VirtIONet' is a C11 feature [-Werror,-Wtypedef-redefinition]
  } VirtIONet;
    ^
  include/hw/virtio/virtio-net.h:110:26: note: previous definition is here
  typedef struct VirtIONet VirtIONet;
                     ^
  1 error generated.
  make: *** [rules.mak:69: hw/net/virtio-net.o] Error 1

Fix it by removing the duplicate typedef definition.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 798b858130a92f45540e655253b62ddd733ded8c
      
https://github.com/qemu/qemu/commit/798b858130a92f45540e655253b62ddd733ded8c
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M include/qemu/compiler.h
    M linux-user/qemu.h

  Log Message:
  -----------
  linux-user: Fix compilation with clang 3.4

Clang version 3.4.2 does not know the -Wpragmas option yet and bails
out with an error when we try to disable it in linux-user/qemu.h.
Fortunately, clang has a __has_warning() macro which allows us to add
an explicit check for the option that we want to ignore. With that we
can check for the availability of "-Waddress-of-packed-member" properly
and do not need the "-Wpragmas" at all here.

Fixes: 850d5e330a9c68cc998cecc02caf8a3c8d1ee8a3
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: df71ca84e4dccc8b49233c63c414e0e5e7bcdf0b
      
https://github.com/qemu/qemu/commit/df71ca84e4dccc8b49233c63c414e0e5e7bcdf0b
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  block: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad
"inline" prototype definitions which GCC refuses to compile in its
gnu99 mode:

In file included from block/iscsi.c:52:0:
/usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function
‘scsi_set_uint16’ declared but never defined [-Werror]
 inline void scsi_set_uint16(unsigned char *c, uint16_t val);
       ^
/usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function
‘scsi_set_uint32’ declared but never defined [-Werror]
 inline void scsi_set_uint32(unsigned char *c, uint32_t val);
       ^
[...]

This has been fixed by upstream libiscsi in version 1.10.0 (see
https://github.com/sahlberg/libiscsi/commit/7692027d6c11 ), but
since we still want to support 1.9.0 for CentOS 7 / RHEL7, we
have to work-around the issue by redefining the "inline" keyword
to use the old "gnu89" mode behavior via "gnu_inline" instead.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: e81e7b52f9d0c49243437d129ca3bc3fcf9289a8
      
https://github.com/qemu/qemu/commit/e81e7b52f9d0c49243437d129ca3bc3fcf9289a8
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M qemu-seccomp.c

  Log Message:
  -----------
  seccomp: Work-around GCC 4.x bug in gnu99 mode

We'd like to compile QEMU with -std=gnu99, but GCC 4.8 currently
fails to compile qemu-seccomp.c in this mode:

qemu-seccomp.c:45:1: error: initializer element is not constant
 };
 ^
qemu-seccomp.c:45:1: error: (near initialization for 
‘sched_setscheduler_arg[0]’)

This is due to a compiler bug which has just been fixed in GCC 5.0:

 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63567

Since we still want to support GCC 4.8 for a while and also want to use
gnu99 mode, work-around the issue by expanding the macro manually.

Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Eduardo Otubo <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 7be41675f7cb16be7c8d2554add7a63fa43781a8
      
https://github.com/qemu/qemu/commit/7be41675f7cb16be7c8d2554add7a63fa43781a8
  Author: Thomas Huth <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Force the C standard to gnu99

Different versions of GCC and Clang use different versions of the C standard.
This repeatedly caused problems already, e.g. with duplicated typedefs:

 https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html

or with for-loop variable initializers:

 https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00237.html

To avoid these problems, we should enforce the C language version to the
same level for all compilers. Since our minimum compiler versions is
GCC v4.8, our best option is "gnu99" for C code right now ("gnu17" is not
available there yet, and "gnu11" is marked as "experimental"), and "gnu++98"
for the few C++ code that we have in the repository.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 739fc38778a8ead742b201fc801a3cacb9083f66
      
https://github.com/qemu/qemu/commit/739fc38778a8ead742b201fc801a3cacb9083f66
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/hexloader-test.c

  Log Message:
  -----------
  tests/hexloader-test: Don't pass -nographic to the QEMU under test

The hexloader test invokes QEMU with the -nographic argument. This
is unnecessary, because the qtest_initf() function will pass it
-display none, which suffices to disable the graphical window.
It also means that the QEMU process will make the stdin/stdout
O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per
"file description", this non-blocking behaviour is then shared
with any other process that's using the stdin/stdout of the
'make check' run, including make itself. This can result in make
falling over with "make: write error: stdout" because it got
an unexpected EINTR trying to write output messages to the terminal.
This is particularly noticable if running 'make check' in a loop with
  while make check; do true; done
(It does not affect single make check runs so much because the
shell will remove the O_NONBLOCK status before it reads the
terminal for interactive input.)

Remove the unwanted -nographic argument.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: f48a79da78eb605bb0977f930ca137e9b8bdede8
      
https://github.com/qemu/qemu/commit/f48a79da78eb605bb0977f930ca137e9b8bdede8
  Author: Paolo Bonzini <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests: remove rule for nonexisting qdev-monitor-test

This test was merged into drive_del-test in 2014.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Fixes: e2f3f221885a90de766ce9a3 ("Merge of qdev-monitor-test, blockdev-test")
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 851aa0a5a89b2812965ab2fdef30f19eea605201
      
https://github.com/qemu/qemu/commit/851aa0a5a89b2812965ab2fdef30f19eea605201
  Author: Peter Maydell <address@hidden>
  Date:   2019-01-22 (Tue, 22 Jan 2019)

  Changed paths:
    M audio/audio_int.h
    M block/iscsi.c
    M configure
    M hw/intc/xics_kvm.c
    M hw/intc/xics_spapr.c
    M hw/ppc/spapr_irq.c
    M include/hw/arm/pxa.h
    M include/hw/char/serial.h
    M include/hw/devices.h
    M include/hw/i2c/smbus.h
    M include/hw/i386/pc.h
    M include/hw/ide/ahci.h
    M include/hw/input/ps2.h
    M include/hw/pcmcia.h
    M include/hw/ppc/spapr.h
    M include/hw/ppc/spapr_xive.h
    M include/hw/ppc/xics.h
    A include/hw/ppc/xics_spapr.h
    M include/hw/virtio/virtio-net.h
    M include/qemu/compiler.h
    M include/qemu/typedefs.h
    M include/sysemu/bt.h
    M include/ui/console.h
    M include/ui/qemu-pixman.h
    M linux-user/qemu.h
    M qemu-seccomp.c
    M target/ppc/cpu.h
    M tests/Makefile.include
    M tests/boot-order-test.c
    M tests/endianness-test.c
    M tests/hexloader-test.c
    M tests/pnv-xscom-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2019-01-22' into staging

- Use more CONFIG Makefile switches for qtests
- Get rid of global_qtests in some more qtests
- typedef cleanups
- Fixes for compiling with Clang
- Force C standard to gnu99
- Don't use -nographic in qtests

# gpg: Signature made Tue 22 Jan 2019 06:18:41 GMT
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2019-01-22: (26 commits)
  tests: remove rule for nonexisting qdev-monitor-test
  tests/hexloader-test: Don't pass -nographic to the QEMU under test
  configure: Force the C standard to gnu99
  seccomp: Work-around GCC 4.x bug in gnu99 mode
  block: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode
  linux-user: Fix compilation with clang 3.4
  virtio-net: Fix VirtIONet typedef redefinition
  ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode
  ppc: Move spapr-related prototypes from xics.h into a seperate header file
  ui/console: Remove PixelFormat from qemu/typedefs.h
  ui/console: Remove MouseTransformInfo from qemu/typedefs.h
  ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h"
  ui/console: Remove QemuDmaBuf from "qemu/typedefs.h"
  audio: Remove AudioState from "qemu/typedefs.h"
  hw/i386: Remove PCMachineClass from "qemu/typedefs.h"
  hw/char/serial: Remove SerialState from "qemu/typedefs.h"
  hw/bt: Remove HCIInfo from "qemu/typedefs.h"
  hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h"
  hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h"
  hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h"
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e56b86bc7735...851aa0a5a89b
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]