[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3a2835: hw/block/pflash_cfi01: Add missing De
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 3a2835: hw/block/pflash_cfi01: Add missing DeviceReset() h... |
Date: |
Tue, 23 Jul 2019 03:48:40 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3a283507c03474d285196620fca506bd1a89b198
https://github.com/qemu/qemu/commit/3a283507c03474d285196620fca506bd1a89b198
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2019-07-23 (Tue, 23 Jul 2019)
Changed paths:
M hw/block/pflash_cfi01.c
Log Message:
-----------
hw/block/pflash_cfi01: Add missing DeviceReset() handler
To avoid incoherent states when the machine resets (see bug report
below), add the device reset callback.
A "system reset" sets the device state machine in READ_ARRAY mode
and, after some delay, set the SR.7 READY bit.
Since we do not model timings, we set the SR.7 bit directly.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1678713
Reported-by: Laszlo Ersek <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Tested-by: Laszlo Ersek <address@hidden>
[Laszlo Ersek: Regression tested EDK2 OVMF IA32X64, ArmVirtQemu Aarch64
https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg04373.html]
Message-Id: <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 124e4cfaa42bb5a14eec33ea47d3502b5f46eb33
https://github.com/qemu/qemu/commit/124e4cfaa42bb5a14eec33ea47d3502b5f46eb33
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2019-07-23 (Tue, 23 Jul 2019)
Changed paths:
M hw/block/pflash_cfi02.c
Log Message:
-----------
hw/block/pflash_cfi02: Rewrite a fall through comment
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:
hw/block/pflash_cfi02.c: In function ‘pflash_write’:
hw/block/pflash_cfi02.c:574:16: error: this statement may fall through
[-Werror=implicit-fallthrough=]
574 | if (boff == 0x55 && cmd == 0x98) {
| ^
hw/block/pflash_cfi02.c:581:9: note: here
581 | default:
| ^~~~~~~
cc1: all warnings being treated as errors
Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.
Reported-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Commit: cec9f94f2dec8d34f2de76cdb2f562981858a9ef
https://github.com/qemu/qemu/commit/cec9f94f2dec8d34f2de76cdb2f562981858a9ef
Author: Peter Maydell <address@hidden>
Date: 2019-07-23 (Tue, 23 Jul 2019)
Changed paths:
M hw/block/pflash_cfi01.c
M hw/block/pflash_cfi02.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/pflash-next-20190723' into staging
One bugfix and silent a fallthru warning.
# gpg: Signature made Tue 23 Jul 2019 10:33:34 BST
# gpg: using RSA key E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <address@hidden>"
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE
* remotes/philmd-gitlab/tags/pflash-next-20190723:
hw/block/pflash_cfi02: Rewrite a fall through comment
hw/block/pflash_cfi01: Add missing DeviceReset() handler
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/ecb199b177b3...cec9f94f2dec
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 3a2835: hw/block/pflash_cfi01: Add missing DeviceReset() h...,
Peter Maydell <=