qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 348fbd: test: Use g_strndup instead of plain


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 348fbd: test: Use g_strndup instead of plain strndup
Date: Thu, 22 Aug 2019 02:36:24 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 348fbd5816cab30d38d7a3727a4b83404797128a
      
https://github.com/qemu/qemu/commit/348fbd5816cab30d38d7a3727a4b83404797128a
  Author: address@hidden <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M tests/check-qjson.c
    M tests/migration/stress.c

  Log Message:
  -----------
  test: Use g_strndup instead of plain strndup

Due to memory management rules. See HACKING.

Signed-off-by: Tony Nguyen <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>

Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: ac78f737222ca5273cda26deeb850aa8546d108d
      
https://github.com/qemu/qemu/commit/ac78f737222ca5273cda26deeb850aa8546d108d
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M docs/devel/migration.rst
    M hw/i386/pc_piix.c

  Log Message:
  -----------
  misc: fix naming scheme of compatiblity arrays

Since merge 31ed41889e6e13699871040fe089a2884dca46cb ("Merge
remote-tracking branch
'remotes/elmarco/tags/machine-props-pull-request' into staging"), the
compat arrays are in lowercase.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: edd318b7a3c54321ead363ffc1e22ebac5785f1d
      
https://github.com/qemu/qemu/commit/edd318b7a3c54321ead363ffc1e22ebac5785f1d
  Author: Carlo Marcelo Arenas Belón <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: remove obsoleted $sparc_cpu variable

9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in
32-bit mode.", 2012-09-21) removed the need for this variable and
most of the references to it, but this one.

Remove defunct code, no effect or functionality change expected.

Signed-off-by: Carlo Marcelo Arenas Belón <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: aee8a61946750b627f3b58438314a62be60dad34
      
https://github.com/qemu/qemu/commit/aee8a61946750b627f3b58438314a62be60dad34
  Author: Carlo Marcelo Arenas Belón <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: fix sdl detection using sdl2-config

If SDL2 is requested but pkg-config doesn't have a module for it
configure should fallback to use sdl*-config, but wasn't able to
because and old variable (from SDL) was being used by mistake.

Correct the variable name and complete other related changes so
there are no more references to the old SDL.

Fixes: 0015ca5cbabe ("ui: remove support for SDL1.2 in favour of SDL2")
Signed-off-by: Carlo Marcelo Arenas Belón <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 6fd9d9b7b58a82b0da3d0c9d7f0bdaba99ff64da
      
https://github.com/qemu/qemu/commit/6fd9d9b7b58a82b0da3d0c9d7f0bdaba99ff64da
  Author: Michal Privoznik <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  .gitignore: ignore some vhost-user* related files

Commit d52c454aadc creates
'/contrib/vhost-user-gpu/50-qemu-gpu.json' and '/vhost-user-gpu'
and commit 06914c97d3a creates '/vhost-user-input' neither of
which is ignored by git.

Signed-off-by: Michal Privoznik <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 80867bdbfc400b79686126c179b8ea70d79239b6
      
https://github.com/qemu/qemu/commit/80867bdbfc400b79686126c179b8ea70d79239b6
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/net/e1000.c

  Log Message:
  -----------
  hw/net/e1000: Fix erroneous comment

Missed during the QOM convertion in 9af21dbee14.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 6f0dd6c5d25a0355b1dfc36dd8ed40dc053b3d54
      
https://github.com/qemu/qemu/commit/6f0dd6c5d25a0355b1dfc36dd8ed40dc053b3d54
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M qobject/json-parser.c

  Log Message:
  -----------
  json: Move switch 'fall through' comment to correct place

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:

  qobject/json-parser.c: In function ‘parse_literal’:
  qobject/json-parser.c:492:24: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
    492 |     case JSON_INTEGER: {
        |                        ^
  qobject/json-parser.c:524:5: note: here
    524 |     case JSON_FLOAT:
        |     ^~~~

Correctly place the 'fall through' comment.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 45a9eacead727164b3b76087ed93046a4b974a34
      
https://github.com/qemu/qemu/commit/45a9eacead727164b3b76087ed93046a4b974a34
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/dma/omap_dma.c

  Log Message:
  -----------
  hw/dma/omap_dma: Move switch 'fall through' comment to correct place

Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:

    CC      hw/dma/omap_dma.o
  hw/dma/omap_dma.c: In function ‘omap_dma_write’:
  hw/dma/omap_dma.c:1532:12: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
   1532 |         if (s->model <= omap_dma_3_1)
        |            ^
  hw/dma/omap_dma.c:1534:5: note: here
   1534 |     case 0x400:
        |     ^~~~
  cc1: all warnings being treated as errors

Correctly place the 'fall through' comment.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 5a70b8b550a8e236fd7f696c803fc05c4cae2a54
      
https://github.com/qemu/qemu/commit/5a70b8b550a8e236fd7f696c803fc05c4cae2a54
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/ipmi/ipmi_bmc_extern.c

  Log Message:
  -----------
  hw/ipmi: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
  hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
    178 |         ch |= 0x10;
        |         ~~~^~~~~~~
  hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
    181 |     default:
        |     ^~~~~~~
  cc1: all warnings being treated as errors
  make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Corey Minyard <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: b1d5b6e507c168a939b753be52f518d2981a2b51
      
https://github.com/qemu/qemu/commit/b1d5b6e507c168a939b753be52f518d2981a2b51
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M target/ppc/mmu_helper.c

  Log Message:
  -----------
  target/ppc: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  target/ppc/mmu_helper.c: In function ‘dump_mmu’:
  target/ppc/mmu_helper.c:1349:12: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
   1349 |         if (ppc64_v3_radix(env_archcpu(env))) {
        |            ^
  target/ppc/mmu_helper.c:1356:5: note: here
   1356 |     default:
        |     ^~~~~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: David Gibson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 4e8de60623f49def9016b8174261e9ab84f79bb7
      
https://github.com/qemu/qemu/commit/4e8de60623f49def9016b8174261e9ab84f79bb7
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vl: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  vl.c: In function ‘qemu_ref_timedate’:
  vl.c:773:15: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
    773 |         value -= rtc_realtime_clock_offset;
        |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  vl.c:775:5: note: here
    775 |     case QEMU_CLOCK_VIRTUAL:
        |     ^~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 54db89f5bbe5c12f238835aa94aa4b13ac22834d
      
https://github.com/qemu/qemu/commit/54db89f5bbe5c12f238835aa94aa4b13ac22834d
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/ppc/spapr_events.c

  Log Message:
  -----------
  spapr_events: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

    CC      ppc64-softmmu/hw/ppc/spapr_rtc.o
  hw/ppc/spapr_events.c: In function ‘rtas_event_log_to_source’:
  hw/ppc/spapr_events.c:312:12: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
    312 |         if (spapr_ovec_test(spapr->ov5_cas, OV5_HP_EVT)) {
        |            ^
  hw/ppc/spapr_events.c:317:5: note: here
    317 |     case RTAS_LOG_TYPE_EPOW:
        |     ^~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: David Gibson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: ea2b7c9faaf22e74bc42a880ecf94c4f33c0d46e
      
https://github.com/qemu/qemu/commit/ea2b7c9faaf22e74bc42a880ecf94c4f33c0d46e
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/display/sm501.c

  Log Message:
  -----------
  hw/display/sm501: Remove unused include

The "cpu.h" include makes devices target-specific. Since it
is not used, remove it, so the device become generic (we can
now compile it once for all targets).

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
[lv: fix conflict with 650d103d3ea9
     ("Include hw/hw.h exactly where needed")]
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 8a9224a250094222e9ff302b95e379c3e71d3c8a
      
https://github.com/qemu/qemu/commit/8a9224a250094222e9ff302b95e379c3e71d3c8a
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M hw/display/Makefile.objs

  Log Message:
  -----------
  hw/display: Compile various display devices as common object

Various display devices are not target-specific and can
be compiled once for all the targets.
After this commit, the 'make world' target is reduced by
54 objects

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Acked-by: Gerd Hoffmann <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: fe066b4848bab4f9365a419f3c8ba59ccecf67c0
      
https://github.com/qemu/qemu/commit/fe066b4848bab4f9365a419f3c8ba59ccecf67c0
  Author: Peter Maydell <address@hidden>
  Date:   2019-08-21 (Wed, 21 Aug 2019)

  Changed paths:
    M .gitignore
    M configure
    M docs/devel/migration.rst
    M hw/display/Makefile.objs
    M hw/display/sm501.c
    M hw/dma/omap_dma.c
    M hw/i386/pc_piix.c
    M hw/ipmi/ipmi_bmc_extern.c
    M hw/net/e1000.c
    M hw/ppc/spapr_events.c
    M qobject/json-parser.c
    M target/ppc/mmu_helper.c
    M tests/check-qjson.c
    M tests/migration/stress.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-pull-request' into staging

Various trivial fixes

# gpg: Signature made Wed 21 Aug 2019 12:19:11 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-pull-request:
  hw/display: Compile various display devices as common object
  hw/display/sm501: Remove unused include
  spapr_events: Rewrite a fall through comment
  vl: Rewrite a fall through comment
  target/ppc: Rewrite a fall through comment
  hw/ipmi: Rewrite a fall through comment
  hw/dma/omap_dma: Move switch 'fall through' comment to correct place
  json: Move switch 'fall through' comment to correct place
  hw/net/e1000: Fix erroneous comment
  .gitignore: ignore some vhost-user* related files
  configure: fix sdl detection using sdl2-config
  configure: remove obsoleted $sparc_cpu variable
  misc: fix naming scheme of compatiblity arrays
  test: Use g_strndup instead of plain strndup

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/33f18cf7dca7...fe066b4848ba



reply via email to

[Prev in Thread] Current Thread [Next in Thread]