qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 73a5a7: BootLinuxSshTest: Only use 'test' for


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 73a5a7: BootLinuxSshTest: Only use 'test' for unittest.Tes...
Date: Tue, 03 Sep 2019 08:48:09 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 73a5a775d273d34221889dc91be7580e26a9584d
      
https://github.com/qemu/qemu/commit/73a5a775d273d34221889dc91be7580e26a9584d
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M tests/acceptance/linux_ssh_mips_malta.py

  Log Message:
  -----------
  BootLinuxSshTest: Only use 'test' for unittest.TestCase method names

In commit f6e501a28ef9, Eduardo started to use "check_" as a
prefix for methods of similar purpose. Follow this prior art,
since it might become the conventions when writting Avocado
tests.

Suggested-by: Cleber Rosa <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Cleber Rosa <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 406ab2f331555cfcf320fe2a77949d7f8af7ab32
      
https://github.com/qemu/qemu/commit/406ab2f331555cfcf320fe2a77949d7f8af7ab32
  Author: Cleber Rosa <address@hidden>
  Date:   2019-08-27 (Tue, 27 Aug 2019)

  Changed paths:
    M configure
    M tests/Makefile.include

  Log Message:
  -----------
  configure: more resilient Python version capture

The current approach to capture the Python version is fragile, as it
was demonstrated by a very specific build of Python 3 on Fedora 29
that, under non-interactive shells would print multiline version
information.

The (badly) stripped version output would be sent to config-host.mak,
producing bad syntax and rendering the makefiles unusable.  Now, the
Python versions is printed by configure, but only a simple (and better
controlled variable) indicating whether the build system is using
Python 2 is kept on config-host.mak.

Signed-off-by: Cleber Rosa <address@hidden>

Message-Id: <address@hidden>
Reviewed-by: Tony Nguyen <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 40c8bb53d892d2f443c13177085406bd33bbf482
      
https://github.com/qemu/qemu/commit/40c8bb53d892d2f443c13177085406bd33bbf482
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-03 (Tue, 03 Sep 2019)

  Changed paths:
    M configure
    M tests/Makefile.include
    M tests/acceptance/linux_ssh_mips_malta.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' 
into staging

Python queue, 2019-08-28

Bug fix:
* configure: more resilient Python version capture (Cleber Rosa)

Cleanup:
* BootLinuxSshTest: Only use 'test' for unittest.TestCase method
  names (Philippe Mathieu-Daudé)

# gpg: Signature made Wed 28 Aug 2019 20:22:35 BST
# gpg:                using RSA key 5A322FD5ABC4D3DBACCFD1AA2807936F984DC5A6
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Eduardo Habkost <address@hidden>" [full]
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/python-next-pull-request:
  configure: more resilient Python version capture
  BootLinuxSshTest: Only use 'test' for unittest.TestCase method names

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/fec105c2abda...40c8bb53d892



reply via email to

[Prev in Thread] Current Thread [Next in Thread]