[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 0cb040: tests/iothread: Always connect iothre
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 0cb040: tests/iothread: Always connect iothread GSource to... |
Date: |
Tue, 07 Jan 2020 07:45:12 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 0cb04061728a5e6cf579c43b8c3695fb70d07697
https://github.com/qemu/qemu/commit/0cb04061728a5e6cf579c43b8c3695fb70d07697
Author: Peter Maydell <address@hidden>
Date: 2020-01-07 (Tue, 07 Jan 2020)
Changed paths:
M tests/iothread.c
Log Message:
-----------
tests/iothread: Always connect iothread GSource to a GMainContext
On older versions of glib (anything prior to glib commit 0f056ebe
from May 2019), the implementation of g_source_ref() and
g_source_unref() is not threadsafe for a GSource which is not
attached to a GMainContext.
QEMU's real iothread.c implementation always attaches its
iothread->ctx's GSource to a GMainContext created for that iothread,
so it is OK, but the simple test framework implementation in
tests/iothread.c was not doing this. This was causing intermittent
assertion failures in the test-aio-multithread subtest
"/aio/multi/mutex/contended" test on the BSD hosts. (It's unclear
why only BSD seems to have been affected -- perhaps a combination of
the specific glib version being used in the VMs and their happening
to run on a host with a lot of CPUs).
Borrow the iothread_init_gcontext() from the real iothread.c
and add the corresponding cleanup code and the calls to
g_main_context_push/pop_thread_default() so we actually use
the GMainContext we create.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Message-id: address@hidden
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 0cb040: tests/iothread: Always connect iothread GSource to...,
Peter Maydell <=