[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3f0097: trace: update qemu-trace-stap to Pyth

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 3f0097: trace: update qemu-trace-stap to Python 3
Date: Tue, 14 Jan 2020 06:15:17 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3f0097169bb60268cc5dda0c5ea47c31ab57b22f
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M scripts/qemu-trace-stap

  Log Message:
  trace: update qemu-trace-stap to Python 3

qemu-trace-stap does not support Python 3 yet:

  $ scripts/qemu-trace-stap list path/to/qemu-system-x86_64
  Traceback (most recent call last):
    File "scripts/qemu-trace-stap", line 175, in <module>
    File "scripts/qemu-trace-stap", line 171, in main
    File "scripts/qemu-trace-stap", line 118, in cmd_list
      print_probes(args.verbose, "*")
    File "scripts/qemu-trace-stap", line 114, in print_probes
      if line.startswith(prefix):
  TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Now that QEMU requires Python 3.5 or later we can switch to pure Python
3.  Use Popen()'s universal_newlines=True argument to treat stdout as
text instead of binary.

Fixes: 62dd1048c0bd ("trace: add ability to do simple printf logging via 
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1787395
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
Message-Id: <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>

  Commit: 29234ded1fe2f76e57382876ddeec88793420bec
  Author: Peter Maydell <address@hidden>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M scripts/qemu-trace-stap

  Log Message:
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

Pull request

# gpg: Signature made Tue 14 Jan 2020 09:29:11 GMT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>" [full]
# gpg:                 aka "Stefan Hajnoczi <address@hidden>" [full]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/tracing-pull-request:
  trace: update qemu-trace-stap to Python 3

Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/3c8a6575985b...29234ded1fe2

reply via email to

[Prev in Thread] Current Thread [Next in Thread]