[Qemu-commits] [qemu/qemu] 20ac58: Use &error_abort instead of separate assert()

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 20ac582d0cdf78348650318eeabba5bcd486613f
      
https://github.com/qemu/qemu/commit/20ac582d0cdf78348650318eeabba5bcd486613f
  Author: Markus Armbruster <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M block/monitor/block-hmp-cmds.c
    M target/arm/monitor.c
    M tests/qtest/fuzz/qos_fuzz.c

  Log Message:
  -----------
  Use &error_abort instead of separate assert()

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Acked-by: Alexander Bulekov <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
[Unused Error *variable deleted]


  Commit: 364effc0eb90f440e0355d6326d46fed8e23fb6a
      
https://github.com/qemu/qemu/commit/364effc0eb90f440e0355d6326d46fed8e23fb6a
  Author: Markus Armbruster <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  hw/misc/ivshmem: Use one Error * variable instead of two

Commit fe44dc9180 "migration: disallow migrate_add_blocker during
migration" accidentally added a second Error * variable.  Use the
first one instead.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


  Commit: 526ab8e8630f17f6f412c160d4e9571766960be9
      
https://github.com/qemu/qemu/commit/526ab8e8630f17f6f412c160d4e9571766960be9
  Author: Markus Armbruster <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M hw/block/xen-block.c

  Log Message:
  -----------
  xen-block: Use one Error * variable instead of two

While there, tidy up indentation, and add return just for consistency
and robustness.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
[The "while there" cleanups squashed in]


  Commit: 709dfb64925ed2b2978bf4c17ab98b2c7a9a05c1
      
https://github.com/qemu/qemu/commit/709dfb64925ed2b2978bf4c17ab98b2c7a9a05c1
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2020-03-17 (Tue, 17 Mar 2020)

  Changed paths:
    M hw/sd/ssi-sd.c

  Log Message:
  -----------
  hw/sd/ssi-sd: fix error handling in ssi_sd_realize

It's wrong to use same err object as errp parameter for several
function calls without intermediate checking for error: we'll crash if
try to set err object twice. Fix that.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: cf4b64406c0e7542b4e1852f5e5a743ad63cf36e
      
https://github.com/qemu/qemu/commit/cf4b64406c0e7542b4e1852f5e5a743ad63cf36e
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-18 (Wed, 18 Mar 2020)

  Changed paths:
    M block/monitor/block-hmp-cmds.c
    M hw/block/xen-block.c
    M hw/misc/ivshmem.c
    M hw/sd/ssi-sd.c
    M target/arm/monitor.c
    M tests/qtest/fuzz/qos_fuzz.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-03-17' into 
staging

Error reporting patches for 2020-03-17

# gpg: Signature made Tue 17 Mar 2020 16:30:49 GMT
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Markus Armbruster <address@hidden>" [full]
# gpg:                 aka "Markus Armbruster <address@hidden>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-error-2020-03-17:
  hw/sd/ssi-sd: fix error handling in ssi_sd_realize
  xen-block: Use one Error * variable instead of two
  hw/misc/ivshmem: Use one Error * variable instead of two
  Use &error_abort instead of separate assert()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b319df553707...cf4b64406c0e