[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] b1288d: virtiofsd: Terminate capability list
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] b1288d: virtiofsd: Terminate capability list |
Date: |
Sat, 04 Jul 2020 08:15:24 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: b1288dfafbdfb64e86bf9cfa22fa0b399e44e198
https://github.com/qemu/qemu/commit/b1288dfafbdfb64e86bf9cfa22fa0b399e44e198
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M tools/virtiofsd/passthrough_ll.c
Log Message:
-----------
virtiofsd: Terminate capability list
capng_updatev is a varargs function that needs a -1 to terminate it,
but it was missing.
In practice what seems to have been happening is that it's added the
capabilities we asked for, then runs into junk on the stack, so if
we're unlucky it might be adding some more, but in reality it's
failing - but after adding the capabilities we asked for.
Fixes: a59feb483b8 ("virtiofsd: only retain file system capabilities")
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20200629115420.98443-2-dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: 55b22a60cc7ac25565a13813deba3d548cb48bd3
https://github.com/qemu/qemu/commit/55b22a60cc7ac25565a13813deba3d548cb48bd3
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M tools/virtiofsd/passthrough_ll.c
Log Message:
-----------
virtiofsd: Check capability calls
Check the capability calls worked.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20200629115420.98443-3-dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: 3005c099ef3c6b43213e1454296c1c6556345805
https://github.com/qemu/qemu/commit/3005c099ef3c6b43213e1454296c1c6556345805
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M docs/tools/virtiofsd.rst
M tools/virtiofsd/helper.c
M tools/virtiofsd/passthrough_ll.c
Log Message:
-----------
virtiofsd: Allow addition or removal of capabilities
Allow capabilities to be added or removed from the allowed set for the
daemon; e.g.
default:
CapPrm: 00000000880000df
CapEff: 00000000880000df
-o modcaps=+sys_admin
CapPrm: 00000000882000df
CapEff: 00000000882000df
-o modcaps=+sys_admin:-chown
CapPrm: 00000000882000de
CapEff: 00000000882000de
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200629115420.98443-4-dgilbert@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: 617a32f5295ee4efcc17abadcecc3cf482c98e80
https://github.com/qemu/qemu/commit/617a32f5295ee4efcc17abadcecc3cf482c98e80
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M migration/postcopy-ram.c
Log Message:
-----------
migration: postcopy take proper error return
This function returns a boolean success and we're returning -1;
lets just use the 'out' error path.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy")
Buglink: https://bugs.launchpad.net/qemu/+bug/1885720
Message-Id: <20200701093557.130096-1-dgilbert@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: fb6135807fcab4670d69663ac88e88e124348ffd
https://github.com/qemu/qemu/commit/fb6135807fcab4670d69663ac88e88e124348ffd
Author: Keqian Zhu <zhukeqian1@huawei.com>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M include/exec/ram_addr.h
M migration/ram.c
Log Message:
-----------
migration: Count new_dirty instead of real_dirty
real_dirty_pages becomes equal to total ram size after dirty log sync
in ram_init_bitmaps, the reason is that the bitmap of ramblock is
initialized to be all set, so old path counts them as "real dirty" at
beginning.
This causes wrong dirty rate and false positive throttling.
Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
Message-Id: <20200622032037.31112-1-zhukeqian1@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Commit: 0b100c8e72c54bcd6f865d6570ffe838dafe7105
https://github.com/qemu/qemu/commit/0b100c8e72c54bcd6f865d6570ffe838dafe7105
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2020-07-04 (Sat, 04 Jul 2020)
Changed paths:
M docs/tools/virtiofsd.rst
M include/exec/ram_addr.h
M migration/postcopy-ram.c
M migration/ram.c
M tools/virtiofsd/helper.c
M tools/virtiofsd/passthrough_ll.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200703a'
into staging
virtiofsd+migration pull 2020-07-03
A couple of small migration fixes, and some capability
rework for virtiofsd.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
# gpg: Signature made Fri 03 Jul 2020 16:26:35 BST
# gpg: using RSA key 45F5C71B4A0CB7FB977A9FA90516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <dgilbert@redhat.com>"
[full]
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A 9FA9 0516 331E BC5B FDE7
* remotes/dgilbert/tags/pull-migration-20200703a:
migration: Count new_dirty instead of real_dirty
migration: postcopy take proper error return
virtiofsd: Allow addition or removal of capabilities
virtiofsd: Check capability calls
virtiofsd: Terminate capability list
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/21d0bafbfe41...0b100c8e72c5
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] b1288d: virtiofsd: Terminate capability list,
Peter Maydell <=