[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3aaebc: qga-win: fix "guest-get-fsinfo" wrong
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 3aaebc: qga-win: fix "guest-get-fsinfo" wrong filesystem type |
Date: |
Tue, 28 Jul 2020 08:30:34 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3aaebc0cce4a4963f331f45643e17266646411e6
https://github.com/qemu/qemu/commit/3aaebc0cce4a4963f331f45643e17266646411e6
Author: Basil Salman <bsalman@redhat.com>
Date: 2020-07-27 (Mon, 27 Jul 2020)
Changed paths:
M qga/commands-win32.c
Log Message:
-----------
qga-win: fix "guest-get-fsinfo" wrong filesystem type
This patch handles the case where unmounted volumes exist,
where in that case GetVolumePathNamesForVolumeName returns
empty path, GetVolumeInformation will use the current working
directory instead.
This patch fixes the issue by opening a handle to the volumes,
and using GetVolumeInformationByHandleW instead.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1746667
Signed-off-by: Basil Salman <bsalman@redhat.com>
Signed-off-by: Basil Salman <basil@daynix.com>
*fix crash when guest_build_fsinfo() sets errp multiple times
*make new error message more distinct from existing ones
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Commit: ba620541d0db7e3433babbd97c0413a371e6fb4a
https://github.com/qemu/qemu/commit/ba620541d0db7e3433babbd97c0413a371e6fb4a
Author: Thomas Huth <thuth@redhat.com>
Date: 2020-07-27 (Mon, 27 Jul 2020)
Changed paths:
M qga/qapi-schema.json
Log Message:
-----------
qga/qapi-schema: Document -1 for invalid PCI address fields
The "guest-get-fsinfo" could also be used for non-PCI devices in the
future. And the code in GuestPCIAddress() in qga/commands-win32.c seems
to be using "-1" for fields that it can not determine already. Thus
let's properly document "-1" as value for invalid PCI address fields.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Commit: 1e0e0917e5df765575a72afd35a7183e65f505ac
https://github.com/qemu/qemu/commit/1e0e0917e5df765575a72afd35a7183e65f505ac
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2020-07-28 (Tue, 28 Jul 2020)
Changed paths:
M qga/commands-win32.c
M qga/qapi-schema.json
Log Message:
-----------
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-07-27-tag'
into staging
qemu-ga patch queue for hard-freeze
* document use of -1 when pci_controller field can't be retrieved for
guest-get-fsinfo
* fix incorrect filesystem type reporting on w32 for guest-get-fsinfo
when a volume is not mounted
# gpg: Signature made Tue 28 Jul 2020 00:16:50 BST
# gpg: using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg: issuer "mdroth@linux.vnet.ibm.com"
# gpg: Good signature from "Michael Roth <flukshun@gmail.com>" [full]
# gpg: aka "Michael Roth <mdroth@utexas.edu>" [full]
# gpg: aka "Michael Roth <mdroth@linux.vnet.ibm.com>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D 3FA0 3353 C9CE F108 B584
* remotes/mdroth/tags/qga-pull-2020-07-27-tag:
qga/qapi-schema: Document -1 for invalid PCI address fields
qga-win: fix "guest-get-fsinfo" wrong filesystem type
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/264991512193...1e0e0917e5df
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 3aaebc: qga-win: fix "guest-get-fsinfo" wrong filesystem type,
Peter Maydell <=