[Qemu-commits] [qemu/qemu] f81cdd: colo-compare: Remove superfluous NULL-pointer chec...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f81cddfe8abe7d7e2220e611ee69d2cdf34eb789
      
https://github.com/qemu/qemu/commit/f81cddfe8abe7d7e2220e611ee69d2cdf34eb789
  Author: Lukas Straub <lukasstraub2@web.de>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M net/colo-compare.c

  Log Message:
  -----------
  colo-compare: Remove superfluous NULL-pointer checks for s->iothread

s->iothread is checked for NULL on object creation in colo_compare_complete,
so it's guaranteed not to be NULL.
This resolves a false alert from Coverity (CID 1429969).

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>


  Commit: 035e69b063835a5fd23cacabd63690a3d84532a8
      
https://github.com/qemu/qemu/commit/035e69b063835a5fd23cacabd63690a3d84532a8
  Author: Mauro Matteo Cascella <mcascell@redhat.com>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M hw/net/net_tx_pkt.c

  Log Message:
  -----------
  hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()

An assertion failure issue was found in the code that processes network packets
while adding data fragments into the packet context. It could be abused by a
malicious guest to abort the QEMU process on the host. This patch replaces the
affected assert() with a conditional statement, returning false if the current
data fragment exceeds max_raw_frags.

Reported-by: Alexander Bulekov <alxndr@bu.edu>
Reported-by: Ziming Zhang <ezrakiez@gmail.com>
Reviewed-by: Dmitry Fleytman <dmitry.fleytman@gmail.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>


  Commit: bcc983234ba0852729107acca3365ab5359dc0e0
      
https://github.com/qemu/qemu/commit/bcc983234ba0852729107acca3365ab5359dc0e0
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M hw/net/net_tx_pkt.c
    M net/colo-compare.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into 
staging

# gpg: Signature made Tue 04 Aug 2020 07:15:08 BST
# gpg:                using RSA key EF04965B398D6211
# gpg: Good signature from "Jason Wang (Jason Wang on RedHat) 
<jasowang@redhat.com>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 215D 46F4 8246 689E C77F  3562 EF04 965B 398D 6211

* remotes/jasowang/tags/net-pull-request:
  hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()
  colo-compare: Remove superfluous NULL-pointer checks for s->iothread

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5c1c3e4f02e4...bcc983234ba0