qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a8aa94: qga: update schema for guest-get-disk


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a8aa94: qga: update schema for guest-get-disks 'dependents...
Date: Mon, 16 Nov 2020 14:51:53 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a8aa94b5f8427cc2924d8cdd417c8014db1c86c0
      
https://github.com/qemu/qemu/commit/a8aa94b5f8427cc2924d8cdd417c8014db1c86c0
  Author: Michael Roth <michael.roth@amd.com>
  Date:   2020-11-16 (Mon, 16 Nov 2020)

  Changed paths:
    M qga/commands-posix.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: update schema for guest-get-disks 'dependents' field

The recently-added 'guest-get-disk' command returns a list of
GuestDiskInfo entries, which in turn have a 'dependents' field which
lists devices these entries are dependent upon. Thus, 'dependencies'
is a better name for this field. Address this by renaming the field
accordingly.

Additionally, 'dependents' is specified as non-optional, even though
it's not implemented for w32. This is misleading, since it gives users
the impression that a particular disk might not have dependencies,
when in reality that information is simply not known to the guest
agent. Address this by making 'dependents' an optional field, and only
marking it as in-use when the facilities to obtain this information are
available to the guest agent.

Cc: Eric Blake <eblake@redhat.com>
Cc: Tomáš Golembiovský <tgolembi@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>


  Commit: b17d3b7b77f043f0e76f0e6ce6def3c1b1d5ee8b
      
https://github.com/qemu/qemu/commit/b17d3b7b77f043f0e76f0e6ce6def3c1b1d5ee8b
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-16 (Mon, 16 Nov 2020)

  Changed paths:
    M qga/commands-posix.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-11-16-tag' 
into staging

qemu-ga patch queue for hard-freeze

* fixes for schema data-type declarations for guest-get-disks

# gpg: Signature made Mon 16 Nov 2020 19:18:12 GMT
# gpg:                using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg:                issuer "michael.roth@amd.com"
# gpg: Good signature from "Michael Roth <flukshun@gmail.com>" [full]
# gpg:                 aka "Michael Roth <mdroth@utexas.edu>" [full]
# gpg:                 aka "Michael Roth <mdroth@linux.vnet.ibm.com>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D  3FA0 3353 C9CE F108 B584

* remotes/mdroth/tags/qga-pull-2020-11-16-tag:
  qga: update schema for guest-get-disks 'dependents' field

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/cb5ed407a1dd...b17d3b7b77f0



reply via email to

[Prev in Thread] Current Thread [Next in Thread]