[Qemu-commits] [qemu/qemu] 13c59e: target/s390x: fix handling of zeroes in vfmin/vfmax

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 13c59eb09bd6d1fbc13f08b708226421f14a232b
      
https://github.com/qemu/qemu/commit/13c59eb09bd6d1fbc13f08b708226421f14a232b
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M target/s390x/tcg/vec_fpu_helper.c

  Log Message:
  -----------
  target/s390x: fix handling of zeroes in vfmin/vfmax

vfmin_res() / vfmax_res() are trying to check whether a and b are both
zeroes, but in reality they check that they are the same kind of zero.
This causes incorrect results when comparing positive and negative
zeroes.

Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)")
Co-developed-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220713182612.3780050-2-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 63dd7bcbea143814924e2c6f1c01a7d9ca8038f5
      
https://github.com/qemu/qemu/commit/63dd7bcbea143814924e2c6f1c01a7d9ca8038f5
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M fpu/softfloat-specialize.c.inc

  Log Message:
  -----------
  target/s390x: fix NaN propagation rules

s390x has the same NaN propagation rules as ARM, and not as x86.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20220713182612.3780050-3-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 23f13e1986e2ed3a02b65c0bf376c8c61d04ae7a
      
https://github.com/qemu/qemu/commit/23f13e1986e2ed3a02b65c0bf376c8c61d04ae7a
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-07-19 (Tue, 19 Jul 2022)

  Changed paths:
    M tests/tcg/s390x/Makefile.target
    A tests/tcg/s390x/vfminmax.c

  Log Message:
  -----------
  tests/tcg/s390x: test signed vfmin/vfmax

Add a test to prevent regressions. Try all floating point value sizes
and all combinations of floating point value classes. Verify the results
against PoP tables, which are represented as close to the original as
possible - this produces a lot of checkpatch complaints, but it seems
to be justified in this case.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220713182612.3780050-4-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f45fd24c90767240735c6161c39699ad86fc38fa
      
https://github.com/qemu/qemu/commit/f45fd24c90767240735c6161c39699ad86fc38fa
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-20 (Wed, 20 Jul 2022)

  Changed paths:
    M fpu/softfloat-specialize.c.inc
    M target/s390x/tcg/vec_fpu_helper.c
    M tests/tcg/s390x/Makefile.target
    A tests/tcg/s390x/vfminmax.c

  Log Message:
  -----------
  Merge tag 'pull-request-2022-07-20' of https://gitlab.com/thuth/qemu into 
staging

* Fixes for s390x floating point vector instructions

# gpg: Signature made Wed 20 Jul 2022 08:14:50 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-07-20' of https://gitlab.com/thuth/qemu:
  tests/tcg/s390x: test signed vfmin/vfmax
  target/s390x: fix NaN propagation rules
  target/s390x: fix handling of zeroes in vfmin/vfmax

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

# Conflicts:
#       fpu/softfloat-specialize.c.inc


Compare: https://github.com/qemu/qemu/compare/1f64dd76a1bd...f45fd24c9076