[Qemu-commits] [qemu/qemu] b9e607: tests/tcg/linux-test: Fix random hangs in test_socket

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b9e6074fc5b429b1e956e9c60db7e284a91e0f3d
      
https://github.com/qemu/qemu/commit/b9e6074fc5b429b1e956e9c60db7e284a91e0f3d
  Author: Ilya Leoshkevich <iii@linux.ibm.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M tests/tcg/multiarch/linux/linux-test.c

  Log Message:
  -----------
  tests/tcg/linux-test: Fix random hangs in test_socket

test_socket hangs randomly in connect(), especially when run without
qemu. Apparently the reason is that linux started treating backlog
value of 0 literally instead of rounding it up since v4.4 (commit
ef547f2ac16b).

So set it to 1 instead.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20220725144251.192720-1-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 219044b8e63994fedd3ba9d88a33ebcd04c5a029
      
https://github.com/qemu/qemu/commit/219044b8e63994fedd3ba9d88a33ebcd04c5a029
  Author: Peter Xu <peterx@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Use migrate_ensure_converge() for auto-converge

Thomas reported that auto-converge test will timeout on MacOS CI gatings.
Use the migrate_ensure_converge() helper too in the auto-converge as when
Daniel reworked the other test cases.

Since both max_bandwidth / downtime_limit will not be used for converge
calculations, make it simple by removing the remaining check, then we can
completely remove both variables altogether, since migrate_ensure_converge
is used the remaining check won't make much sense anyway.

Reported-by: Thomas Huth <thuth@redhat.com>
Suggested-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20220728133516.92061-2-peterx@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2649a72555e72df56562777ca0c6a46897838eca
      
https://github.com/qemu/qemu/commit/2649a72555e72df56562777ca0c6a46897838eca
  Author: Peter Xu <peterx@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  migration-test: Allow test to run without uffd

We used to stop running all tests if uffd is not detected.  However
logically that's only needed for postcopy not the rest of tests.

Keep running the rest when still possible.

Signed-off-by: Peter Xu <peterx@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220728133516.92061-3-peterx@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: ebf705541c03ba90cb93eef605abd18728e0a25b
      
https://github.com/qemu/qemu/commit/ebf705541c03ba90cb93eef605abd18728e0a25b
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M tests/unit/test-qga.c

  Log Message:
  -----------
  tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

Let's use better, more inclusive wording here.

Message-Id: <20220727092135.302915-4-thuth@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7a21bee2aa52fc95b25e38372678986ee94f05f1
      
https://github.com/qemu/qemu/commit/7a21bee2aa52fc95b25e38372678986ee94f05f1
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M block/linux-aio.c
    M block/qcow2-bitmap.c
    M contrib/plugins/cache.c
    M docs/devel/qom.rst
    M docs/interop/live-block-operations.rst
    M docs/system/arm/cpu-features.rst
    M docs/system/devices/cxl.rst
    M docs/system/s390x/bootdevices.rst
    M docs/system/tls.rst
    M docs/tools/qemu-pr-helper.rst
    M hw/core/clock.c
    M hw/intc/arm_gicv3_redist.c
    M hw/misc/iotkit-secctl.c
    M hw/misc/iotkit-sysctl.c
    M hw/s390x/s390-ccw.c
    M hw/usb/u2f.h
    M include/hw/qdev-core.h
    M include/user/safe-syscall.h
    M linux-user/i386/cpu_loop.c
    M pc-bios/s390-ccw/virtio-scsi.c
    M python/Makefile
    M python/qemu/utils/__init__.py
    M target/arm/translate.c
    M target/i386/cpu.c
    M tcg/i386/tcg-target.c.inc
    M tests/qtest/microbit-test.c
    M tools/virtiofsd/fuse_virtio.c

  Log Message:
  -----------
  misc: fix commonly doubled up words

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220707163720.1421716-5-berrange@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: a07d9df0fd9d449c0271e2fe358e472bc7efefc2
      
https://github.com/qemu/qemu/commit/a07d9df0fd9d449c0271e2fe358e472bc7efefc2
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M hw/arm/omap2.c
    M hw/misc/mac_via.c
    M target/arm/helper.c
    M tests/docker/dockerfiles/debian-native.docker
    M ui/vdagent.c

  Log Message:
  -----------
  trivial: Fix duplicated words

Some files wrongly contain the same word twice in a row.
One of them should be removed or replaced.

Message-Id: <20220722145859.1952732-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 1bca64a3f0490861c03ceb849821ebf42c926f82
      
https://github.com/qemu/qemu/commit/1bca64a3f0490861c03ceb849821ebf42c926f82
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M tests/qtest/migration-test.c

  Log Message:
  -----------
  tests/qtest/migration-test: Run the dirty ring tests only with the x86 target

kvm_dirty_ring_supported() only checks whether the dirty ring support
is available on the x86 host, but it ignores whether the target QEMU
architecture is x86 or not. Thus the test_vcpu_dirty_limit() test
currently fails with the assert((strcmp(arch, "x86_64") == 0)) statement
in dirtylimit_start_vm() if the users run e.g. "make check-qtest-aarch64"
on their x86 host. Fix it by only executing the tests when we're running
with a x86_64 target QEMU binary with KVM.

Message-Id: <20220801114644.208197-1-thuth@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b15bdb1d8324efe662b94d5c8bac231c4b3a81a9
      
https://github.com/qemu/qemu/commit/b15bdb1d8324efe662b94d5c8bac231c4b3a81a9
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-08-01 (Mon, 01 Aug 2022)

  Changed paths:
    M block/linux-aio.c
    M block/qcow2-bitmap.c
    M contrib/plugins/cache.c
    M docs/devel/qom.rst
    M docs/interop/live-block-operations.rst
    M docs/system/arm/cpu-features.rst
    M docs/system/devices/cxl.rst
    M docs/system/s390x/bootdevices.rst
    M docs/system/tls.rst
    M docs/tools/qemu-pr-helper.rst
    M hw/arm/omap2.c
    M hw/core/clock.c
    M hw/intc/arm_gicv3_redist.c
    M hw/misc/iotkit-secctl.c
    M hw/misc/iotkit-sysctl.c
    M hw/misc/mac_via.c
    M hw/s390x/s390-ccw.c
    M hw/usb/u2f.h
    M include/hw/qdev-core.h
    M include/user/safe-syscall.h
    M linux-user/i386/cpu_loop.c
    M pc-bios/s390-ccw/virtio-scsi.c
    M python/Makefile
    M python/qemu/utils/__init__.py
    M target/arm/helper.c
    M target/arm/translate.c
    M target/i386/cpu.c
    M tcg/i386/tcg-target.c.inc
    M tests/docker/dockerfiles/debian-native.docker
    M tests/qtest/microbit-test.c
    M tests/qtest/migration-test.c
    M tests/tcg/multiarch/linux/linux-test.c
    M tests/unit/test-qga.c
    M tools/virtiofsd/fuse_virtio.c
    M ui/vdagent.c

  Log Message:
  -----------
  Merge tag 'pull-request-2022-08-01' of https://gitlab.com/thuth/qemu into 
staging

- Some fixes for various tests
- Improve wordings in some files

# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmLn6aYRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbWekg/+NVIT1jp3tcbfPIE6pB0vI/AhqN3i2hUd
# zfJ4V3rSe5tg54JpmuuSt542mp4BDM9bPfYcY/DYESWEtW0c9wv80iP/5LFdJF0G
# GYtk7Q4pRXvB32kF0v9OxjCEGPUeEqSRrDrsI/Ify5evEIhr55oHPnDjN/US1Bx+
# TIuVfmyz8jhSPHsUvZzfVyFxkHre1+BWDxgM3zxoHFIaWEscIPE1KhwRILbKIxWx
# MHpL8JLAneGFwljQoUAMCl7GzHkVna59RhqkbBJ+8iTaNGipQj9FhHZBo2CulO0J
# SR7scWowYN8Jt2FNMe3tcKM2xQn/2Fg2TEK4sp6q+hCXhJuvFfWFHBiFYTNpagFA
# LGgZmPfDr4uZtMEqY4AdEZdL14YZcoM9E/RpW7GhSvMHy73wOj16O8luH1bU0jtG
# 6X1VvAZlw8/Son1Tbq2CC6WejlMfJFXSzF6Fy6M7SflMPW44vJOs5uKdW405MYjE
# Pksbfz1rwoNfK+1qBNQop7SccgDRvPtlLf3lDAU9V/JHWVEITs1KTfyS+46U8jKA
# 9SVBzKuTpVd+aXvMgvMAmmqnyvUBPHJ9KcFq4vHNbIETsGaQsXu0Q6waBmpcK8YB
# KUL/g0EsdfhkpVVgKYZ4Bzj7shG6SKTdwc/lUcOt+wQuDrZZzaC+A2cu/6ReQN6T
# BIHtoaxTz8E=
# =K6RW
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 01 Aug 2022 07:56:38 AM PDT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [undefined]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [undefined]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2022-08-01' of https://gitlab.com/thuth/qemu:
  tests/qtest/migration-test: Run the dirty ring tests only with the x86 target
  trivial: Fix duplicated words
  misc: fix commonly doubled up words
  tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test
  migration-test: Allow test to run without uffd
  migration-test: Use migrate_ensure_converge() for auto-converge
  tests/tcg/linux-test: Fix random hangs in test_socket

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/6427adc30063...b15bdb1d8324