qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] fb96d1: hw/net/can: fix Xilinx ZynqMP CAN RX


From: Paolo Bonzini
Subject: [Qemu-commits] [qemu/qemu] fb96d1: hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic
Date: Mon, 26 Sep 2022 12:23:14 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fb96d131eec66ecb2993c544058a8cb2c9c3521f
      
https://github.com/qemu/qemu/commit/fb96d131eec66ecb2993c544058a8cb2c9c3521f
  Author: Anton Kochkov <anton.kochkov@proton.me>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/net/can/xlnx-zynqmp-can.c

  Log Message:
  -----------
  hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic

For consistency, function "update_rx_fifo()" should use the RX FIFO
register field names, not the TX FIFO ones, even if they refer to the
same bit positions in the register.

Signed-off-by: Anton Kochkov <anton.kochkov@proton.me>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Message-id: 20220817141754.2105981-1-anton.kochkov@proton.me
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1123
[PMM: tweaked commit message]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 3a661024cc680104ce2cd21f8f5466dacba6f405
      
https://github.com/qemu/qemu/commit/3a661024cc680104ce2cd21f8f5466dacba6f405
  Author: Clément Chigot <chigot@adacore.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/translate-neon.c

  Log Message:
  -----------
  target/arm: Fix alignment for VLD4.32

When requested, the alignment for VLD4.32 is 8 and not 16.

See ARM documentation about VLD4 encoding:
    ebytes = 1 << UInt(size);
    if size == '10' then
        alignment = if a == '0' then 1 else 8;
    else
        alignment = if a == '0' then 1 else 4*ebytes;

Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220914105058.2787404-1-chigot@adacore.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: de05a709ec2b3ddf7a739d85ef8cdd9d5a02b6e1
      
https://github.com/qemu/qemu/commit/de05a709ec2b3ddf7a739d85ef8cdd9d5a02b6e1
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/helper.c
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c
    M target/arm/tlb_helper.c

  Log Message:
  -----------
  target/arm: Create GetPhysAddrResult

Combine 5 output pointer arguments from get_phys_addr
into a single struct.  Adjust all callers.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-2-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 03ee9bbe702a471a03c9a0f5c9b924e257d1001b
      
https://github.com/qemu/qemu/commit/03ee9bbe702a471a03c9a0f5c9b924e257d1001b
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_lpae

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-4-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 60a6a180b1694ee7452266d05f71c8feb8ea8383
      
https://github.com/qemu/qemu/commit/60a6a180b1694ee7452266d05f71c8feb8ea8383
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_v6

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-5-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 51d98ce2cbfcea8fc14d5b05736f782ecae499d3
      
https://github.com/qemu/qemu/commit/51d98ce2cbfcea8fc14d5b05736f782ecae499d3
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_v5

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-6-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: b7b9b579cf616e3a933e833462e50ad5b4e36d75
      
https://github.com/qemu/qemu/commit/b7b9b579cf616e3a933e833462e50ad5b4e36d75
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav5

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-7-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: e59367e2ef998a4e0cb1f123861a56fc288d5620
      
https://github.com/qemu/qemu/commit/e59367e2ef998a4e0cb1f123861a56fc288d5620
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav7

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-8-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 5272b23e2e525d50ab5a507632b26cc67f1f6daf
      
https://github.com/qemu/qemu/commit/5272b23e2e525d50ab5a507632b26cc67f1f6daf
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in get_phys_addr_pmsav8

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-9-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: d2c92e585619516d7d29d38de3acba206806e64c
      
https://github.com/qemu/qemu/commit/d2c92e585619516d7d29d38de3acba206806e64c
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Use GetPhysAddrResult in pmsav8_mpu_lookup

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-10-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 652c750ee5c57ba3bbaf32e5ebb77fbbc8f68385
      
https://github.com/qemu/qemu/commit/652c750ee5c57ba3bbaf32e5ebb77fbbc8f68385
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Remove is_subpage argument to pmsav8_mpu_lookup

This can be made redundant with result->page_size, by moving the basic
set of page_size from get_phys_addr_pmsav8.  We still need to overwrite
page_size when v8m_security_lookup signals a subpage.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-11-richard.henderson@linaro.org
[PMM: Update a comment that used to refer to is_subpage]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: dbf2a71ad62b99286adf6cdc6d6c12cdb26306a9
      
https://github.com/qemu/qemu/commit/dbf2a71ad62b99286adf6cdc6d6c12cdb26306a9
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add is_secure parameter to v8m_security_lookup

Remove the use of regime_is_secure from v8m_security_lookup,
passing the new parameter to the lookup instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-12-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: e9fb709041d7866fca33de0848a3d43092e42512
      
https://github.com/qemu/qemu/commit/e9fb709041d7866fca33de0848a3d43092e42512
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add secure parameter to pmsav8_mpu_lookup

Remove the use of regime_is_secure from pmsav8_mpu_lookup,
passing the new parameter to the lookup instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-13-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: b29c85d50c7069ddf53187860e18f9dce824f590
      
https://github.com/qemu/qemu/commit/b29c85d50c7069ddf53187860e18f9dce824f590
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add is_secure parameter to get_phys_addr_v5

Remove the use of regime_is_secure from get_phys_addr_v5,
passing the new parameter to the lookup instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
[PMM: Folded in definition of local is_secure in get_phys_addr(),
 since I dropped the earlier patch that would have provided it]
Message-id: 20220822152741.1617527-14-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 71e73beb5101f0999f1a1440a3c544b24cb71430
      
https://github.com/qemu/qemu/commit/71e73beb5101f0999f1a1440a3c544b24cb71430
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add is_secure parameter to get_phys_addr_v6

Remove the use of regime_is_secure from get_phys_addr_v6,
passing the new parameter to the lookup instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-15-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: be0ca9485d6aeb3a9d9cae36f5e5b8fe1de9440b
      
https://github.com/qemu/qemu/commit/be0ca9485d6aeb3a9d9cae36f5e5b8fe1de9440b
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add secure parameter to get_phys_addr_pmsav8

Remove the use of regime_is_secure from get_phys_addr_pmsav8.
Since we already had a local variable named secure, use that.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-16-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 1a469cf78d45a711fb5fce3cbbb325917d17895a
      
https://github.com/qemu/qemu/commit/1a469cf78d45a711fb5fce3cbbb325917d17895a
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add is_secure parameter to pmsav7_use_background_region

Remove the use of regime_is_secure from pmsav7_use_background_region,
using the new parameter instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-17-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 957a0bb751e9b87c85118a2f55871d981df78d20
      
https://github.com/qemu/qemu/commit/957a0bb751e9b87c85118a2f55871d981df78d20
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add secure parameter to get_phys_addr_pmsav7

Remove the use of regime_is_secure from get_phys_addr_pmsav7,
using the new parameter instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-19-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: a5b5092f66fc93c49e24c043d5e0589150a6c352
      
https://github.com/qemu/qemu/commit/a5b5092f66fc93c49e24c043d5e0589150a6c352
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M target/arm/ptw.c

  Log Message:
  -----------
  target/arm: Add is_secure parameter to get_phys_addr_pmsav5

Remove the use of regime_is_secure from get_phys_addr_pmsav5.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220822152741.1617527-21-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: d4424bebceaa8ffbc23060ce45e52a9bb817e3c9
      
https://github.com/qemu/qemu/commit/d4424bebceaa8ffbc23060ce45e52a9bb817e3c9
  Author: Keqian Zhu <zhukeqian1@huawei.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/acpi/generic_event_device.c

  Log Message:
  -----------
  hw/acpi: Add ospm_status hook implementation for acpi-ged

Setup an ARM virtual machine of machine virt and execute qmp 
"query-acpi-ospm-status"
causes segmentation fault with following dumpstack:
 #1  0x0000aaaaab64235c in qmp_query_acpi_ospm_status 
(errp=errp@entry=0xfffffffff030) at ../monitor/qmp-cmds.c:312
 #2  0x0000aaaaabfc4e20 in qmp_marshal_query_acpi_ospm_status (args=<optimized 
out>, ret=0xffffea4ffe90, errp=0xffffea4ffe88) at qapi/qapi-commands-acpi.c:63
 #3  0x0000aaaaabff8ba0 in do_qmp_dispatch_bh (opaque=0xffffea4ffe98) at 
../qapi/qmp-dispatch.c:128
 #4  0x0000aaaaac02e594 in aio_bh_call (bh=0xffffe0004d80) at 
../util/async.c:150
 #5  aio_bh_poll (ctx=ctx@entry=0xaaaaad0f6040) at ../util/async.c:178
 #6  0x0000aaaaac00bd40 in aio_dispatch (ctx=ctx@entry=0xaaaaad0f6040) at 
../util/aio-posix.c:421
 #7  0x0000aaaaac02e010 in aio_ctx_dispatch (source=0xaaaaad0f6040, 
callback=<optimized out>, user_data=<optimized out>) at ../util/async.c:320
 #8  0x0000fffff76f6884 in g_main_context_dispatch () at 
/usr/lib64/libglib-2.0.so.0
 #9  0x0000aaaaac0452d4 in glib_pollfds_poll () at ../util/main-loop.c:297
 #10 os_host_main_loop_wait (timeout=0) at ../util/main-loop.c:320
 #11 main_loop_wait (nonblocking=nonblocking@entry=0) at ../util/main-loop.c:596
 #12 0x0000aaaaab5c9e50 in qemu_main_loop () at ../softmmu/runstate.c:734
 #13 0x0000aaaaab185370 in qemu_main (argc=argc@entry=47, 
argv=argv@entry=0xfffffffff518, envp=envp@entry=0x0) at ../softmmu/main.c:38
 #14 0x0000aaaaab16f99c in main (argc=47, argv=0xfffffffff518) at 
../softmmu/main.c:47

Fixes: ebb62075021a ("hw/acpi: Add ACPI Generic Event Device Support")
Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-id: 20220816094957.31700-1-zhukeqian1@huawei.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 895a803ce91704f28c9b49621a4f589273289f1e
      
https://github.com/qemu/qemu/commit/895a803ce91704f28c9b49621a4f589273289f1e
  Author: Lucas Dietrich <ld.adecy@gmail.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/net/lan9118.c

  Log Message:
  -----------
  hw/net/lan9118: Signal TSFL_INT flag when TX FIFO reaches specified level

The LAN9118 allows the guest to specify a level for both the TX and
RX FIFOs at which an interrupt will be generated.  We implement the
RSFL_INT interrupt for the RX FIFO but are missing the handling of
the equivalent TSFL_INT for the TX FIFO.  Add the missing test to set
the interrupt if the TX FIFO has exceeded the guest-specified level.

This flag is required for Micrium lan911x ethernet driver to work.

Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com>
[PMM: Tweaked commit message and comment]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: f63a6e381c48b796c3964accaa88c0d0e229b17f
      
https://github.com/qemu/qemu/commit/f63a6e381c48b796c3964accaa88c0d0e229b17f
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M chardev/baum.c

  Log Message:
  -----------
  chardev/baum: Replace magic values by X_MAX / Y_MAX definitions

Replace '84' magic value by the X_MAX definition, and '1' by Y_MAX.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-2-peter.maydell@linaro.org


  Commit: 1e3acd33576c695262a09262c9319d44a01b11e7
      
https://github.com/qemu/qemu/commit/1e3acd33576c695262a09262c9319d44a01b11e7
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M chardev/baum.c

  Log Message:
  -----------
  chardev/baum: Use definitions to avoid dynamic stack allocation

We know 'x * y' will be at most 'X_MAX * Y_MAX' (which is not
a big value, it is actually 84). Instead of having the compiler
use variable-length array, declare an array able to hold the
maximum 'x * y'.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-3-peter.maydell@linaro.org


  Commit: d34977d682e382fb2af83e6e6508e3b06d1a3cf2
      
https://github.com/qemu/qemu/commit/d34977d682e382fb2af83e6e6508e3b06d1a3cf2
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M chardev/baum.c

  Log Message:
  -----------
  chardev/baum: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-4-peter.maydell@linaro.org


  Commit: 5e689840a10e01dc2ab87defc5347337db8103da
      
https://github.com/qemu/qemu/commit/5e689840a10e01dc2ab87defc5347337db8103da
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M io/channel-websock.c

  Log Message:
  -----------
  io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1

The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in
qio_channel_websock_handshake_send_res_ok() expands to a call
to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't
realize the string is const, so consider combined_key[] being
a variable-length array.

To remove the variable-length array, we provide it a hint to
the compiler by using sizeof() - 1 instead of strlen().

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-5-peter.maydell@linaro.org


  Commit: c140a69055bad798a335ea3c83aebceaca82bde0
      
https://github.com/qemu/qemu/commit/c140a69055bad798a335ea3c83aebceaca82bde0
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/net/e1000e_core.c

  Log Message:
  -----------
  hw/net/e1000e_core: Use definition to avoid dynamic stack allocation

The compiler isn't clever enough to figure 'min_buf_size'
is a constant, so help it by using a definitions instead.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-6-peter.maydell@linaro.org


  Commit: a580fdcd609e1db77ef5a1cbcbfd2af5ca05c939
      
https://github.com/qemu/qemu/commit/a580fdcd609e1db77ef5a1cbcbfd2af5ca05c939
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/ppc/pnv.c
    M hw/ppc/spapr.c
    M hw/ppc/spapr_pci_nvlink2.c

  Log Message:
  -----------
  hw/ppc/pnv: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-id: 20220819153931.3147384-7-peter.maydell@linaro.org


  Commit: 7650c8fe520c67c3b36f6962c4ad990f56ad40b8
      
https://github.com/qemu/qemu/commit/7650c8fe520c67c3b36f6962c4ad990f56ad40b8
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/intc/xics.c

  Log Message:
  -----------
  hw/intc/xics: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-8-peter.maydell@linaro.org


  Commit: fa87341dabebe79d2e5577432a98b83c9eddf968
      
https://github.com/qemu/qemu/commit/fa87341dabebe79d2e5577432a98b83c9eddf968
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/i386/multiboot.c

  Log Message:
  -----------
  hw/i386/multiboot: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length array on
the stack. Replace the snprintf() call by g_strdup_printf().

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-9-peter.maydell@linaro.org


  Commit: 29d81e429d16fe8f0f1cd99e63507ca53ca1945c
      
https://github.com/qemu/qemu/commit/29d81e429d16fe8f0f1cd99e63507ca53ca1945c
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M hw/usb/hcd-ohci.c

  Log Message:
  -----------
  hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation

The compiler isn't clever enough to figure 'width' is a constant,
so help it by using a definitions instead.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-10-peter.maydell@linaro.org


  Commit: 2d5f4a713d27f2b218b0c5abfa9833953da108d9
      
https://github.com/qemu/qemu/commit/2d5f4a713d27f2b218b0c5abfa9833953da108d9
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M ui/curses.c

  Log Message:
  -----------
  ui/curses: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-11-peter.maydell@linaro.org


  Commit: 972d325a8dc855aa3817d0df9e09fd556a0449f7
      
https://github.com/qemu/qemu/commit/972d325a8dc855aa3817d0df9e09fd556a0449f7
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M tests/unit/test-vmstate.c

  Log Message:
  -----------
  tests/unit/test-vmstate: Avoid dynamic stack allocation

Use autofree heap allocation instead of variable-length
array on the stack.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-12-peter.maydell@linaro.org


  Commit: 342cf3041394916c9e6d6f23c27f62093a97a834
      
https://github.com/qemu/qemu/commit/342cf3041394916c9e6d6f23c27f62093a97a834
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Remove unused python_version variable

Shellcheck correctly reports that we set python_version and never use
it.  This is a leftover from commit f9332757898a7: we used to use
python_version purely to as part of the summary information printed
at the end of a configure run, and that commit changed to printing
the information from meson (which looks up the python version
itself). Remove the unused variable.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-2-peter.maydell@linaro.org


  Commit: cbbc44d8efc57f4a07fada20740dfa9ef55b4fbc
      
https://github.com/qemu/qemu/commit/cbbc44d8efc57f4a07fada20740dfa9ef55b4fbc
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Remove unused meson_args variable

The meson_args variable was added in commit 3b4da13293482134b, but
was not used in that commit and isn't used today.  Delete the
unnecessary assignment.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-3-peter.maydell@linaro.org


  Commit: 64708615e7c4748a6487f3c078dfac71061be01f
      
https://github.com/qemu/qemu/commit/64708615e7c4748a6487f3c078dfac71061be01f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Add missing quoting for some easy cases

This commit adds quotes in some places which:
 * are spotted by shellcheck
 * are obviously incorrect
 * are easy to fix just by adding the quotes

It doesn't attempt fix all of the places shellcheck finds errors,
or even all the ones which are easy to fix. It's just a random
sampling which is hopefully easy to review and which cuts
down the size of the problem for next time somebody wants to
try to look at shellcheck errors.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-4-peter.maydell@linaro.org


  Commit: 002d8c13df9f28bd3112edc1c1159b6d762d130f
      
https://github.com/qemu/qemu/commit/002d8c13df9f28bd3112edc1c1159b6d762d130f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Add './' on front of glob of */config-devices.mak.d

Shellcheck warns that in
 rm -f */config-devices.mak.d
the glob might expand to something with a '-' in it, which would
then be misinterpreted as an option to rm. Fix this by adding './'.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-5-peter.maydell@linaro.org


  Commit: cc3c71e89f0b1b18024030976fda650d27806c9f
      
https://github.com/qemu/qemu/commit/cc3c71e89f0b1b18024030976fda650d27806c9f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Remove use of backtick `...` syntax

There's only one place in configure where we use `...` to execute a
command and capture the result.  Switch to $() to match the rest of
the script. This silences a shellcheck warning.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-6-peter.maydell@linaro.org


  Commit: 563661c05677ad7c4b3f956507f3529df42afbf7
      
https://github.com/qemu/qemu/commit/563661c05677ad7c4b3f956507f3529df42afbf7
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Check mkdir result directly, not via $?

Shellcheck warns that we have one place where we run a command and
then check if it failed using $?; this is better written to simply
check the command in the 'if' statement directly.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-7-peter.maydell@linaro.org


  Commit: b3b5472db0ab7a53499441c1fe1dedec05b1e285
      
https://github.com/qemu/qemu/commit/b3b5472db0ab7a53499441c1fe1dedec05b1e285
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Avoid use of 'local' as it is non-POSIX

We use the non-POSIX 'local' keyword in just two places in configure;
rewrite to avoid it.

In do_compiler(), just drop the 'local' keyword.  The variable
'compiler' is only used elsewhere in the do_compiler_werror()
function, which already uses the variable as a normal non-local one.

In probe_target_compiler(), $try and $t are both local; make them
normal variables and use a more obviously distinct variable name
for $t.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-8-peter.maydell@linaro.org


  Commit: 99d6b11b5b44d7dd64f4cb1973184e40a4a174f8
      
https://github.com/qemu/qemu/commit/99d6b11b5b44d7dd64f4cb1973184e40a4a174f8
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2022-09-26 (Mon, 26 Sep 2022)

  Changed paths:
    M chardev/baum.c
    M configure
    M hw/acpi/generic_event_device.c
    M hw/i386/multiboot.c
    M hw/intc/xics.c
    M hw/net/can/xlnx-zynqmp-can.c
    M hw/net/e1000e_core.c
    M hw/net/lan9118.c
    M hw/ppc/pnv.c
    M hw/ppc/spapr.c
    M hw/ppc/spapr_pci_nvlink2.c
    M hw/usb/hcd-ohci.c
    M io/channel-websock.c
    M target/arm/helper.c
    M target/arm/internals.h
    M target/arm/m_helper.c
    M target/arm/ptw.c
    M target/arm/tlb_helper.c
    M target/arm/translate-neon.c
    M tests/unit/test-vmstate.c
    M ui/curses.c

  Log Message:
  -----------
  Merge tag 'pull-target-arm-20220922' of 
https://git.linaro.org/people/pmaydell/qemu-arm into staging

target-arm queue:
 * hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic
 * Fix alignment for Neon VLD4.32
 * Refactoring of page-table-walk code
 * hw/acpi: Add ospm_status hook implementation for acpi-ged
 * hw/net/lan9118: Signal TSFL_INT flag when TX FIFO reaches specified level
 * chardev/baum: avoid variable-length arrays
 * io/channel-websock: avoid variable-length arrays
 * hw/net/e1000e_core: Use definition to avoid dynamic stack allocation
 * hw/ppc/pnv: Avoid dynamic stack allocation
 * hw/intc/xics: Avoid dynamic stack allocation
 * hw/i386/multiboot: Avoid dynamic stack allocation
 * hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
 * ui/curses: Avoid dynamic stack allocation
 * tests/unit/test-vmstate: Avoid dynamic stack allocation
 * configure: fix various shellcheck-spotted issues and nits

# -----BEGIN PGP SIGNATURE-----
#
# iQJNBAABCAA3FiEE4aXFk81BneKOgxXPPCUl7RQ2DN4FAmMsjocZHHBldGVyLm1h
# eWRlbGxAbGluYXJvLm9yZwAKCRA8JSXtFDYM3s0vEACuUs7nGGX5vd96EPN+sO5s
# HstP16G6/Xnlw2z0BaXi0MMWapQRhSQJ+MIeDJmqIyZKQ3geJGP7pbFTxI3zreYM
# UTKjdI/wWRYMKPYfxlIBZ8TPugj4a4paFJlyqmpHXtkwiWRv6rF70HQ9Yku5id93
# FN9js/dyF74S2AaDppBuTWp31cM1k6kBTg/v5tXSxE8kDUKkO+HZ1VujOqIG/4nJ
# 6urNJ7jlHSiFdXya2QiR+CAkyXyy551rLETeO8VJg9tOO7Ys7Olj7lqv6kHJY/X1
# 01RbN5A5WXhqCvTLM3UYTvFHmbZtS/C5iUhHRtlZkOoeSv2jS6IRDB8BrBtIbOwF
# XKpaYf1jyFLFwX++hpvySD9Vbcu8KgKId8iKTuDcxjQlEjL3fTbt1ulKo4y+rJ8O
# 6G1k4yZc8/nAvttNoKCn7/Jr1dC+HsANa+1s1L+6w+f1gARV0VXs4gqsveNnbe1+
# WzzaHvHt+hCaiWkSZlyisyw3fbEXMrEyKewi+SZu3c8PvJ6DHa+rYjkhem7muBVF
# iR48FRTjFiS+o402KMwXfMdiGjXyZFi09yn5diowlVjkNAaZVZfgu/wUMD5QBhbh
# fNDSw7LpXGUHML/O98MiXznkgGvTEQNxZdp2qIQrTiinUgmV4ZRLR23ZpEibdJPX
# kiOkr46SbWvksCXnRlTf8w==
# =hec8
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 22 Sep 2022 12:34:15 EDT
# gpg:                using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE
# gpg:                issuer "peter.maydell@linaro.org"
# gpg: Good signature from "Peter Maydell <peter.maydell@linaro.org>" [full]
# gpg:                 aka "Peter Maydell <pmaydell@gmail.com>" [full]
# gpg:                 aka "Peter Maydell <pmaydell@chiark.greenend.org.uk>" 
[full]
# gpg:                 aka "Peter Maydell <peter@archaic.org.uk>" [unknown]
# Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83  15CF 3C25 25ED 1436 0CDE

* tag 'pull-target-arm-20220922' of 
https://git.linaro.org/people/pmaydell/qemu-arm: (39 commits)
  configure: Avoid use of 'local' as it is non-POSIX
  configure: Check mkdir result directly, not via $?
  configure: Remove use of backtick `...` syntax
  configure: Add './' on front of glob of */config-devices.mak.d
  configure: Add missing quoting for some easy cases
  configure: Remove unused meson_args variable
  configure: Remove unused python_version variable
  tests/unit/test-vmstate: Avoid dynamic stack allocation
  ui/curses: Avoid dynamic stack allocation
  hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
  hw/i386/multiboot: Avoid dynamic stack allocation
  hw/intc/xics: Avoid dynamic stack allocation
  hw/ppc/pnv: Avoid dynamic stack allocation
  hw/net/e1000e_core: Use definition to avoid dynamic stack allocation
  io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1
  chardev/baum: Avoid dynamic stack allocation
  chardev/baum: Use definitions to avoid dynamic stack allocation
  chardev/baum: Replace magic values by X_MAX / Y_MAX definitions
  hw/net/lan9118: Signal TSFL_INT flag when TX FIFO reaches specified level
  hw/acpi: Add ospm_status hook implementation for acpi-ged
  ...

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Compare: https://github.com/qemu/qemu/compare/6160d8ff81fb...99d6b11b5b44



reply via email to

[Prev in Thread] Current Thread [Next in Thread]