[Qemu-commits] [qemu/qemu] 0d57cd: Hexagon (tests/tcg/hexagon) Clean up Hexagon check...

[Richard Henderson]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0d57cd61d95fbbe86a1ce3b2ef2f8f1254b4116a
      
https://github.com/qemu/qemu/commit/0d57cd61d95fbbe86a1ce3b2ef2f8f1254b4116a
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M tests/tcg/hexagon/Makefile.target
    M tests/tcg/hexagon/atomics.c
    M tests/tcg/hexagon/brev.c
    M tests/tcg/hexagon/circ.c
    M tests/tcg/hexagon/dual_stores.c
    M tests/tcg/hexagon/fpstuff.c
    M tests/tcg/hexagon/hex_sigsegv.c
    A tests/tcg/hexagon/hex_test.h
    M tests/tcg/hexagon/load_align.c
    M tests/tcg/hexagon/load_unpack.c
    M tests/tcg/hexagon/mem_noshuf.c
    M tests/tcg/hexagon/mem_noshuf_exception.c
    M tests/tcg/hexagon/misc.c
    M tests/tcg/hexagon/multi_result.c
    M tests/tcg/hexagon/overflow.c
    M tests/tcg/hexagon/preg_alias.c
    M tests/tcg/hexagon/read_write_overlap.c
    M tests/tcg/hexagon/reg_mut.c
    M tests/tcg/hexagon/usr.c

  Log Message:
  -----------
  Hexagon (tests/tcg/hexagon) Clean up Hexagon check-tcg tests

Move test infra to header file
    check functions (always print line number on error)
    USR manipulation
    Useful floating point values
Use stdint.h types
Use stdbool.h bool where appropriate
Use trip counts local to for loop

Suggested-by: Anton Johansson <anjo@rev.ng>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Tested-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230522174341.1805460-1-tsimpson@quicinc.com>


  Commit: 3fd49e22171a019beebffdda081380a5276525a6
      
https://github.com/qemu/qemu/commit/3fd49e22171a019beebffdda081380a5276525a6
  Author: Marco Liebel <quic_mliebel@quicinc.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M target/hexagon/mmvec/decode_ext_mmvec.c
    M tests/tcg/hexagon/hvx_misc.c

  Log Message:
  -----------
  Hexagon (target/hexagon) Fix assignment to tmp registers

The order in which instructions are generated by gen_insn() influences
assignment to tmp registers. During generation, tmp instructions (e.g.
generate_V6_vassign_tmp) use vreg_src_off() to determine what kind of
register to use as source. If some instruction (e.g.
generate_V6_vmpyowh_64_acc) uses a tmp register but is generated prior
to the corresponding tmp instruction, the vregs_updated_tmp bit map
isn't updated in time.

Exmple:
    { v14.tmp = v16; v25 = v14 } This works properly because
    generate_V6_vassign_tmp is generated before generate_V6_vassign
    and the bit map is updated.

    { v15:14.tmp = vcombine(v21, v16); v25:24 += vmpyo(v18.w,v14.h) }
    This does not work properly because vmpyo is generated before
    vcombine and therefore the bit map does not yet know that there's
    a tmp register.

The parentheses in the decoding function were in the wrong place.
Moving them to the correct location makes shuffling of .tmp vector
registers work as expected.

Signed-off-by: Marco Liebel <quic_mliebel@quicinc.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Message-Id: <20230522174708.464197-1-quic_mliebel@quicinc.com>


  Commit: 3608c2419c95e7477dd282bb1268c78029501df8
      
https://github.com/qemu/qemu/commit/3608c2419c95e7477dd282bb1268c78029501df8
  Author: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M target/hexagon/gen_analyze_funcs.py
    M target/hexagon/gen_helper_funcs.py
    M target/hexagon/gen_helper_protos.py
    M target/hexagon/gen_idef_parser_funcs.py
    M target/hexagon/gen_op_regs.py
    M target/hexagon/gen_tcg_funcs.py
    M target/hexagon/hex_common.py

  Log Message:
  -----------
  target/hexagon/*.py: clean up used 'toss' and 'numregs' vars

Many Hexagon python scripts call hex_common.get_tagregs(), but only one
call site use the full reg structure given by this function. To make the
code cleaner, let's make get_tagregs() filter out the unused fields
(i.e. 'toss' and 'numregs'), properly removed the unused variables at
the call sites. The hex_common.bad_register() function is also adjusted
to work exclusively with 'regtype' and 'regid' args. For the single call
site that does use toss/numregs, we provide an optional parameter to
get_tagregs() which will restore the old full behavior.

Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: 
<3ffd4ccb972879f57f499705c624e8eaba7f8b52.1684939078.git.quic_mathbern@quicinc.com>


  Commit: 2babbd93904721c538148a497ad5d5aa6cd2e1ef
      
https://github.com/qemu/qemu/commit/2babbd93904721c538148a497ad5d5aa6cd2e1ef
  Author: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M target/hexagon/genptr.c
    M target/hexagon/translate.c

  Log Message:
  -----------
  Hexagon: fix outdated `hex_new_*` comments

Some code comments refer to hex_new_value and hex_new_pred_value, which
have been transferred to DisasContext and, in the case of hex_new_value,
should now be accessed through get_result_gpr().

In order to fix this outdated comments and also avoid having to tweak
them whenever we make a variable name change in the future, let's
replace them with pseudocode.

Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: 
<8e1689e28dd7b1318369b55127cf47b82ab75921.1684939078.git.quic_mathbern@quicinc.com>


  Commit: 7d196e2196d50e0dda0f87f396d4f4a7ad9aafbe
      
https://github.com/qemu/qemu/commit/7d196e2196d50e0dda0f87f396d4f4a7ad9aafbe
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M .mailmap
    M MAINTAINERS

  Log Message:
  -----------
  Hexagon (target/hexagon) Change Hexagon maintainer

Change Hexagon maintainer from Taylor Simpson to Brian Cain
Put Taylor's gmail address in .mailmap

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org
Message-Id: <20230524165355.3157700-2-tsimpson@quicinc.com>


  Commit: 9c9fff18c45b54fd9adf2282323aab1b6f0ec866
      
https://github.com/qemu/qemu/commit/9c9fff18c45b54fd9adf2282323aab1b6f0ec866
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2023-05-26 (Fri, 26 May 2023)

  Changed paths:
    M .mailmap
    M MAINTAINERS
    M target/hexagon/gen_analyze_funcs.py
    M target/hexagon/gen_helper_funcs.py
    M target/hexagon/gen_helper_protos.py
    M target/hexagon/gen_idef_parser_funcs.py
    M target/hexagon/gen_op_regs.py
    M target/hexagon/gen_tcg_funcs.py
    M target/hexagon/genptr.c
    M target/hexagon/hex_common.py
    M target/hexagon/mmvec/decode_ext_mmvec.c
    M target/hexagon/translate.c
    M tests/tcg/hexagon/Makefile.target
    M tests/tcg/hexagon/atomics.c
    M tests/tcg/hexagon/brev.c
    M tests/tcg/hexagon/circ.c
    M tests/tcg/hexagon/dual_stores.c
    M tests/tcg/hexagon/fpstuff.c
    M tests/tcg/hexagon/hex_sigsegv.c
    A tests/tcg/hexagon/hex_test.h
    M tests/tcg/hexagon/hvx_misc.c
    M tests/tcg/hexagon/load_align.c
    M tests/tcg/hexagon/load_unpack.c
    M tests/tcg/hexagon/mem_noshuf.c
    M tests/tcg/hexagon/mem_noshuf_exception.c
    M tests/tcg/hexagon/misc.c
    M tests/tcg/hexagon/multi_result.c
    M tests/tcg/hexagon/overflow.c
    M tests/tcg/hexagon/preg_alias.c
    M tests/tcg/hexagon/read_write_overlap.c
    M tests/tcg/hexagon/reg_mut.c
    M tests/tcg/hexagon/usr.c

  Log Message:
  -----------
  Merge tag 'pull-hex-20230526' of https://github.com/quic/qemu into staging

Hexagon update

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEENjXHiM5iuR/UxZq0ewJE+xLeRCIFAmRwv6QACgkQewJE+xLe
# RCLRvQf/e0utA8/KAYwmay4dYiiVlrtJ4UVpwogQ8JC7je5H2+Gv633P4BF8uGAF
# HmhdUk031jvG/BvKGH+493ESKgtIX3caLxJInPtYu3elqKxZhqKpke2VPF3srrwI
# Mli8IqdwE2scSilG591xTjhU8vBGSm+hiQptSg9OaSotVcH8Qc/32+vudnr2JZtK
# ko3MqISMW/KvfD+x47UcX4IX4bmQfDyysQITQs9lfwYgzv/4drl6/7CUFQZ3b8Go
# Rz4ClbYhKT8YybJjX+yaKuTaHSrL9r0+90ORzYisEYcPiOOChmy9vv4HbZ1zTCbY
# MVJM69IPdZDi1quE00jULYEEPrHRoA==
# =vczK
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri 26 May 2023 07:18:12 AM PDT
# gpg:                using RSA key 3635C788CE62B91FD4C59AB47B0244FB12DE4422
# gpg: Good signature from "Taylor Simpson (Rock on) <tsimpson@quicinc.com>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 3635 C788 CE62 B91F D4C5  9AB4 7B02 44FB 12DE 4422

* tag 'pull-hex-20230526' of https://github.com/quic/qemu:
  Hexagon (target/hexagon) Change Hexagon maintainer
  Hexagon: fix outdated `hex_new_*` comments
  target/hexagon/*.py: clean up used 'toss' and 'numregs' vars
  Hexagon (target/hexagon) Fix assignment to tmp registers
  Hexagon (tests/tcg/hexagon) Clean up Hexagon check-tcg tests

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/f9bdb3818faa...9c9fff18c45b