[Qemu-commits] [qemu/qemu] d73ca5: hw/audio/virtio-snd: fix invalid param check

[Helge Deller]

  Branch: refs/heads/staging-8.2
  Home:   https://github.com/qemu/qemu
  Commit: d73ca551a0c0b16413efe531c978c638d12eb783
      
https://github.com/qemu/qemu/commit/d73ca551a0c0b16413efe531c978c638d12eb783
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M hw/audio/virtio-snd.c

  Log Message:
  -----------
  hw/audio/virtio-snd: fix invalid param check

Commit 9b6083465f ("virtio-snd: check for invalid param shift
operands") tries to prevent invalid parameters specified by the
guest. However, the code is not correct.

Change the code so that the parameters format and rate, which are
a bit numbers, are compared with the bit size of the data type.

Fixes: 9b6083465f ("virtio-snd: check for invalid param shift operands")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20240802071805.7123-1-vr_qemu@t-online.de>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 7d14471a121878602cb4e748c4707f9ab9a9e3e2)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


  Commit: e98b0c7b29abb9b85c1081fa2ce5c214d5bc12eb
      
https://github.com/qemu/qemu/commit/e98b0c7b29abb9b85c1081fa2ce5c214d5bc12eb
  Author: Helge Deller <deller@gmx.de>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M target/hppa/cpu.h
    M target/hppa/helper.c

  Log Message:
  -----------
  target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64

While adding hppa64 support, the psw_v variable got extended from 32 to 64
bits.  So, when packaging the PSW-V bit from the psw_v variable for interrupt
processing, check bit 31 instead the 63th (sign) bit.

This fixes a hard to find Linux kernel boot issue where the loss of the PSW-V
bit due to an ITLB interruption in the middle of a series of ds/addc
instructions (from the divU milicode library) generated the wrong division
result and thus triggered a Linux kernel crash.

Link: 
https://lore.kernel.org/lkml/718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net/
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Fixes: 931adff31478 ("target/hppa: Update cpu_hppa_get/put_psw for hppa64")
Cc: qemu-stable@nongnu.org # v8.2+
(cherry picked from commit ead5078cf1a5f11d16e3e8462154c859620bcc7e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: context fixup in target/hppa/helper.c due to lack of
 v9.0.0-688-gebc9401a4067 "target/hppa: Split PSW X and B into their own field")


Compare: https://github.com/qemu/qemu/compare/5a97551d73ae...e98b0c7b29ab

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications