qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 68eef6: qapi/char: Supply missing member docu


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 68eef6: qapi/char: Supply missing member documentation
Date: Thu, 03 Oct 2024 05:02:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 68eef67af17e97475b5ee8a202ac10c9fa45ac49
      
https://github.com/qemu/qemu/commit/68eef67af17e97475b5ee8a202ac10c9fa45ac49
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/char.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/char: Supply missing member documentation

Since we neglect to document several members of ChardevBackendKind,
their description in the QEMU QMP Reference manual is "Not
documented".  Fix that, and improve the existing member documentation.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240911112545.2248881-2-armbru@redhat.com>


  Commit: ee43800d17f1942915018e4128ac0f261a12bab4
      
https://github.com/qemu/qemu/commit/ee43800d17f1942915018e4128ac0f261a12bab4
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/common.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/common: Supply missing member documentation

Since we neglect to document the members of GrabToggleKeys, their
description in the QEMU QMP Reference manual is "Not documented".  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240911112545.2248881-3-armbru@redhat.com>


  Commit: 6b4672663168e5c43d034e9a9bf29502eef3285a
      
https://github.com/qemu/qemu/commit/6b4672663168e5c43d034e9a9bf29502eef3285a
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/crypto.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/crypto: Supply missing member documentation

Since we neglect to document the members of QCryptoAkCipherKeyType,
their description in the QEMU QMP Reference manual is "Not
documented".  Fix that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240911112545.2248881-4-armbru@redhat.com>


  Commit: 8fdec50a9d5cf415747c4fbe8184e4ebd77dcc72
      
https://github.com/qemu/qemu/commit/8fdec50a9d5cf415747c4fbe8184e4ebd77dcc72
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/introspect.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/introspect: Supply missing member documentation

Since we neglect to document the members of JSONType, their
description in the QEMU QMP Reference manual is "Not documented".  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20240911112545.2248881-5-armbru@redhat.com>


  Commit: 83b91c9d50009ba9c17c50f1d95bd901cb959359
      
https://github.com/qemu/qemu/commit/83b91c9d50009ba9c17c50f1d95bd901cb959359
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/pci.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/pci: Supply missing member documentation

Since we neglect to document a member of PciMemoryRegion, its
description in the QEMU QMP Reference manual is "Not documented".  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240911112545.2248881-6-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


  Commit: c91f44ff1692bdb0e3c91b3db253c43491cbe993
      
https://github.com/qemu/qemu/commit/c91f44ff1692bdb0e3c91b3db253c43491cbe993
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/pragma.json
    M qapi/rocker.json

  Log Message:
  -----------
  qapi/rocker: Supply missing member documentation

Since we neglect to document the argument of query-rocker and
query-rocker-ports, their description in the QEMU QMP Reference manual
is "Not documented".  Fix that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240911112545.2248881-7-armbru@redhat.com>


  Commit: 923b9687289e9febe18dee0f3f2b062b4a1fe57f
      
https://github.com/qemu/qemu/commit/923b9687289e9febe18dee0f3f2b062b4a1fe57f
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/cxl.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi/cxl: Supply missing member documentation

Since we neglect to document a member of CxlCorErrorType, its
description in the QEMU QMP Reference manual is "Not documented".  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240911112545.2248881-8-armbru@redhat.com>


  Commit: 4707331d1570e627b8fb72986227d1e2ac06e238
      
https://github.com/qemu/qemu/commit/4707331d1570e627b8fb72986227d1e2ac06e238
  Author: zhenwei pi <pizhenwei@bytedance.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/cryptodev.json
    M qapi/pragma.json

  Log Message:
  -----------
  qapi: Document QCryptodevBackendServiceType

QCryptodevBackendServiceType was introduced by
bc304a6442e (cryptodev: Introduce server type in QAPI). However there
is a lack of member description.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Drop QCryptodevBackendServiceType from pragma documentation-exceptions]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240911112545.2248881-9-armbru@redhat.com>


  Commit: 0d5b2062289e22fbd54cfd04cd4a77c01c327568
      
https://github.com/qemu/qemu/commit/0d5b2062289e22fbd54cfd04cd4a77c01c327568
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/block-core.json

  Log Message:
  -----------
  qapi: Drop "with an explanation" from error descriptions

All errors come with an explanation, namely the human-readable error
message in the error response's @desc member.  Drop the redundant
"with an explanation" phrase.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240911132459.2548063-2-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>


  Commit: b3bd7617dbae8e5f84c27a1ab8df89cba371a276
      
https://github.com/qemu/qemu/commit/b3bd7617dbae8e5f84c27a1ab8df89cba371a276
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qapi/block-core.json

  Log Message:
  -----------
  qapi/block-core: Drop drive-backup's "Any other error" documentation

We've always been rather lax about documenting errors.  Many "Errors"
sections are obviously not exhaustive.  Only drive-backup is explicit
about this: "Any other error returns a GenericError".

Not useful.  Drop.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240911132459.2548063-3-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>


  Commit: 25bc7d16fa96b0ff881c83ed225ea380fe427c78
      
https://github.com/qemu/qemu/commit/25bc7d16fa96b0ff881c83ed225ea380fe427c78
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M util/qemu-coroutine.c

  Log Message:
  -----------
  util/coroutine: fix -Werror=maybe-uninitialized false-positive

../util/qemu-coroutine.c:150:8: error: ‘batch’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>


  Commit: 5491295fa5da5e424f0972ddf709412197020747
      
https://github.com/qemu/qemu/commit/5491295fa5da5e424f0972ddf709412197020747
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M util/qemu-timer.c

  Log Message:
  -----------
  util/timer: fix -Werror=maybe-uninitialized false-positive

../util/qemu-timer.c:198:24: error: ‘expire_time’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../util/qemu-timer.c:476:8: error: ‘rearm’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


  Commit: 0a0744f6d868fc2d809d8fac7d25dea2272a1105
      
https://github.com/qemu/qemu/commit/0a0744f6d868fc2d809d8fac7d25dea2272a1105
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  hw/qxl: fix -Werror=maybe-uninitialized false-positives

../hw/display/qxl.c:1352:5: error: ‘pci_region’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../hw/display/qxl.c:1365:22: error: ‘pci_start’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


  Commit: 73ce9bbf8a5242e2d1da76cca7ef031315cad721
      
https://github.com/qemu/qemu/commit/73ce9bbf8a5242e2d1da76cca7ef031315cad721
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M nbd/client-connection.c

  Log Message:
  -----------
  nbd: fix -Werror=maybe-uninitialized false-positive

../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>


  Commit: ba11c88d7a3b7c4d40afec4b84e0660815b2e2d7
      
https://github.com/qemu/qemu/commit/ba11c88d7a3b7c4d40afec4b84e0660815b2e2d7
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M block/mirror.c

  Log Message:
  -----------
  block/mirror: fix -Werror=maybe-uninitialized false-positive

../block/mirror.c:1066:22: error: ‘iostatus’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 5791ba529b0fa0e2a74410a6985e0d8a94cc843a
      
https://github.com/qemu/qemu/commit/5791ba529b0fa0e2a74410a6985e0d8a94cc843a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M block/mirror.c

  Log Message:
  -----------
  block/mirror: fix -Werror=maybe-uninitialized false-positive

../block/mirror.c:404:5: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../block/mirror.c:895:12: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../block/mirror.c:578:12: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Change a variable to int, as suggested by Manos: "bdrv_co_preadv()
which is int and is passed as an int argument to mirror_read_complete()"

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: ce2a0ef65c3bb857985cd4b9c1f2145c81f2cdec
      
https://github.com/qemu/qemu/commit/ce2a0ef65c3bb857985cd4b9c1f2145c81f2cdec
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M block/stream.c

  Log Message:
  -----------
  block/stream: fix -Werror=maybe-uninitialized false-positives

../block/stream.c:193:19: error: ‘unfiltered_bs’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../block/stream.c:176:5: error: ‘len’ may be used uninitialized 
[-Werror=maybe-uninitialized]
trace/trace-block.h:906:9: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


  Commit: 7d6e63d982004abac0690e0ca57946fb330d2e70
      
https://github.com/qemu/qemu/commit/7d6e63d982004abac0690e0ca57946fb330d2e70
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  hw/ahci: fix -Werror=maybe-uninitialized false-positive

../hw/ide/ahci.c:989:58: error: ‘tbl_entry_size’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>


  Commit: fa7e5e9e1c52b2b197f478265b221e766679a236
      
https://github.com/qemu/qemu/commit/fa7e5e9e1c52b2b197f478265b221e766679a236
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/scsi/vhost-scsi.c

  Log Message:
  -----------
  hw/vhost-scsi: fix -Werror=maybe-uninitialized

../hw/scsi/vhost-scsi.c:173:12: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]

It can be reached when num_queues=0. It probably doesn't make much sense
to instantiate a vhost-scsi with 0 IO queues though. For now, make
vhost_scsi_set_workers() return success/0 anyway, when no workers have
been setup.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


  Commit: ea34d1dd968956ec418c4278b39b6c44bb606d9c
      
https://github.com/qemu/qemu/commit/ea34d1dd968956ec418c4278b39b6c44bb606d9c
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/sd/sdhci.c

  Log Message:
  -----------
  hw/sdhci: fix -Werror=maybe-uninitialized false-positive

../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized 
[-Werror=maybe-uninitialized]

False-positive, because "length" is non-null.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


  Commit: ae11f6ca66f2de9a7e2f0445ac870824e7fa8eee
      
https://github.com/qemu/qemu/commit/ae11f6ca66f2de9a7e2f0445ac870824e7fa8eee
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M block/block-copy.c

  Log Message:
  -----------
  block/block-copy: fix -Werror=maybe-uninitialized false-positive

../block/block-copy.c:591:12: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 7cea863719f83b2489e939e9f5a9acce060ec21d
      
https://github.com/qemu/qemu/commit/7cea863719f83b2489e939e9f5a9acce060ec21d
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M migration/dirtyrate.c
    M migration/migration.c

  Log Message:
  -----------
  migration: fix -Werror=maybe-uninitialized false-positives

../migration/dirtyrate.c:186:5: error: ‘records’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../migration/dirtyrate.c:168:12: error: ‘gen_id’ may be used uninitialized 
[-Werror=maybe-uninitialized]
../migration/migration.c:2273:5: error: ‘file’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Hyman Huang <yong.huang@smartx.com>


  Commit: 26a690c36e379c5c3985ba1166310c576095d7ad
      
https://github.com/qemu/qemu/commit/26a690c36e379c5c3985ba1166310c576095d7ad
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/block/virtio-blk.c

  Log Message:
  -----------
  hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive

../hw/block/virtio-blk.c:1212:12: error: ‘rq’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


  Commit: 85f99eb2cb9100dcabb43e9380811040e88642d8
      
https://github.com/qemu/qemu/commit/85f99eb2cb9100dcabb43e9380811040e88642d8
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration: fix -Werror=maybe-uninitialized false-positive

../migration/ram.c:1873:23: error: ‘dirty’ may be used uninitialized 
[-Werror=maybe-uninitialized]

When 'block' != NULL, 'dirty' is initialized.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>


  Commit: 0d0f95c7bcde008510e6c9013e00b25941c83871
      
https://github.com/qemu/qemu/commit/0d0f95c7bcde008510e6c9013e00b25941c83871
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M linux-user/hppa/cpu_loop.c

  Log Message:
  -----------
  linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’:
../linux-user/hppa/cpu_loop.c:106:17: error: ‘ret’ may be used uninitialized 
[-Werror=maybe-uninitialized]
  106 |     env->gr[28] = ret;

Add g_assert_not_reached() to help compiler, as suggested by Laurent.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 3cd804c565a7eb7804217fc67169b73c27671ab7
      
https://github.com/qemu/qemu/commit/3cd804c565a7eb7804217fc67169b73c27671ab7
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M target/loongarch/gdbstub.c

  Log Message:
  -----------
  target/loongarch: fix -Werror=maybe-uninitialized false-positive

../target/loongarch/gdbstub.c:55:20: error: ‘val’ may be used uninitialized 
[-Werror=maybe-uninitialized]
   55 |             return gdb_get_reg32(mem_buf, val);
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../target/loongarch/gdbstub.c:39:18: note: ‘val’ was declared here
   39 |         uint64_t val;

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 4770030bcb87a910e34f60c03c439b385b33c2da
      
https://github.com/qemu/qemu/commit/4770030bcb87a910e34f60c03c439b385b33c2da
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M tests/unit/test-bdrv-drain.c
    M tests/unit/test-block-iothread.c

  Log Message:
  -----------
  tests: fix -Werror=maybe-uninitialized false-positive

../tests/unit/test-block-iothread.c:773:17: error: ‘job’ may be used 
uninitialized [-Werror=maybe-uninitialized]
/usr/include/glib-2.0/glib/gtestutils.h:73:53: error: ‘ret’ may be used 
uninitialized [-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 3073c6b99557042476add4ddbcc8c834ae70fce5
      
https://github.com/qemu/qemu/commit/3073c6b99557042476add4ddbcc8c834ae70fce5
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/virtio/vhost-shadow-virtqueue.c

  Log Message:
  -----------
  hw/virtio: fix -Werror=maybe-uninitialized

../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used 
uninitialized [-Werror=maybe-uninitialized]

Set `r` to 0 at every loop, since we don't check vhost_svq_get_buf()
return value.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>


  Commit: 95eaaa7690cf6805de14ef2b3d895025ff204f8a
      
https://github.com/qemu/qemu/commit/95eaaa7690cf6805de14ef2b3d895025ff204f8a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M hw/virtio/vhost-shadow-virtqueue.c

  Log Message:
  -----------
  hw/virtio: freeing leaked memory from vhost_svq_get_buf in vhost_svq_poll

vhost_svq_get_buf() may return a VirtQueueElement that should be freed.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>


  Commit: eb5d28c783078ad2d7fb42349e146190cd98678b
      
https://github.com/qemu/qemu/commit/eb5d28c783078ad2d7fb42349e146190cd98678b
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M block/file-posix.c

  Log Message:
  -----------
  block: fix -Werror=maybe-uninitialized false-positive

../block/file-posix.c:1405:17: error: ‘zoned’ may be used uninitialized 
[-Werror=maybe-uninitialized]
 1405 |     if (ret < 0 || zoned == BLK_Z_NONE) {

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 79660687df4ed99117cda77012a8a39616cc6b45
      
https://github.com/qemu/qemu/commit/79660687df4ed99117cda77012a8a39616cc6b45
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M fsdev/9p-iov-marshal.c

  Log Message:
  -----------
  fsdep/9p: fix -Werror=maybe-uninitialized false-positive

../fsdev/9p-iov-marshal.c:93:23: error: ‘val’ may be used uninitialized 
[-Werror=maybe-uninitialized]
and similar

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 8f3375434d45e56db51b5ecd4d8a929146ba5641
      
https://github.com/qemu/qemu/commit/8f3375434d45e56db51b5ecd4d8a929146ba5641
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom/object: fix -Werror=maybe-uninitialized

object_resolve_path_type() sets *ambiguousp only when it is.

Fixes: 81c48dd79655 (hw/i386/acpi: Add object_resolve_type_unambiguous to 
improve modularity)
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


  Commit: 9247378df2b16f427ae858787f84a55b073446b1
      
https://github.com/qemu/qemu/commit/9247378df2b16f427ae858787f84a55b073446b1
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M qapi/block-core.json
    M qapi/char.json
    M qapi/common.json
    M qapi/crypto.json
    M qapi/cryptodev.json
    M qapi/cxl.json
    M qapi/introspect.json
    M qapi/pci.json
    M qapi/pragma.json
    M qapi/rocker.json

  Log Message:
  -----------
  Merge tag 'pull-qapi-2024-10-02' of https://repo.or.cz/qemu/armbru into 
staging

QAPI patches patches for 2024-10-02

# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEENUvIs9frKmtoZ05fOHC0AOuRhlMFAmb88k4SHGFybWJydUBy
# ZWRoYXQuY29tAAoJEDhwtADrkYZTr3sP/iT8x2pSy6MMOLnuzo/jsMp238U5kb88
# LjDPkUkYhg9m9Z05Odm8g2X3ZjAM0ZrxnSjCZ+yb3HcvaaVN29156ebueJetYSLY
# 4lN1IMBdQcVJuRWAaURd42ADPEaVn3+xk9eZtaakxP3a9PnoqDIvc+WbEVFgWkPs
# l2CgEqsoEaX8Ui1lDDJIEiZhjCVd4Gj3rT9BuchAtljmiO59c91O+H+OSg1I8YF4
# 46xa0rulmYQSv18fEt7OVfwVTJMiiXXXX4cE1zEneGzkvAnv1NRjAH3E4O9Wf97Q
# cNFOEXrhJvXTAh5sVF+1Mp4JktYsKBgUADwqPJJ26SXeuum+15HXt038cNqJlzyl
# yr+fg2vubI5iVQyMFP+Rlvx54d94C2NAqa/JudfL3iu7uJKKNxzjFdJqhwNFPvaL
# WVzBX66+ZV97D/ujqige99As58RZXFlR2ccLELsg7B6T307MFI/XhfFeG2WFViZi
# fFadS9OfNfhzpo/HfOPtJXnU7cBviwormIY7tKuo7jhyXV8YvKvvVpMMYxKJk68o
# wVUC6OBEQ+NqSCjUW+LNzIdpEDk6qL01rIgD48ywv0aV8FhUiVURVLBu6loEo/ib
# pBR/W6k2AudnJ+mLfkIGCXSSu3RWNx5yayS3LcEE1dKQJquyn8qJk8GMEwhRM8tF
# /NO4P74VmUUJ
# =f3Zh
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 02 Oct 2024 08:12:14 BST
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* tag 'pull-qapi-2024-10-02' of https://repo.or.cz/qemu/armbru:
  qapi/block-core: Drop drive-backup's "Any other error" documentation
  qapi: Drop "with an explanation" from error descriptions
  qapi: Document QCryptodevBackendServiceType
  qapi/cxl: Supply missing member documentation
  qapi/rocker: Supply missing member documentation
  qapi/pci: Supply missing member documentation
  qapi/introspect: Supply missing member documentation
  qapi/crypto: Supply missing member documentation
  qapi/common: Supply missing member documentation
  qapi/char: Supply missing member documentation

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 423be09ab9492735924e73a2d36069784441ebc6
      
https://github.com/qemu/qemu/commit/423be09ab9492735924e73a2d36069784441ebc6
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M block/block-copy.c
    M block/file-posix.c
    M block/mirror.c
    M block/stream.c
    M fsdev/9p-iov-marshal.c
    M hw/block/virtio-blk.c
    M hw/display/qxl.c
    M hw/ide/ahci.c
    M hw/scsi/vhost-scsi.c
    M hw/sd/sdhci.c
    M hw/virtio/vhost-shadow-virtqueue.c
    M linux-user/hppa/cpu_loop.c
    M migration/dirtyrate.c
    M migration/migration.c
    M migration/ram.c
    M nbd/client-connection.c
    M qom/object.c
    M target/loongarch/gdbstub.c
    M tests/unit/test-bdrv-drain.c
    M tests/unit/test-block-iothread.c
    M util/qemu-coroutine.c
    M util/qemu-timer.c

  Log Message:
  -----------
  Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu 
into staging

-Werror=maybe-uninitialized fixes

# -----BEGIN PGP SIGNATURE-----
#
# iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmb9PWwcHG1hcmNhbmRy
# ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5ebjD/43hDmLUGtq3WvEzG7T
# A9LjvKJ4bZrJkjwuogMUAAq89L65OcHdnXARgueSwt6Mi0qoakj7F2Ymv2oSw6Gq
# 33uspja5PySCGkAs3qQ9lb/zsPFNmXZkhR/XaDGqAFjI24w/QTMq+wwiEuqjVC6P
# 2C4VEXxz2Qn+WTQQjzpQ7E7CAUE/grHqflm+5JFICHywjj+oyoa5EnqEXHNlMb2J
# b8YVJ3z4SPNkq3VkQMHT0+aVO3+uS0NGxfXxGkVsSTdG1NlvwUr7bSomwZfXiUvP
# C0meotfsZTHZCJRtskCvn3kAd3E5EmIjMyDsbhqB0doCLCElV4AlzWSscy1y/GO+
# xm49Kutc+GRx/pztVMGzmC7aJ3Gwa8gKIrY1C/OvO8G2dZrJmTs2ydD4J9mIGxvC
# 1p1XeHZi8UOVshBDyAKRovKGzGiRtoC05SvjPOgB58RYGbUfFYHUOah3qYfRRZSw
# nPOXiwcrqiIlzkPRXB1ACVLfoZAHWzEFhrGxIKVdHABfwg8Rt9SmJq3JX8ysbKUJ
# FUI0/ZExrzGTURWWCm48k2rXZGKG/YSgvdmsSB5QmPEdrrb2jKqp5dmAbg3o/04b
# z4A7AatVNfK3tG69/hD1PwAy50q/sbbRUL9ZbBnc4Fnx1xyAOL4LgZ2tMov/jQWE
# 1SXLu8GKi4Yt76hUXFn1anqR0A==
# =zBkM
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 02 Oct 2024 13:32:44 BST
# gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
# gpg:                issuer "marcandre.lureau@redhat.com"
# gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" 
[full]
# gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" 
[full]
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu: (22 
commits)
  qom/object: fix -Werror=maybe-uninitialized
  fsdep/9p: fix -Werror=maybe-uninitialized false-positive
  block: fix -Werror=maybe-uninitialized false-positive
  hw/virtio: freeing leaked memory from vhost_svq_get_buf in vhost_svq_poll
  hw/virtio: fix -Werror=maybe-uninitialized
  tests: fix -Werror=maybe-uninitialized false-positive
  target/loongarch: fix -Werror=maybe-uninitialized false-positive
  linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
  migration: fix -Werror=maybe-uninitialized false-positive
  hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive
  migration: fix -Werror=maybe-uninitialized false-positives
  block/block-copy: fix -Werror=maybe-uninitialized false-positive
  hw/sdhci: fix -Werror=maybe-uninitialized false-positive
  hw/vhost-scsi: fix -Werror=maybe-uninitialized
  hw/ahci: fix -Werror=maybe-uninitialized false-positive
  block/stream: fix -Werror=maybe-uninitialized false-positives
  block/mirror: fix -Werror=maybe-uninitialized false-positive
  block/mirror: fix -Werror=maybe-uninitialized false-positive
  nbd: fix -Werror=maybe-uninitialized false-positive
  hw/qxl: fix -Werror=maybe-uninitialized false-positives
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/35ba77d2fcd1...423be09ab949

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]