Re: [Qemu-devel] [PATCH] Darwin asm fix

[Pierre d'Herbemont]

On 21 janv. 04, at 21:09, Gwenole Beauchesne wrote:

> In practise, and since you appear to forcibly define __powerpc__ (though __ppc__ exists), this means that you will have to arrange testandset() asm statements to use \n instead of ';' as the instruction separator.

Thanks! I didn't notice this one, here is the correction. I prefer to define __powerpc__ because I think it is better to have the same asm instruction base (or C functions) between ppc platforms, and fix the assembly if it needs to be done, than having long code dupplication, or double #if defined(__ppc__) || defined(__powerpc__).

Also regarding an eventual Mac OS X port, I have nothing functional... But I did an old dyngen (from qemu 0.4.3) mach-o port  which should be mostly working, so it will be easier to do the full-port on darwin since it won't require a cross elf compiler - as soon as I get it working in latest qemu.

Pierre

qemuasm2.diff.txt
Description: Text document