Re: [Qemu-devel] [PATCH] security_20040618

[Fabrice Bellard]

Tim wrote:
> Updates to this, from the previous version two days ago, include
> additional strcpy replacements, as well as TODO comments pointing out
> unhealthy calls to {m,re}alloc, which don't check for NULL return
> values. (I am not sure how to handle error return codes in most places,
> so just comments for now.)  Also pstrcpy() in vl.c was simplified, but
> should behave exactly the same as before.

Thank you for the fixes.

For malloc() returning NULL, if your patch just says "malloc error", I 
don't consider it is a good fix.

I see that you added many snprintf(). I don't like that because 
pstrcpy() does exactly the right thing and it is faster and simpler.

Fabrice.