Re: [Qemu-devel] [Patch] Clear memory using memset instead of handcoded loop

[Karl Magdsick]

Daniel, 

Good catch!  

Is the section still a hot spot in your tests?  Maybe a macro or
inline function would be more appropriate.  The macro/inline function
could be defined to use memset for now, and later changed to use
optimized inline assembly language on architectures that don't inline
memset.  It is also likely possible to write a slightly faster inline
assembly routine since we know that we want to always set the memory
to zero, while memset has to allow for an arbitrary fill value.


-Karl

On Sun, 3 Oct 2004 13:45:51 +0200, Daniel Egger <address@hidden> wrote:
> Hija,
> 
> while profiling the lastest qemu snapshot on OS X I discovered
> that one of the tb_hash clearing routines turnes up to be a
> "hotspot" during my typical test procedure which includes
> booting an installed Debian Sarge RC.
> 
> Attached patch turnes three handcoded memory clearing routines
> into a call to memset which will be optimized by every serious
> compiler into either a very optimized inline sequence for the
> CPU or at least into a call of an optimized memory clearing
> function (bzero on Darwin 7.5 with gcc 3.3).
> 
> Please CC me on replies.
> 
> 
> 
> 
> Servus,
>        Daniel
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 
> 
> 
>