Re: [Qemu-devel] [PATCH][RFC] Make documentation optional

[Bernhard Fischer]

On Fri, Feb 10, 2006 at 08:48:39AM +0100, Michael Renzmann wrote:
>Hi again.
>
>On Fri, 2006-02-10 at 08:43 +0100, Michael Renzmann wrote:
>> The attached patch ...
>
>... contained some stuff that should have been ignored by diff. Sorry,
>revised patch attached to this mail.

>diff -urN qemu-cvs/Makefile qemu-cvs-o42/Makefile
>--- qemu-cvs/Makefile  2006-02-08 23:39:17.000000000 +0100
>+++ qemu-cvs-o42/Makefile      2006-02-10 08:31:17.000000000 +0100
>@@ -52,11 +53,19 @@
>                        pc-bios/ppc_rom.bin pc-bios/video.x \
>                        pc-bios/proll.elf \
>                        pc-bios/linux_boot.bin "$(datadir)"
>-      mkdir -p "$(docdir)"
>-      install -m 644 qemu-doc.html  qemu-tech.html "$(docdir)"

What about just doing this
        -install -m 644 qemu-doc.html  qemu-tech.html "$(docdir)"
>@@ -78,15 +87,27 @@
> 
> # documentation
> %.html: %.texi
>-      texi2html -monolithic -number $<
>+      if [ -n "$(shell which texi2html)" ]; then \
>+          texi2html -monolithic -number $< ; \

same here:
        -texi2html -monolithic -number $< ;
>-      pod2man --section=1 --center=" " --release=" " qemu.pod > $@
>+      if [ -n "$(shell which pod2man)" ]; then \
>+              ./texi2pod.pl $< qemu.pod ; \
>+              pod2man --section=1 --center=" " --release=" " qemu.pod > $@ ; \
>+      else \
>+              echo "WARNING: pod2man not found, skipped generation of" $@ ; \
>+      fi
> 
> qemu-img.1: qemu-img.texi
>-      ./texi2pod.pl $< qemu-img.pod
>-      pod2man --section=1 --center=" " --release=" " qemu-img.pod > $@

ditto:
        -pod2man --section=1 --center=" " --release=" " qemu-img.pod > $@