Re: [Qemu-devel] [PATCH] Minor mips-related patchlet

[Thiemo Seufer]

On Sat, Mar 11, 2006 at 03:01:05PM +0000, Paul Brook wrote:
> > Index: target-mips/op_mem.c
> >...
> > +extern void dump_sc (void);
> 
> Having function prototypes in .c files is wrong. I added it to exec.h instead.
> 
> > +void glue(op_store_T2_gpr_gpr, REG) (void)
> > +{
> > +    env->gpr[REG] = T2;
> > +    RETURN();
> > +}
> 
> I don't think there's any point adding this unless it's actually used. The 
> ARM 
> target doesn't have this op either.

Should it then be removed for other targets where it presumably isn't
used as well?


Thiemo