Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

[Leonardo E. Reiter]

I was talking about enabling the use of the -bgr flag at compile time, 
to save the check at runtime if the user doesn't even care about the 
flag, not forcing the determination of the blit order altogether at 
compile-time.  In any case, this is moot, your clarification on how to 
better implement it makes it much more clear to me and is a much better 
idea.  Mails to the list are a bit delayed, that's all ;)

Thanks,

Leo

Paul Brook wrote:
> On Monday 10 April 2006 17:44, Leonardo E. Reiter wrote:
>
> > Actually it should probably be made conditionally compiled for now,
> > until the VGA architecture changes to something more efficient.  Would
> > you agree with that?  That way, people who know they will need the hack
> > can enable it at configure/compile time, and the rest will not be affected.
> >
> > How does that sound?  I'd be happy to post an updated patch that does that.
>
>
> Making it a configure option sounds a stunningly bad idea. If you're going 
> down that route you may as well make all the output format selection a 
> compile-time option.
>
> Paul

--
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com