[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxcca

From: Blue Swirl
Subject: RE: [Qemu-devel] [PATCH] SPARC target : Fix carry flag update in addxccand subxc
Date: Mon, 10 Apr 2006 19:57:19 +0200

I send a patch that should fix a bug in the update of carry flag for addxcc
and subxcc instructions when the carry flag is set before the evaluation of
the instruction.
(the fix is identical to what is done in the similar instruction
op_adcl_T0_T1_cc for arm target)

Looks good, but what about V flag?

Instead of adding a new condition, perhaps you could store the intermediate results of addition, like T0 + FLAG_SET(PSR_CARRY) and use that later in the comparison?

BTW: ARM env->NZF idea could be used to Sparc as well.

FREE pop-up blocking with the new MSN Toolbar - get it now! http://toolbar.msn.click-url.com/go/onm00200415ave/direct/01/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]