[Qemu-devel] Re: FreeBSD qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED)

[Juergen Lock]

On Tue, Jul 25, 2006 at 07:06:02PM -0400, Jung-uk Kim wrote:
> On Tuesday 25 July 2006 01:47 pm, Juergen Lock wrote:
> > @@ -47,21 +43,20 @@
> >   void set_float_rounding_mode(int val STATUS_PARAM)
> >   {
> >       STATUS(float_rounding_mode) = val;
> > --#if defined(_BSD) && !defined(__APPLE__)
> > -+#if defined(_BSD) && !defined(__APPLE__) && \
> > -+    (defined(__FreeBSD__) && __FreeBSD_version < 500000)
> > +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && 
> > HOST_SOLARIS < 10)
> > ++#if (defined(_BSD) && (defined(__FreeBSD__) && __FreeBSD_version < 
> > 500000)) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 
> > 10)
> > fpsetround(val);
> >   #elif defined(__arm__)
> >       /* nothing to do */
> 
> FYI, a parenthesis is misplaced (Note: I just rearranged
> the order to be more clearer):
>
> +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && 
> HOST_SOLARIS < 10)
> ++#if (defined(_BSD) && !defined(__APPLE__) && (defined(__FreeBSD__) && 
> __FreeBSD_version < 500000)) || \
> ++    (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)

 Well this should actually be:

#if defined(_BSD) && !defined(__APPLE__) && !defined(__FreeBSD__) || \
    (defined(__FreeBSD__) && __FreeBSD_version < 500000) || \
    (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)

 if it ever was going to be merged back. (wrongly excluded non-FreeBSD BSDs)
> 
> Actually it is an upstream bug, though.

 Nah, the parens there are okay... (|| binds less than &&, i.e.
1 || 0 && 0 evaluates to 1.)

 On another note, am i the only one seeing those -kernel-kqemu problems?

 thanx,
        Juergen