Re: [Qemu-devel] Re: [RFC][PATCH] make sure disk writes actually hit disk

[Rik van Riel]

Anthony Liguori wrote:

> Right now Fabrice is working on rewriting the block API to be
> asynchronous.  There's been quite a lot of discussion about why using
> threads isn't a good idea for this

Agreed, AIO is the way to go in the long run.

> With a proper async API, is there any reason why we would want this to be
> tunable?  I don't think there's much of a benefit of prematurely claiming
> a write is complete especially once the SCSI emulation can support
> multiple simultaneous requests.

You're right.  This O_SYNC bandaid should probably stay in place
to prevent data corruption, until the AIO framework is ready to
be used.

No sense investing too much time in a fancier band-aid.

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan