qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix warnings in mips_r4k.c


From: Dirk Behme
Subject: Re: [Qemu-devel] [PATCH] Fix warnings in mips_r4k.c
Date: Mon, 31 Jul 2006 15:18:37 +0200
User-agent: Mozilla Thunderbird 1.0.7 (X11/20050923)

Paul Brook wrote:
On Monday 31 July 2006 11:20, Dirk Behme wrote:

Fix warnings

hw/mips_r4k.c: In function  ‘mips_r4kc_init’:
hw/mips_r4k.c:230: warning: pointer targets in passing
argument 3 of ‘load_elf’ differ in signedness
hw/mips_r4k.c:256: warning: pointer targets in passing
argument 1 of ‘strcpy’ differ in signedness
Compile with -Wno-pointer-sign. gcc4 isn't really supported anyway.

Yes, I know ;) And yes, I know there are technical reasons for not supporting gcc4.

But do you wan't to say that at places, where because of typos or lazy programming and thus no technical reason for it (e.g. passing signed where calling function wants unsigned) it is better to disable warning with -Wno-pointer-sign instead of fixing it?

Note that I haven't fixed a lot of other similar warnings where there may be technical reasons for it. But in this file I thought its worth fixing and improving code quality.

Regards

Dirk







reply via email to

[Prev in Thread] Current Thread [Next in Thread]