Re: [Qemu-devel] [PATCH] Fix warnings in mips_r4k.c

[Paul Brook]

> >>hw/mips_r4k.c:256: warning: pointer targets in passing
> >>argument 1 of ‘strcpy’ differ in signedness
> >
> > Compile with -Wno-pointer-sign. gcc4 isn't really supported anyway.
>
> Yes, I know ;) And yes, I know there are technical reasons
> for not supporting gcc4.
>
> But do you wan't to say that at places, where because of
> typos or lazy programming and thus no technical reason for
> it (e.g. passing signed where calling function wants
> unsigned) it is better to disable warning with
> -Wno-pointer-sign instead of fixing it?

I'm saying that this warning occurs in sufficiently many places, many of which 
are questionable, that it's best to just turn it off.

The entry change is maybe acceptable. The strcpy change just uglifies the 
code.

Paul