[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu Makefile configure
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] qemu Makefile configure |
Date: |
Fri, 5 Jan 2007 01:03:13 +0000 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Thiemo Seufer wrote:
> Thiemo Seufer wrote:
> > Fabrice Bellard wrote:
> > > IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it
> > > is almost sure to break the dyngen stuff. If ever it is allowed, it
> > > should be done so that the CFLAGS for the files used by dyngen are not
> > > modified.
> >
> > That's why I made OP_CFLAGS a separate set of flags.
> >
> > I append the next version of the patch, which incorporates the
> > suggestions made by Daniel and Bernhard, and fixes a gcc3 detection
> > bug I introduced earlier.
>
> Next iteration, this uses BASE_CFLAGS and BASE_LDFLAGS instead of
> gmake's override feature.
Comitted, since it held up well for several people.
Thiemo