Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64

[Stuart Anderson]

On Mon, 19 Mar 2007, Paul Brook wrote:

> On Monday 19 March 2007 15:30, Stuart Anderson wrote:
> > When running ARM EABI binaries on x86_64, the target_eabi_flock64
> > structure is already padded correct so the padding is not needed.
> > This patch adds an #ifdef to only include the _pad member on 32-but
> > hosts.
>
> This is wrong. The struct is packed, so its layout should be independent of
> the host. How did you test your change?

I have a debian arm chroot setup. dpkg was unhappy, and I used gdb to
observe that there seemed to an extra 4 bytes of data in the middle of
the structure being passed into the host function.

I missed Kirill's patch as it came across before I got back on the list,
(and I missedit  when I browsed the archive as well). Since I should be
able to reproduce this, I'll test w/ his fix as well.



                                Stuart

Stuart R. Anderson                               address@hidden
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                 BD03 0A62 E534 37A7 9149