[Qemu-devel] [PATCH] qemu/target-ppc/cpu.h: fix "recent changes break Solaris 8 builds"

[Shaddy Baddah]

Hi,

Recent changes to qemu/target-ppc/cpu.h have broken Solaris 8 builds.
Specifically, the insertion of a <stdint.h> insertion, which is not part
of the Solaris C development library.

[SNIP]
make[1]: Entering directory `/var/home/shaddy/src/qemu/qemu/ppc-softmmu'
gcc -Wall -O2 -g -fno-strict-aliasing -I. -I..
-I/var/home/shaddy/src/qemu/qemu/target-ppc
-I/var/home/shaddy/src/qemu/qemu -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -I/var/home/shaddy/src/qemu/qemu/fpu -DHAS_AUDIO
-I/var/home/shaddy/src/qemu/qemu/slirp  -mcpu=ultrasparc -m32 -ffixed-g2
-ffixed-g3  -c -o vl.o /var/home/shaddy/src/qemu/qemu/vl.c
In file included from /var/home/shaddy/src/qemu/qemu/vl.h:85,
                from /var/home/shaddy/src/qemu/qemu/vl.c:24:
/var/home/shaddy/src/qemu/qemu/target-ppc/cpu.h:24:20: stdint.h: No such
file or directory
/var/home/shaddy/src/qemu/qemu/vl.c: In function `init_timer_alarm':
/var/home/shaddy/src/qemu/qemu/vl.c:1116: warning: label `use_itimer'
defined but not used
/var/home/shaddy/src/qemu/qemu/vl.c: In function `parse_host_port':
/var/home/shaddy/src/qemu/qemu/vl.c:3078: warning: subscript has type `char'
/var/home/shaddy/src/qemu/qemu/vl.c: In function `net_slirp_smb':
/var/home/shaddy/src/qemu/qemu/vl.c:3322: warning: int format, pid_t arg
(arg 4)
/var/home/shaddy/src/qemu/qemu/vl.c: At top level:
/var/home/shaddy/src/qemu/qemu/vl.c:1030: warning: 'start_rtc_timer'
defined but not used
make[1]: *** [vl.o] Error 1
make[1]: Leaving directory `/var/home/shaddy/src/qemu/qemu/ppc-softmmu'
make: *** [subdir-ppc-softmmu] Error 2
[/SNIP]

Simple solution is to replace inclusion, unconditionally, with
inttypes.h. This is consistent with the rest of the code-base. Patch
inline'ed below.

HTH,
Shaddy

Index: target-ppc/cpu.h
===================================================================
RCS file: /sources/qemu/qemu/target-ppc/cpu.h,v
retrieving revision 1.31
diff -u -r1.31 cpu.h
--- target-ppc/cpu.h    23 Mar 2007 09:45:27 -0000      1.31
+++ target-ppc/cpu.h    28 Mar 2007 16:30:12 -0000
@@ -21,7 +21,7 @@
 #define __CPU_PPC_H__

 #include "config.h"
-#include <stdint.h>
+#include <inttypes.h>

 #if defined(TARGET_PPC64) || (HOST_LONG_BITS >= 64)
 /* When using 64 bits temporary registers,