Re: [Qemu-devel] [PATCH, MIPS64] dmult & dmultu emulation

[Thiemo Seufer]

Aurelien Jarno wrote:
> On Wed, May 16, 2007 at 02:00:14AM +0200, Aurelien Jarno wrote:
> > On Tue, May 15, 2007 at 10:07:00PM +0100, Paul Brook wrote:
> > > > The patch below fixes the emulation of dmult and dmultu by doing a real
> > > > 64x64 -> 128 multiplication.
> > > 
> > > Can we share the implementation between targets please. We already have 
> > > an 
> > > implementation of mul64 in target-i386/helper.c.
> > > 
> > > I've no real preference which implementation we use, I just don't want 
> > > there 
> > > to be several of them.
> > 
> > Ok, please find an updated patch below. The multiplications functions
> > are in mul64.c and are now shared by the i386 and mips targets.
> > 
> 
> 03:40 < pbrook> aurel32: I think you've got a sign mismatch in your 
> target-i386/helper.c patch. You've replaced imul64 with mulu64.
> 
> I confirm I have made a mistake here, please find an updated patch
> below.

I moved the file to host-utils.c, there may be more such functions
needed some day.


Thiemo